930ebbf7d1
Add more todos for VST3 handling
2020-12-07 18:28:16 +01:00
27892d9e40
Get rid of debug prints in Vst3Bridge
2020-12-07 18:28:16 +01:00
76ad377522
Don't set __MINGW32__
...
This took me a few hours of non-stop headaches to figure out. Apparently
deep inside of Wine's headers having __MINGW32__ defined will cause some
GUIDs to be defined slightly differently. This normally wouldn't cause
issues, but when including `shellobj.h` or `objbase.h` this results in
multiple definition linking errors that are basically impossible to
diagnose.
2020-12-07 18:28:16 +01:00
0819e9fda9
Request/send config for VST3 plugins
...
Using the new Vst3MessageHandler.
2020-12-07 18:28:16 +01:00
2e9b100090
Add handlers for control messages and callbacks
2020-12-07 18:28:16 +01:00
6e5aa1c1c6
Add the Vst3Bridge boilerplate
2020-12-07 18:28:16 +01:00
6179fddbc8
Do some more testing and print some plugin info
2020-12-07 18:28:16 +01:00
ebc7802c08
Patch Win32 module loading to use Boost.Filesystem
...
C++17's `<filesystem>` header still doesn't seem to work with winegcc.
2020-12-07 18:28:16 +01:00
0b462c034e
Allow loading VST3 modules
...
Doesn't actually work yet or do anything, but it compiles and it runs.
2020-12-07 18:28:16 +01:00
9291ae7e42
Include the Win32 module loading implementation
2020-12-07 18:28:16 +01:00
715a95075b
Add required compiler args to the Wine VST3 dep
2020-12-07 18:28:16 +01:00
e273051a6c
Add a Vst3Bridge implementation file
2020-12-07 18:28:16 +01:00
84e13e556c
Add #ifdef WITH_VST3 guards around VST3 hosting
2020-12-07 18:28:16 +01:00
3db099e0fc
Also make the GroupHost plugin type agnostic
2020-12-07 18:28:16 +01:00
0eb80fe866
Add a general entry point to HostBridge
...
Since for all plugin types we would need to start listening for incoming
events this way.
2020-12-07 18:28:16 +01:00
eeb6acf8dd
Move event handling to a common HostBridge
2020-12-07 18:28:16 +01:00
f9a1bcd7bd
Split VST2 specific functionality into Vst2Logger
2020-12-07 18:28:16 +01:00
2230b5099f
Move logger to common/logging/common.h
2020-12-07 18:28:16 +01:00
278cd2e710
Spawn all hosts directly using HostRequest
...
This way we can set the plugin type inside of the `Vst*PluginBridge`
instance.
2020-12-07 18:28:16 +01:00
e21d3e020f
Rename GroupRequest to HostRequest
...
We'll also use this to encode information in when launching
`yabridge-host.exe` for individually hosted plugins.
2020-12-07 18:28:16 +01:00
1c5a9423d2
Print the plugin type on initialization
2020-12-07 18:28:16 +01:00
f9bb3822de
Pass plugin type when calling the host application
2020-12-07 18:28:16 +01:00
fa719c286d
Create base class for sockets and derive from that
...
Now the host launching procedure can be agnostic of the socket
implementation.
2020-12-07 18:28:16 +01:00
bb85d99657
Rename 'Sockets' to 'Vst2Sockets'
2020-12-07 18:28:16 +01:00
2fbd14908a
Split communication/vst2.h into common and VST2
...
So we can reuse the generic bits for our VST3 implementation.
2020-12-07 18:28:16 +01:00
46bc0301af
Move communication.h to communication/vst2.h
2020-12-07 18:28:16 +01:00
23d5567e72
Add a time info caching compatibility option #62
...
This is needed to get good performance out of SWAM Cello until this
issue is fixed by the plugin.
2020-11-30 14:49:02 +01:00
e08162fabf
Silence warnings on decltype() with Wine 5.22
...
There were already similar warnings on 32-bit winegcc, but now it also
happens on the 64-bit version. Instead of adding
`-Wno-ignored-attributes` we'll just sprinkle some warning ignores here
and there to prevent any other surprises.
2020-11-30 14:05:48 +01:00
49900e4753
Fix typo
2020-11-20 17:45:21 +01:00
28013cb6a7
Note that the effEditIdle issue is fixed in Ardour
...
For the upcoming Ardour 6.4 release:
https://github.com/Ardour/ardour/commit/f7cb1b0b481eeda755bdf8eb9fc5f90a81d2aa01
2020-11-20 15:59:40 +01:00
ff021d0581
Work around editor opening bug in Ardour 6.3
2020-11-13 17:08:41 +01:00
9300648067
Fix typo in vst2.cpp
2020-11-08 16:07:57 +01:00
d2500ff31d
Get rid of message loop skipping and EditorOpening
...
This special behaviour is no longer needed now that event handling is
fully concurrent and the Win32 message loop no longer blocks
`dispatch()` calls.
2020-11-07 22:06:58 +01:00
a0c0a86e2c
Drop the separate effProcessEvents socket
...
Now that event handling is fully concurrent and thus no longer gets
blocked by the Win32 message loop.
2020-11-07 20:54:33 +01:00
1c7e866609
No longer return a lambda in passthrough_event()
...
Now that it's no longer used directly this is no longer needed, and it's
much clearer without the lambda.
2020-11-06 17:17:36 +01:00
ba6381e3ae
Rename EventHandler::{send,receive} to *_event(s?)
...
Since it does something way more involved than
`SocketHandler::{send,receive_multi}`, and that makes it a bit confusing
if you don't already know about that (and even if you do).
2020-11-01 12:01:50 +01:00
fa01ac843b
Replace all non-group sockets with SocketHandler
...
This greatly reduces the amount of boilerplate and potential for error.
2020-10-30 13:30:08 +01:00
dd9957159a
Move the sockets after the threads in Vst2Bridge
...
This way the sockets can be destroyed before the threads, and we can
safely wait for the threads to shut down. I initially had Win32Thread
imitate std::jthread's join-on-destruct, but that was causing group
processes to hang. Now we can safely add that back again, and this will
fix some spurious segfaults during plugin scans when using plugin groups
containing a massive amount of plugins.
2020-10-28 21:05:14 +01:00
bece654c2d
Rename PluginContext to MainContext for clarity
2020-10-28 01:02:56 +01:00
fac820c25a
Execute all non-unsafe opcodes on calling thread
...
This will require more testing of course, but I think it should be safe.
This would increase the potential maximal throughput in group hosts
significantly.
2020-10-27 23:18:59 +01:00
28886e7073
Replace all threads with Win32Thread in Wine host
2020-10-27 18:29:38 +01:00
a6b5951d81
Replace std::jthread with Win32Thread everywhere
2020-10-27 17:38:13 +01:00
4038e198fe
Replace the Win32Thread proxy functions
...
Now that we can use lambdas instead.
2020-10-27 17:16:20 +01:00
e51c7f7ae3
Get rid of hack_reaper_update_display
...
It is now no longer necessary.
2020-10-27 11:13:39 +01:00
5b00ddb0c4
Fall back to waiting when socket is not yet ready
...
This can happen with plugin groups.
2020-10-27 11:13:39 +01:00
016ceccc18
Mark several opcodes as unsafe
...
These potentially perform GUI operations and should always be handled on
the main thread.
2020-10-27 11:13:39 +01:00
ca2b95e7aa
Handle dispatch() directly during event handling
...
When the message loop is active and we get an incoming dispatch() event,
we'll just handle it directly. In practice this would only be needed
when the event is a response to an `audioMaster()` call made during the
event loop, but we can't know that. This allows the `getProgram()`
during `audioMasterUpdateDisplay()` in REAPER and Renoise to work
correctly. Hopefully this doesn't cause random rare breakage.
2020-10-26 20:03:54 +01:00
8d7826f1df
Handle incoming events from off-threads separately
...
On the Wine side we want to handle most events on the main UI thread.
We'll assume any events coming in from a secondary socket are safe and
can be handled directly.
2020-10-26 13:45:37 +01:00
523ac64d11
Add a missing lock to reading from active_plugins
...
I've never seen this cause memory errors, but there exist a rare
situation where it could.
2020-10-26 12:45:38 +01:00
d82f8463d9
Use simple numerical IDs for plugins in groups
...
We'll be using a similar approach to identify threads for event
handlers.
2020-10-26 11:51:13 +01:00
Robbert van der Helm