e5cd777713
Fix the templated visitor in Vst3MessageHandler
...
Now it works as expected, since auto can't be initialized to multiple
different values.
2020-12-07 23:49:25 +01:00
d59a96b379
Move VST3 serializers to the structs
2020-12-07 22:33:41 +01:00
f1fe0fa8a4
Log a warning when encountering unknown interfaces
2020-12-07 22:21:01 +01:00
d79bc3b936
Don't use STL smart pointers with VST3 interfaces
...
This would cause double frees since those objects are supposed to clean
up after themselves.
2020-12-07 18:28:17 +01:00
75e8cf9140
Add notes on things that can potentially go wrong
2020-12-07 18:28:17 +01:00
547b11e8ba
Remove interface filtering from the plugin factory
...
This doesn't work that way, and CIDs really are class IDs (good thing
that everything's documented, oh right).
2020-12-07 18:28:17 +01:00
e20fc8c7e6
Fix Vst{2,3}Logger::log_trace
2020-12-07 18:28:17 +01:00
8ea40cd9f9
Rework Vst3MessageHandler::receive_messages
...
This now takes a regular overloaded function and the visiting is done in
`receive_messages()` itself. This way we can use templates to ensure
that the return type is correct. Otherwise auto will cause issues in the
future when we want to return multiple concrete types from a function
that takes a single variant. The alternative would be both receiving a
variant as a parameter and then returning another variant as a result,
but that is much less type safe.
2020-12-07 18:28:16 +01:00
c2503f8aaa
Send the factory from the Wine host to the plugin
2020-12-07 18:28:16 +01:00
79c6f02d91
Request and deserialize plugin factory from plugin
2020-12-07 18:28:16 +01:00
887a856e58
Rename Vst3MessageHandler::send_message overload
...
`receive_into()` looks much clearer in typical usage.
2020-12-07 18:28:16 +01:00
a16cf3015f
Fix deserializing into existing objects
...
`read_object()` was trying to create copies.
2020-12-07 18:28:16 +01:00
d5374e4540
💥 Rework Vst3MessageHandler
...
- Now allows direct deserialization into existing objects. This will be
necessary for our VST3 implementations since the interface instances
we'll deserialize into will not be trivially constructable because
they have to be able to do callbacks.
- `ControlResponse` and `CallbackResponse` were dropped. These response
enums are not necessary because of the `T::Response` associated type
and returning the types directly makes the direct deserialization
possible.
2020-12-07 18:28:16 +01:00
5423950a8a
Allow receiving VST3 messages into existing object
2020-12-07 18:28:16 +01:00
02dfe93ff0
Allow deserialization into an existing object
...
We're going to need this for VST3 because we're going to have to
explicitly instantiate our interface implementations since they need to
be able to perform complicated callbacks.
2020-12-07 18:28:16 +01:00
3be5836c07
Log and ignore unsupported interfaces
2020-12-07 18:28:16 +01:00
5f14958146
Implement IpluginFactory3::getClassInfoUnicode
2020-12-07 18:28:16 +01:00
ef3f82e00f
Implement IpluginFactory2::getClassInfo2
2020-12-07 18:28:16 +01:00
049eb257c5
Make YaPluginFactory abstract
...
And add separate implementations for the native plugin and the Wine
plugin host. This way we can easily allow the native host to do
callbacks without having to manage a load of lambdas.
2020-12-07 18:28:16 +01:00
1db3c0371f
Expand on the VST3 implementation readme
2020-12-07 18:28:16 +01:00
dd48523183
Implement IPluginFactory::getClassInfo
2020-12-07 18:28:16 +01:00
e6da03ae84
Implement IPluginFactory::countClasses()
2020-12-07 18:28:16 +01:00
79df8fecc2
Serialize the factory info
2020-12-07 18:28:16 +01:00
fa10600114
Add more thoughts on how the factory should work
2020-12-07 18:28:16 +01:00
82c1542b74
Add boilerplate for copying factory interfaces
2020-12-07 18:28:16 +01:00
8f152c7af5
Clean up the query interface serialization
2020-12-07 18:28:16 +01:00
42f3639e93
Add boilerplate for PluginFactory serialization
2020-12-07 18:28:16 +01:00
a77e2fbfae
Add Bitsery serialization for FUIDs
2020-12-07 18:28:16 +01:00
d87afa99e0
Add logging for the VST3 plugin
2020-12-07 18:28:16 +01:00
426231a22b
Avoid potential UB in loggers using composition
...
This cast would work fine, but any other fields added to those loggers
would be left uninitialized.
2020-12-07 18:28:16 +01:00
c1e7f53cd0
💥 Major refactor of initialization plumbing
...
To account for the differences in VST2 plugins and VST3 modules we had
to wrap most of our old functions from `src/plugin/utils.h` in a new
`PluginInfo` struct that gathers all of this information while taking
into account the differences between VST2 and VST3 plugins.
With this change things are also a lot more organized. We can just query
the plugin information we need rather than having to store things
separately or having to recalculate things. This also moved the
responsibility of all the weird `WINEPREFIX` behaviour to a single place
instead of having it spread around `utils.pp`, the initialisation
message, and `host-procoess.cpp`.
2020-12-07 18:28:16 +01:00
0819e9fda9
Request/send config for VST3 plugins
...
Using the new Vst3MessageHandler.
2020-12-07 18:28:16 +01:00
70405e8917
Encapsulate our VST3 message handling pattern
...
Similarly to how how we do it in `EventHandler`.
2020-12-07 18:28:16 +01:00
db1a51af5c
Add serialization primitives for VST3
2020-12-07 18:28:16 +01:00
e889ad22e2
Only pass Logger reference to AdHocSocketHandler
...
The boolean flag wasn't used, and it doesn't make any sense in the
context of VST3.
2020-12-07 18:28:16 +01:00
19eb33a7e2
Add a AdHocSocketHandler::receive_multi overload
...
With only a single callback.
2020-12-07 18:28:16 +01:00
ab7449a0e0
Add control sockets to Vst3Sockets
2020-12-07 18:28:16 +01:00
ff2807c939
Add all the boilerplate for the Vst3PluginBridge
...
And now that I also have an idea of what the communication model will
look like, this can server as a base for instantiating plugins.
2020-12-07 18:28:16 +01:00
6e5aa1c1c6
Add the Vst3Bridge boilerplate
2020-12-07 18:28:16 +01:00
f9a1bcd7bd
Split VST2 specific functionality into Vst2Logger
2020-12-07 18:28:16 +01:00
2230b5099f
Move logger to common/logging/common.h
2020-12-07 18:28:16 +01:00
e21d3e020f
Rename GroupRequest to HostRequest
...
We'll also use this to encode information in when launching
`yabridge-host.exe` for individually hosted plugins.
2020-12-07 18:28:16 +01:00
f9bb3822de
Pass plugin type when calling the host application
2020-12-07 18:28:16 +01:00
1142c908df
Add serialization support for PluginType
2020-12-07 18:28:16 +01:00
67388dc2a6
Add a plugin type tag and conversion functions
2020-12-07 18:28:16 +01:00
47baef3107
Rename architecture related functions and structs
2020-12-07 18:28:16 +01:00
7fc7a51a46
Move PluginArchitecture to common
...
Along with the accompanying function to parse a PE32 file. We're going
to have to define some common tags for different plugin types.
2020-12-07 18:28:16 +01:00
687696ec6b
Reimplement EventHandler on top of AdHocSocketHandler
2020-12-07 18:28:16 +01:00
5607a643e4
Add a generic ad hoc socket listener
...
This is a generalized version of EventHandler.
2020-12-07 18:28:16 +01:00
555b442f75
Add a todo regarding benchmarking ad hoc sockets
2020-12-07 18:28:16 +01:00
Robbert van der Helm