mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-07 03:50:11 +02:00
Get rid of some old todos
This commit is contained in:
@@ -236,7 +236,7 @@ Vst3PluginBridge::Vst3PluginBridge()
|
||||
plugin_factory->host_application->getName(name);
|
||||
}
|
||||
|
||||
// TODO: Remove this warning ocne Ardour supports multiple
|
||||
// TODO: Remove this warning once Ardour supports multiple
|
||||
// inputs and outputs
|
||||
if (result == Steinberg::kResultOk && name == u"Ardour"s) {
|
||||
logger.log(
|
||||
|
||||
@@ -366,8 +366,6 @@ void Vst3Bridge::run() {
|
||||
// pass that to the initialize function. The lifetime of this
|
||||
// object is tied to that of the actual plugin object we're
|
||||
// proxying for.
|
||||
// TODO: Does this have to be run from the UI thread? Figure out
|
||||
// if it does
|
||||
object_instances[request.instance_id].component_handler_proxy =
|
||||
Steinberg::owned(new Vst3ComponentHandlerProxyImpl(
|
||||
*this,
|
||||
@@ -614,11 +612,6 @@ void Vst3Bridge::run() {
|
||||
|
||||
// Just like with VST2 plugins, we'll embed a Wine window into
|
||||
// the X11 window provided by the host
|
||||
// TODO: The docs say that we should support XEmbed (and we're
|
||||
// purposely avoiding that because Wine's implementation
|
||||
// doesn't work correctly). Check if this causes issues,
|
||||
// and if it's actually needed (for instance when the host
|
||||
// resizes the window without informing the plugin)
|
||||
const auto x11_handle = static_cast<size_t>(request.parent);
|
||||
|
||||
// Creating the window and having the plugin embed in it should
|
||||
|
||||
Reference in New Issue
Block a user