From de8559caea90b3011c3a64d6db12d7b40bdda7bf Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Tue, 19 Jan 2021 15:20:22 +0100 Subject: [PATCH] Get rid of some old todos --- src/plugin/bridges/vst3.cpp | 2 +- src/wine-host/bridges/vst3.cpp | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/plugin/bridges/vst3.cpp b/src/plugin/bridges/vst3.cpp index 2d4fef01..67834146 100644 --- a/src/plugin/bridges/vst3.cpp +++ b/src/plugin/bridges/vst3.cpp @@ -236,7 +236,7 @@ Vst3PluginBridge::Vst3PluginBridge() plugin_factory->host_application->getName(name); } - // TODO: Remove this warning ocne Ardour supports multiple + // TODO: Remove this warning once Ardour supports multiple // inputs and outputs if (result == Steinberg::kResultOk && name == u"Ardour"s) { logger.log( diff --git a/src/wine-host/bridges/vst3.cpp b/src/wine-host/bridges/vst3.cpp index a73827da..b01a10e7 100644 --- a/src/wine-host/bridges/vst3.cpp +++ b/src/wine-host/bridges/vst3.cpp @@ -366,8 +366,6 @@ void Vst3Bridge::run() { // pass that to the initialize function. The lifetime of this // object is tied to that of the actual plugin object we're // proxying for. - // TODO: Does this have to be run from the UI thread? Figure out - // if it does object_instances[request.instance_id].component_handler_proxy = Steinberg::owned(new Vst3ComponentHandlerProxyImpl( *this, @@ -614,11 +612,6 @@ void Vst3Bridge::run() { // Just like with VST2 plugins, we'll embed a Wine window into // the X11 window provided by the host - // TODO: The docs say that we should support XEmbed (and we're - // purposely avoiding that because Wine's implementation - // doesn't work correctly). Check if this causes issues, - // and if it's actually needed (for instance when the host - // resizes the window without informing the plugin) const auto x11_handle = static_cast(request.parent); // Creating the window and having the plugin embed in it should