941f915dfe
Move the architecture section to docs/
...
It's getting a bit unwieldy to be left in the readme.
2020-05-27 15:24:54 +02:00
276e4ac02f
Make the local coordinate fix more robust
...
Without this fix and when using plugin groups, hovering over an opened
window that has not yet been interacted with shows some weird behavior.
2020-05-27 14:29:31 +02:00
5a0c3c4627
Simplify the opening editor behaviour again
...
This partially reverts 16fce5577d
2020-05-27 14:05:57 +02:00
d65281d691
Clarify local coordinate fix function name
2020-05-27 13:50:52 +02:00
ab4d35886e
Add a fix for the keyboard focus in Bitwig 3.2
2020-05-26 19:39:51 +02:00
be969a69d0
Document plugin groups
2020-05-26 19:39:51 +02:00
0c047f9a66
Work around a memory corruption issue on unload
...
I'm really not sure what is happening here, and it might just be a
winelib thing.
2020-05-26 17:09:09 +02:00
fc35b6c9c8
Show the init message before launching VST host
2020-05-26 17:07:14 +02:00
9b847fdc31
Add todo regarding offscreen window coordinates
2020-05-26 12:19:37 +02:00
198807a15a
Run events async and centralized for group hosts
...
At a 30 fps rate with a limit on the number of window messages per
frame. This is somehow needed for Melda plugins, as they otherwise
dispatch tiemr messages indefinitely after opening a second editor with
seemingly no way around it.
With this and some refactoring #15 should be almost done.
2020-05-26 12:13:37 +02:00
16fce5577d
Skip the message loop when an editor is opening
...
This is a bit more restrictive than the old approach that only skipped
when `effEditOpen()` got called after `effEditGetRect()`. Not sure why
the Melda plugins block indefinitely on the message loop without this
now.
2020-05-26 11:12:36 +02:00
9a35023990
Split X11 and Win32 event handling
...
X11 events should always be handled since it's thread safe and they
don't block.
2020-05-26 11:11:34 +02:00
064bb2684f
Init plugins and handle events on the main thread
...
Within the plugin IO context.
2020-05-25 15:19:46 +02:00
bbfe522343
Use a seperate thread for STDIO capture for groups
...
When running the plugins on the main thread the window message loop may
block for a while, which would cause the STDIO redirect to be
interrupted.
2020-05-25 15:15:32 +02:00
23f15c8d8a
Rename the two handle_dispatch functions
...
To better differentiate between their intended uses.
2020-05-25 15:10:19 +02:00
85fb3a2588
Conditionally disiable the message loop from
...
Based on a function. This is needed because the message loop should be
skipped while any of the plugins is opening their GUI, similar to how
`EditorOpening` worked for individually hosted plugins.
2020-05-25 15:04:43 +02:00
1c44a2f2cb
Also filter audioMasterGetCurrentProcessLevel
...
Some plugins call this every time they process audio.
2020-05-25 14:38:30 +02:00
2e68ade2a3
Allow handling events inside of an IO context
...
This is needed when using multiple plugins since their GUI operations
all have to be run from the same thread.
2020-05-25 14:38:30 +02:00
e546dd7b24
Change wording for individually hosted plugins
2020-05-23 16:00:44 +02:00
42c755cac8
Don't try to join nonexistent threads
...
This fixes a shutdown crash for individually hosted plugins. One more
reason to refactor the host launch behavior!
2020-05-23 15:59:04 +02:00
124b62bf6b
Change config path wording
...
Since this field will only be populated if we are actually using values
from a config file.
2020-05-23 15:47:13 +02:00
e61b70ed97
Add the new plugin groups to the changelog #15
...
With this the plugin groups functionality is feature complete, although
I still want to do a few rounds of refactoring and the readme has not
yet been updated.
2020-05-23 15:28:54 +02:00
c387238b78
Change wording in group related log messages
2020-05-23 15:16:33 +02:00
9c901935d4
Fix editor GUIs for plugin groups
...
Handles for things like timers should be unique on a per-thread basis in
the Win32 API, but apparently window classes have to be unique for the
entire application.
2020-05-23 15:09:56 +02:00
f50d04ce04
Defer group host shutdown
...
This allows for a significant speedup in plugin scanning time for plugin
groups, since starting Wine processes takes up pretty much the entirety
of the time spent scanning plugins.
2020-05-23 13:54:40 +02:00
9f544c194a
Change hosting mode wording
2020-05-23 13:01:22 +02:00
333c5dac17
Clean up GitHub workflow
2020-05-22 23:37:21 +02:00
a9841f21f5
Include the group host binaries in the artifacts
2020-05-22 23:34:06 +02:00
3a9d902c72
Allow all threads to return when sockets close
...
This was not a problem with individually hosted plugins because the
entire process got terminated at once, but here we all threads to shut
down gracefully when a plugin's sockets get closed. I wish this wouldn't
need all these try-catches, but we're not writing Haskell here.
The only issue remaining is that for some reason only the first
instance's editor works, at least for Serum. This might be because of
the message loop.
2020-05-22 23:22:49 +02:00
a246ddf344
Manually close sockets when not killing process
...
Killing the socket would otherwise cause the sockets to be closed, and
both sides to shut down.
2020-05-22 23:08:25 +02:00
6da1909d4b
Fix interleaved group host initialization
...
In case two yabridge instances start at the same time and both try to
launch a group host for the same group and the second plugin connects to
the first group host, then we should of course be using that process'es
PID to check if the group host is still running.
2020-05-22 22:50:29 +02:00
bea924c0e1
Make plugin initialization thread safe
2020-05-22 22:42:24 +02:00
b4b471523f
Fix assertion in group host connection handler
2020-05-22 20:15:53 +02:00
ad6199949d
Fix startup errors not being logged
2020-05-22 20:15:53 +02:00
c5c1c334d9
Add group host support to the plugin
...
The difference between individual hosting and group hosting will have to
be encapsulated in a class to keep the rest of the plugin bridge clean.
2020-05-22 20:15:53 +02:00
903d977d83
Add a function for generating group host endpoints
2020-05-22 19:06:43 +02:00
9fb7f1fc03
Add handling for stale and active group sockets
2020-05-22 19:06:43 +02:00
5b4b62d7c4
Use pid_t instead of ints for PIDs
2020-05-22 19:06:43 +02:00
615d23e525
Clean up new host process launching
2020-05-22 19:06:43 +02:00
9b50bac179
Reply with the group process's PID after a request
2020-05-22 19:06:43 +02:00
dd843519ce
Rename PluginParameters to GroupReuqest
2020-05-22 19:06:43 +02:00
27af0f8c11
Search for the group host when using plugin groups
2020-05-22 19:06:43 +02:00
fea256655d
Move process launching to a function
...
Starting and connecting to plugin group host processes is not going to
work in the intializer list.
2020-05-22 19:06:43 +02:00
91b0ebf38b
Remove mention of plugin groups flag
...
Since there's no reason for this to be behind a flag.
2020-05-21 17:15:24 +02:00
8c22f37f29
Actually host plugins in the group process
2020-05-21 17:12:55 +02:00
17cff5722e
Lock the active plugins map early
...
To prevent a race condition when an exiting plugin wants to terminate
the process when it think there are no plugins left just as another
yabridge instance is connecting to the group socket.
2020-05-21 17:12:41 +02:00
8eb01cb519
Listen on the group socket and handle requests
2020-05-20 18:45:33 +02:00
6d6d928838
Move all plugin group handling boilerplate
2020-05-19 15:29:48 +02:00
daad6f2f00
Fix empty line spam in log file when Wine crashes
2020-05-19 12:27:32 +02:00
c2fceb6e4a
Add a thread safety warning to write_object()
2020-05-19 11:33:34 +02:00
Robbert van der Helm