Commit Graph

266 Commits

Author SHA1 Message Date
Robbert van der Helm 4b1435c238 Remove todo on crashes while browsing presets
Can't replicate it anymore.
2020-04-27 18:55:11 +02:00
Robbert van der Helm 4b84f663ab Always run the event loop, fixing processing issue
Also remove any special `effEditIdle` handling.

Apparently plugins rely on the message loop for their internal tasks,
even for things that have nothing to do with GUIs, such as deferring
initialization.
2020-04-27 18:53:06 +02:00
Robbert van der Helm e69d08c503 Add assertion for bytes written while sending
To avoid problems like 13dcb2f74a in the
future.
2020-04-27 18:00:01 +02:00
Robbert van der Helm ae7c1e487a Update the todo on plugins not processing audio 2020-04-27 17:54:00 +02:00
Robbert van der Helm cdc1d94df8 Remove now redundant todo 2020-04-27 17:07:54 +02:00
Robbert van der Helm af18b6dbd0 Reword the issue with KiloHearts plugins 2020-04-27 17:02:43 +02:00
Robbert van der Helm 7f0a8c8efd Extend the midi event lock
This should not make any difference, but if this event ever gets called
at the same time as the processing then this at least won't cause any
issues with plugins that are not thread safe themselves.
2020-04-27 16:53:44 +02:00
Robbert van der Helm f0d16c4afb Add note on potentially misbehaving type detection 2020-04-27 16:42:04 +02:00
Robbert van der Helm 13dcb2f74a Fix handling of large chunk data 2020-04-27 16:41:55 +02:00
Robbert van der Helm 527db1f49f Use different types for strings and binary data 2020-04-27 00:51:36 +02:00
Robbert van der Helm bdd83de7a9 Strip the 'yabridge-' prefix from log messages 2020-04-27 00:50:28 +02:00
Robbert van der Helm af6ae2c2ad Fix capitalization of the word MIDI 2020-04-26 18:19:10 +02:00
Robbert van der Helm 85afd4107e Extend the lifetime of MIDI events, fixing Kontakt 2020-04-26 18:17:30 +02:00
Robbert van der Helm aeac8e87fa Implement effGetParameterProperties 2020-04-26 16:53:34 +02:00
Robbert van der Helm aee890fbf6 Remove the now unused ability to skip opcodes
If this is needed again in the future (it shouldn't be), then it should
be re-implemented using a separate function.
2020-04-26 16:30:11 +02:00
Robbert van der Helm 0ce9c1e3a4 Add another less verbose debug level 2020-04-26 15:42:01 +02:00
Robbert van der Helm fedf5375e8 Mention that Wine 5.7 is broken 2020-04-26 15:09:46 +02:00
Robbert van der Helm b17c413de4 Add the generated version header to the file list
Otherwise it may not be generated yet on first build.
2020-04-26 14:29:08 +02:00
Robbert van der Helm b5743113bf Bump the version of Wine this has been tested with 2020-04-26 14:19:12 +02:00
Robbert van der Helm 3215f9337e Mention a file descriptor leak 2020-04-25 19:03:30 +02:00
Robbert van der Helm 9db425932b Add another bug to the list 2020-04-25 17:57:50 +02:00
Robbert van der Helm dfe2c1b045 Add a list of bugs that should be fixed 2020-04-25 17:52:56 +02:00
Robbert van der Helm 5ce20be9d9 Allow storing and loading of larger chunks 2020-04-25 17:35:02 +02:00
Robbert van der Helm 8bb1bdeadb Change the default return value for effClose 2020-04-25 17:02:41 +02:00
Robbert van der Helm 631e82f2ad Print the version and any VCS info at startup 2020-04-25 16:14:22 +02:00
Robbert van der Helm 4a1133146a Generate a header containing git version info
It contains the last annotated tag, and possibly also the number of
commits since then and the hash of the last commit.
2020-04-25 16:14:14 +02:00
Robbert van der Helm 1622c39f48 Move the section on VST extension features 2020-04-24 15:48:36 +02:00
Robbert van der Helm 0efdd1a790 Add missing license headers 2020-04-24 15:41:18 +02:00
Robbert van der Helm d0c8d8a2e7 Clean up Win32 thread API usage using RAII 2020-04-24 15:40:44 +02:00
Robbert van der Helm 542202b8ca Update the known issues section of the readme 2020-04-24 01:14:50 +02:00
Robbert van der Helm 9dfa83df20 Change todo regarding drag-and-drop 2020-04-23 23:16:31 +02:00
Robbert van der Helm 060712ee4d Remote the WS_EX_ACCEPTFILES
It doesn't matter, but we shouldn't be the window accepting drag and
drop operations.
2020-04-23 23:13:55 +02:00
Robbert van der Helm a8c1657120 Add a list of hosts yabridge has been tested under 2020-04-22 17:26:32 +02:00
Robbert van der Helm 259d23ec57 Add support for legacy plugins with only process()
By emulating the behavior of `processReplacing()`. Not that there should
still be any plugins around that don't support processReplacing.
2020-04-22 16:57:18 +02:00
Robbert van der Helm 2e36c64796 Return a 0 for skipped events
Not that any events get skipped at the moment.
2020-04-21 18:13:22 +02:00
Robbert van der Helm 27ca18869b Change variable names for consistency 2020-04-21 17:02:28 +02:00
Robbert van der Helm d2bf5c35a4 Fix hanging when closing the editor 2020-04-21 16:56:36 +02:00
Robbert van der Helm 8bedcbb997 Reformat example installation oneliner in readme 2020-04-21 15:34:01 +02:00
Robbert van der Helm bcbf8684df Update the introduction in the readme 2020-04-20 23:53:19 +02:00
Robbert van der Helm 421ed21901 Get rid of now no longer needed synchronisation
This was mostly a workaround to get Serum to not crash when audio was
being processed during a specific point of its `WM_PAINT` message
handler. This is no longer needed when using `CreateThread` instead of
`std::thread`.
2020-04-20 23:36:17 +02:00
Robbert van der Helm 86974ebe2d Fix typo 2020-04-20 23:25:01 +02:00
Robbert van der Helm 357dec315a Swap out std::thread for CreateThread
Not entirely sure why, but this gets rid of the impossible to debug data
races when Serum's GUI is being repainted while another thread is
calling `processReplacing`. This is possibly because std::thread does
not respect Windows calling conventions and CreateThread does.
2020-04-20 23:24:39 +02:00
Robbert van der Helm 1a6a094c2b Fix reopening closed editor windows 2020-04-19 20:36:39 +02:00
Robbert van der Helm f29a859713 Don't put socket endpoints in a directory
This would only leave an empty directory behind.
2020-04-19 17:05:50 +02:00
Robbert van der Helm ed3b319f4f Clean up socket endpoint files 2020-04-19 17:00:17 +02:00
Robbert van der Helm b44d98b4c7 Mention more Wine debugging strategies 2020-04-19 16:38:09 +02:00
Robbert van der Helm 1f56617abe Remove more old todos 2020-04-19 16:17:18 +02:00
Robbert van der Helm b13d7d554d Prevent rare race conditions with get/setParameter
I've never seen it happen, but in theory they could be called
simultaneously.
2020-04-19 16:14:22 +02:00
Robbert van der Helm 9f3ed85208 Replace std::monostate with std::nullptr_t
This represents the underlying meaning better since we're mostly dealing
with the `data` void pointer argument.
2020-04-19 16:05:37 +02:00
Robbert van der Helm 717ffb719d Remove resolved todo 2020-04-19 16:05:37 +02:00