5f7fb2e2c3
Work around thread safety issue in Melda plugins
...
This is super difficult to trigger on purpose, but I did run into it at
least once just now so it seems like a good idea to at least make sure
that this doesn't happen.
2021-07-15 15:45:15 +02:00
6b3f593bdb
Mention Renoise's VST3 editor window sizing issues
2021-07-15 15:07:08 +02:00
f02341e77f
Fix focus handling when reopening REAPER FX window
...
REAPER initializes the plugin's editor first before reparenting the
parent window to the FX window, so our `topmost_window` didn't actually
refer to the FX window.
2021-07-15 14:21:50 +02:00
ce1cf41f45
Mention downgrading to Wine Staging 6.4 once more
...
The iZotope Rx plugins apparently freeze during shutdown on Wine Staging
6.12.
2021-07-15 12:21:52 +02:00
e26c300d81
Update the tested DAW versions
2021-07-15 11:52:02 +02:00
0250d62173
Reword changelog, again
2021-07-14 19:37:16 +02:00
0c816b0046
Only ignore -Wmaybe-uninitialized on GCC
...
An ifdef sounds like a better approach than ignoring two additional
warnings.
2021-07-14 17:18:44 +02:00
f292158889
Silence some more clangd warnings
2021-07-14 17:11:27 +02:00
a58005252a
Mention the new audio buffers in architecture.md
2021-07-14 17:02:20 +02:00
8b870a51b0
Remove unnecessary XDND proxy call
...
This was left over from the original implementation, before we had this
smart pointer-singleton hybrid thing. There's already a handle stored
inside of `Editor`.
2021-07-14 16:41:24 +02:00
764eb41da9
Remove fixme about Wine deleting windows twice
...
This should have been fixed as of yabridge 3.2.0 by adding doing a
reparent with a last second flush. Or at least, I haven't heard any
reports about this still being an issue.
2021-07-14 16:35:51 +02:00
784593df5c
[yabridgectl] Remove explicit fallback
...
This was already handled by appending this to the `$PATH`.
2021-07-14 15:10:03 +02:00
9b70d4b6d6
Reword changelog
2021-07-14 12:38:03 +02:00
591b2b9ceb
Also warn on version mismatch for VST2 plugins
2021-07-13 22:24:02 +02:00
5fc7acccd1
Show a notification on version mismatch
...
Between the plugin and the Wine plugin host application.
2021-07-13 22:14:31 +02:00
4013aea63a
Include the configuration as a dependency
...
Apparently this wasn't even supposed to work, so it's probably a good
idea to do it properly before things break.
2021-07-13 22:05:11 +02:00
3dfb17cf5e
Add suggestion to rerun sync after startup failure
2021-07-13 22:05:11 +02:00
a2b877b101
Put more emphasis on how to run files from a shell
2021-07-13 14:46:44 +02:00
2c25615ea5
Restore old yabridgectl plugin count with symlinks
...
The count will probably be a bit off now, but it's better than counting
only two plugins.
2021-07-13 00:01:32 +02:00
d8215e4664
Allow cancelling the drag-and-drop with Escape
2021-07-12 22:58:24 +02:00
2ebefb1280
Send an escape key press instead of WM_QUIT
...
This should allow the drag-and-drop operation to quit gracefully.
2021-07-12 21:36:08 +02:00
bbb84cdf2c
Remove spurious drag-and-drop tracker WM_QUIT
...
We don't want to cancel the plugin's own drag-and-drop, oops.
2021-07-12 21:17:12 +02:00
b4019213f6
[yabridgectl] Remove 32-bit prefix warning on sync
...
This is no longer an issue since yabridgectl checks the prefixes
architecture now.
2021-07-12 15:46:35 +02:00
96fb53be8f
Fix the CAS in the XDND check
...
Oops. We were doing the opposite of what we wanted, which caused the
first drag to always fail.
2021-07-12 14:00:48 +02:00
ad4fb1a0ec
Don't define X11 error throwing macro in DND proxy
...
We didn't need this after all because we don't integrate with the
editor's X11 event loop.
2021-07-12 13:35:10 +02:00
2f8bb7ef06
Only allow a single XDND operation at a time
...
MT-PowerDrumkit apparently cancels its drag-and-drop operations and then
immediately starts a new one.
2021-07-12 12:35:07 +02:00
a478436af6
Make sure the Windows dnd operation terminates
...
I've seen a weird edge case where this doesn't happen once, but i
haven't been able to reproduce it. Hopefully this fixes it.
2021-07-12 12:21:52 +02:00
11d3ec9010
Also change cursor with the last status message
...
The idea was that you wouldn't be able to see it anyways, but it feels
better this way.
2021-07-11 21:40:42 +02:00
4d74963e0a
Flush any spooled XDND messages
...
The last position change message would never reach REAPER under when
using certain plugins because we forgot the flush.
2021-07-11 21:35:39 +02:00
4c7ffd5a3a
Fix emphasis in changelog
2021-07-11 20:32:06 +02:00
1b4c4ecfad
Remove old warning
2021-07-11 19:43:53 +02:00
c968a357f6
Fall back to HDROP with empty format enumerator
...
This happens with MeldaProduction plugins.
2021-07-11 19:29:15 +02:00
b1b47ec80d
Allow dragging to the right and bottom of plugins
2021-07-11 18:48:32 +02:00
ca5a7b2b96
Continue polling while LMB is held
...
Instead of while the tracker window is alive. Technically the plugin may
clean up their files after the tracker window is gone, but in practice I
haven't seen it happen.
2021-07-11 18:34:26 +02:00
1c84c4a02a
Mention Wine->X11 drag-and-drop in the changelog
2021-07-11 17:40:06 +02:00
d21073f866
Escape spaces in URI encoding
2021-07-11 17:24:53 +02:00
312debc447
URL encode paths in XDND text/uri-list
...
This should fix drag-and-drop in Bitwig.
2021-07-11 17:21:35 +02:00
d7dc0529a8
URL encode paths in desktop notifications
2021-07-11 17:19:48 +02:00
83951200bb
Add a function for URL encoding file paths
2021-07-11 17:19:45 +02:00
64fbabd8ce
Canonicalize paths during drag-and-drop
...
Otherwise we will get a path from somewhere in `$WINEPREFIX/dosdevices`.
2021-07-11 17:03:53 +02:00
bfaac67cbc
End every URI with a line feed
...
Bitwig requires this.
2021-07-11 16:53:38 +02:00
8d94abb257
Only send the drop once
...
Oops.
2021-07-11 16:30:28 +02:00
a12215de3c
Fix URI list length
...
Apparently you're _not_ supposed to count the trailing lien feed. This
would cause REAPER to freeze.
2021-07-11 16:30:21 +02:00
8e29b5edf3
Make sure the drop actually goes through
...
The whole dropping code was nested in the wrong loop (oops), and we also
forgot to send any last spooled messages. We now also use a pair of
booleans instead of an optional boolean here because it makes the
conditionals a bit more readable.
2021-07-11 15:55:34 +02:00
f6d661cd35
Fix the timeout
2021-07-11 15:28:14 +02:00
7bac138240
Spool XdndPosition messages
...
In accordance to the spec.
2021-07-11 15:28:01 +02:00
0e0b120eda
Perform the actual drop after releasing the button
2021-07-11 15:13:32 +02:00
8fc1097f84
Change cursor depending on XdndStatus
2021-07-11 14:32:48 +02:00
4e67fa9212
Fetch atoms for the remaining two XDND messages
...
We're going to need these anyways.
2021-07-11 14:14:02 +02:00
7b5810ae57
Listen for XdndStatus
2021-07-11 14:12:35 +02:00
Robbert van der Helm