0c7dbe8a4a
Reparent to the root window before deferring close
...
We did this before implementing the deferred close in yabridge 3.0.0. It
didn't seem necessary anymore so we got rid of it, but without this
closing an iZotope Rx plugin's editor in Renoise was guaranteed to
trigger an X11 error and crash Renoise. Doing this reparent doesn't seem
to cause any slowdown but it does at least fix the specific combination
of iZotope Rx and Renoise.
2021-04-26 18:47:58 +02:00
0d53f03b28
Get rid of an incorrect comment
...
This probably ended up here during a refactor.
2021-04-26 18:32:50 +02:00
f6cf1a7dd2
Use explicit narrowing for SetWindowLongPtr()
2021-04-26 18:32:50 +02:00
661ea5f573
Update the tested REAPER version
2021-04-26 15:27:45 +02:00
10b4c0929d
Mention corefonts in the runtime dependencies
2021-04-26 15:07:40 +02:00
75892794f8
Add a suggestion for disabling Serum's tooltips
...
These won't disappear once they're shown. I though that I'd already
listed this somewhere, but apparently not.
2021-04-26 13:48:08 +02:00
a42ee0400f
Print warning explicit COM init was necessary
...
So far only PSPaudioware InfiniStrip needed this. but it may be a good
idea to make this visible since it's probably an issue with the
plugin (even if most Windows hosts will have COM initialized).
2021-04-26 00:42:17 +02:00
68c846324c
Also explicitly list simple dispatcher opcodes
2021-04-25 23:07:24 +02:00
3e71fc19b8
Explicitly handle VST2 callbacks with nullptrs
...
This is probably not needed, but we'll do it just in case another plugin
does something similar.
2021-04-25 22:44:15 +02:00
86bd19cd80
Fix loading plugins expecting COM to be available
...
The `LoadLibrary()` call for PSPaudioware InfiniStrip would fail because
the plugin would always expect COM to be initialized. Now if loading a
VST2 or VST3 module fails, we'll initialize COM and try again before
throwing an error. This may fix #94 .
2021-04-25 21:54:34 +02:00
d55f07e962
Fix a small typo
2021-04-25 21:46:55 +02:00
671c6a4c18
Specifically not read data for audioMasterWantMidi
...
Plugsound Free by UVI will pass random garbage to the data parameter for
this function call for whatever reason, and we'll run into a memory
error if we try to read it. Mentioned in #93 .
2021-04-24 20:28:58 +02:00
0d1cb0bd77
Move special effVendorSpecific handling for REAPER
...
It's a bit less hacky if we do the effVendorSpecific check where we're
supposed to be checking for those things.
2021-04-24 20:23:23 +02:00
dae0fcab9f
Add the audio server/driver to the issue template
...
To make it easier to see if PipeWire's the thing causing issues.
2021-04-24 19:51:59 +02:00
afefb725b5
Postpone clearing old MIDI events until next event
...
This fixes Native Instrument's FM7 crashing on MIDI input. The plugin
expects the last received MIDI event to always be alive during audio
processing, even if there have not been any new events in this
processing cycle.
2021-04-23 01:08:21 +02:00
3f427cfa5a
Move known issues section up in the readme
...
Very few people will read the entire readme, so it would make sense to
place the more important sections earlier in the readme.
2021-04-22 14:56:13 +02:00
e8c1eb74b3
Mention Sforzando's drawing issues in known issues
2021-04-21 01:32:24 +02:00
2b1c2c77f8
Reword the Spitfire known issues entry
2021-04-21 01:27:03 +02:00
b35801ffbe
Change the emphasis for important readme sections
...
This looks a bit less in your face than a giant yellow star.
2021-04-20 11:33:42 +02:00
b82d2c0464
Mark the most important sections of the readme
...
This thing has become quite lengthy so if you're only going to read part
of it, then read this!
2021-04-20 11:30:13 +02:00
f97bacc626
Mention that PipeWire (or rtkit) may cause crashes
2021-04-19 17:14:54 +02:00
b04c0b2c65
Update links to the VST3 documentation
...
Those were broken after Steinberg restructured the docs with the VST
3.7.2 SDK release.
2021-04-18 14:24:03 +02:00
dd552dc8d7
Print the Wine version at Meson configure time
2021-04-18 14:06:33 +02:00
80f649323a
Add missing const qualification
...
I just noticed this while looking at the diff of this commit.
2021-04-16 14:12:48 +02:00
ba6b87c790
Bump to version 3.1.0
2021-04-15 12:38:11 +02:00
25afd43fe7
Update the readme for yabridge 3.1.0
2021-04-15 12:36:22 +02:00
2c391c97a5
[yabridgectl] Briefly mention blacklist in readme
...
A normal workflow doesn't require using the blacklist, so it's best to
not put too much emphasis on it.
2021-04-15 12:18:45 +02:00
aa00779752
Fix wording in changelog
2021-04-15 12:14:54 +02:00
4eb0490fde
Update the tested REAPER version
2021-04-14 21:50:29 +02:00
e0094979bf
Also run {get,set}State() for VST3 on GUI thread
...
This fixes the same issue with the VST3 version of Algonaut Atlas as the
last commit did for the VST2 version.
2021-04-14 21:38:15 +02:00
d97e699db1
Run effSetChunk and effGetChunk from main thread
2021-04-14 21:38:15 +02:00
6ba2fbe98d
[yabridgectl] Mention blacklist in the changelog
2021-04-14 19:30:49 +02:00
6765abb6e5
[yabridgectl] Add a way to clear entire blacklist
2021-04-14 19:25:07 +02:00
7ff4bb1585
[yabridgectl] Add commands for managing blacklist
...
Relevant for #88 .
2021-04-14 19:23:04 +02:00
4c1f7574c9
[yabridgectl] Mark yabridgectl set as advanced
...
You shouldn't need this in normal usage.
2021-04-14 18:40:22 +02:00
ef23522cd6
[yabridgectl] Change the display order
...
I forgot they're sorted lexicographically by default, instead of being
in declaration order.
2021-04-14 18:39:24 +02:00
f02b9e646b
[yabridgeclt] Upgrade dependencies
2021-04-14 18:35:52 +02:00
1d66481aad
[yabridgectl] Add a blacklist #88
...
This lets you skip single plugins and entire directories during the
indexing process.
2021-04-14 17:51:43 +02:00
6746b2b924
Add missing <optional> include for GCC 11
2021-04-14 17:09:43 +02:00
4937010557
Fix some of the clang-tidy lints
2021-04-14 16:09:54 +02:00
8942727661
Add a clang-tidy config
2021-04-14 15:53:28 +02:00
a297866d45
Add way to use 32-bit VST3 when both are installed
...
Otherwise we would always use the 64-bit version and there would be no
way to use the 32-bit version, if version for some reason works better.
Relates to #80 .
2021-04-13 19:28:36 +02:00
f177b69aae
Re-enable loading 32-bit VST3 plugins #80
2021-04-12 22:38:36 +02:00
b1eaaa0638
Fix ABI compatibility with 32-bit VST3 plugins #80
...
This would cause 32-bit VST3 plugins to crash in mysterious ways. What
ended up being the issue is that the plugins expected doubles to be
8-byte aligned in structs, while GCC doesn't do that by default in x86
code for legacy ABI compatibility reasons. Figuring out what exactly was
the issue took months, but luckily the fix was to just add an
`-malign-double`!
2021-04-12 22:35:09 +02:00
da5c9c2965
Update wording in changelog
2021-04-12 22:01:44 +02:00
42096c6f60
Add a workaround for Bluecat Audio VST3 plugins
...
These plugins don't expose `IPluginBase` through the query interface, so
we have to do this nasty coercion instead.
2021-04-12 14:45:12 +02:00
5278c2e2ea
Print all errors on the Wine side to STDERR
...
This one was using STDOUT for some reason
2021-04-12 14:19:31 +02:00
266d22b051
Update notice about Wine 6.5 to also mention 6.6
2021-04-10 14:46:50 +02:00
1207c8811d
Update the tested Qtractor version
...
Everything seems to work great now on Qtractor 0.9.21!
2021-04-09 15:04:52 +02:00
5dbc3bd2b9
Clarify the VST3 status of Ardour and Mixbus
...
Plugins are probably going to handle not having all of their outputs
correctly, so it's unlikely that they'll cause the DAW to crash.
2021-04-09 14:37:57 +02:00
Robbert van der Helm