vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-08 20:40:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move special effVendorSpecific handling for REAPER

Browse Source 
It's a bit less hacky if we do the effVendorSpecific check where we're
supposed to be checking for those things.
This commit is contained in:
Robbert van der Helm
2021-04-24 20:23:23 +02:00
parent dae0fcab9f
commit 0d1cb0bd77
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/communication/vst2.cpp
+2 -8
View File
@@ -16,16 +16,10 @@
#include "vst2.h"
EventPayload DefaultDataConverter::read(const int opcode,
const int index,
EventPayload DefaultDataConverter::read(const int /*opcode*/,
const int /*index*/,
const intptr_t /*value*/,
const void* data) const {
// HACK: REAPER has recently started using `effVendorSpecific` with a
// non-pointer `data` argument, so we need to explicitly handle this
if (opcode == effVendorSpecific && index == effSetSpeakerArrangement) {
return static_cast<native_size_t>(reinterpret_cast<size_t>(data));
}
if (!data) {
return nullptr;
}
src/plugin/bridges/vst2.cpp
+12
View File
@@ -196,6 +196,18 @@ class DispatchDataConverter : DefaultDataConverter {
// data (or at least Bitwig does this)
return *static_cast<const VstIOProperties*>(data);
break;
// HACK: REAPER has recently started using `effVendorSpecific` with
// a non-pointer `data` argument, so we need to explicitly
// handle this
case effVendorSpecific:
if (index == effSetSpeakerArrangement) {
return static_cast<native_size_t>(
reinterpret_cast<size_t>(data));
} else {
return DefaultDataConverter::read(opcode, index, value,
data);
}
break;
case effGetParameterProperties:
return *static_cast<const VstParameterProperties*>(data);
break;