vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Relax IBStream reading even further

Browse Source 
And reset the seek position after reading. This new approach where we
also read from empty IBStreams to provide a perfect proxy would
otherwise cause plugins to crash in Bitwig when either loading or saving
state.
This commit is contained in:
Robbert van der Helm
2021-01-10 17:41:55 +01:00
parent 4fdd50d1a3
commit d632d5643d
1 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3/bstream.cpp
+13 -14
View File
@@ -57,23 +57,22 @@ YaBStream::YaBStream(Steinberg::IBStream* stream) {
// Copy any existing contents, used for `IComponent::setState` and similar
// methods
int64 old_position;
stream->tell(&old_position);
if (stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekEnd) ==
Steinberg::kResultOk) {
// Now that we're at the end of the stream we know how large the buffer
// should be
int64 size;
assert(stream->tell(&size) == Steinberg::kResultOk);
int32 num_bytes_read = 0;
buffer.resize(size);
assert(
stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet) ==
Steinberg::kResultOk);
// Reading zero bytes will return `kResultFalse` in some implementations
stream->read(buffer.data(), size, &num_bytes_read);
assert(num_bytes_read == 0 || num_bytes_read == size);
int64 size = 0;
stream->tell(&size);
if (size > 0) {
int32 num_bytes_read = 0;
buffer.resize(size);
stream->seek(0, Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);
stream->read(buffer.data(), size, &num_bytes_read);
assert(num_bytes_read == 0 || num_bytes_read == size);
}
}
stream->seek(old_position,
Steinberg::IBStream::IStreamSeekMode::kIBSeekSet);
// Starting at VST 3.6.0 streams provided by the host may contain context
// based meta data