85fb3a2588
Conditionally disiable the message loop from
...
Based on a function. This is needed because the message loop should be
skipped while any of the plugins is opening their GUI, similar to how
`EditorOpening` worked for individually hosted plugins.
2020-05-25 15:04:43 +02:00
1c44a2f2cb
Also filter audioMasterGetCurrentProcessLevel
...
Some plugins call this every time they process audio.
2020-05-25 14:38:30 +02:00
2e68ade2a3
Allow handling events inside of an IO context
...
This is needed when using multiple plugins since their GUI operations
all have to be run from the same thread.
2020-05-25 14:38:30 +02:00
e546dd7b24
Change wording for individually hosted plugins
2020-05-23 16:00:44 +02:00
42c755cac8
Don't try to join nonexistent threads
...
This fixes a shutdown crash for individually hosted plugins. One more
reason to refactor the host launch behavior!
2020-05-23 15:59:04 +02:00
124b62bf6b
Change config path wording
...
Since this field will only be populated if we are actually using values
from a config file.
2020-05-23 15:47:13 +02:00
c387238b78
Change wording in group related log messages
2020-05-23 15:16:33 +02:00
9c901935d4
Fix editor GUIs for plugin groups
...
Handles for things like timers should be unique on a per-thread basis in
the Win32 API, but apparently window classes have to be unique for the
entire application.
2020-05-23 15:09:56 +02:00
f50d04ce04
Defer group host shutdown
...
This allows for a significant speedup in plugin scanning time for plugin
groups, since starting Wine processes takes up pretty much the entirety
of the time spent scanning plugins.
2020-05-23 13:54:40 +02:00
9f544c194a
Change hosting mode wording
2020-05-23 13:01:22 +02:00
3a9d902c72
Allow all threads to return when sockets close
...
This was not a problem with individually hosted plugins because the
entire process got terminated at once, but here we all threads to shut
down gracefully when a plugin's sockets get closed. I wish this wouldn't
need all these try-catches, but we're not writing Haskell here.
The only issue remaining is that for some reason only the first
instance's editor works, at least for Serum. This might be because of
the message loop.
2020-05-22 23:22:49 +02:00
a246ddf344
Manually close sockets when not killing process
...
Killing the socket would otherwise cause the sockets to be closed, and
both sides to shut down.
2020-05-22 23:08:25 +02:00
6da1909d4b
Fix interleaved group host initialization
...
In case two yabridge instances start at the same time and both try to
launch a group host for the same group and the second plugin connects to
the first group host, then we should of course be using that process'es
PID to check if the group host is still running.
2020-05-22 22:50:29 +02:00
bea924c0e1
Make plugin initialization thread safe
2020-05-22 22:42:24 +02:00
b4b471523f
Fix assertion in group host connection handler
2020-05-22 20:15:53 +02:00
ad6199949d
Fix startup errors not being logged
2020-05-22 20:15:53 +02:00
c5c1c334d9
Add group host support to the plugin
...
The difference between individual hosting and group hosting will have to
be encapsulated in a class to keep the rest of the plugin bridge clean.
2020-05-22 20:15:53 +02:00
903d977d83
Add a function for generating group host endpoints
2020-05-22 19:06:43 +02:00
9fb7f1fc03
Add handling for stale and active group sockets
2020-05-22 19:06:43 +02:00
5b4b62d7c4
Use pid_t instead of ints for PIDs
2020-05-22 19:06:43 +02:00
615d23e525
Clean up new host process launching
2020-05-22 19:06:43 +02:00
9b50bac179
Reply with the group process's PID after a request
2020-05-22 19:06:43 +02:00
dd843519ce
Rename PluginParameters to GroupReuqest
2020-05-22 19:06:43 +02:00
27af0f8c11
Search for the group host when using plugin groups
2020-05-22 19:06:43 +02:00
fea256655d
Move process launching to a function
...
Starting and connecting to plugin group host processes is not going to
work in the intializer list.
2020-05-22 19:06:43 +02:00
91b0ebf38b
Remove mention of plugin groups flag
...
Since there's no reason for this to be behind a flag.
2020-05-21 17:15:24 +02:00
8c22f37f29
Actually host plugins in the group process
2020-05-21 17:12:55 +02:00
17cff5722e
Lock the active plugins map early
...
To prevent a race condition when an exiting plugin wants to terminate
the process when it think there are no plugins left just as another
yabridge instance is connecting to the group socket.
2020-05-21 17:12:41 +02:00
8eb01cb519
Listen on the group socket and handle requests
2020-05-20 18:45:33 +02:00
6d6d928838
Move all plugin group handling boilerplate
2020-05-19 15:29:48 +02:00
daad6f2f00
Fix empty line spam in log file when Wine crashes
2020-05-19 12:27:32 +02:00
c2fceb6e4a
Add a thread safety warning to write_object()
2020-05-19 11:33:34 +02:00
8bd1dc8c50
Encapsulate the STDOUT/STDERR capturing
2020-05-18 16:15:07 +02:00
53acb1f78a
Move wine-bridge.h -> bridges/vst2.h
...
This way we can structure the group handling and a potential future VST3
bridge in the same way.
2020-05-18 16:15:07 +02:00
b8028b8e13
Remap STDOUT and STDERR in group process to log
...
This is not very pretty, but there's not really another way and I"m
surprised that it actually works.
2020-05-18 16:15:07 +02:00
0ad849a42f
Fall back to /dev/stderr instead of std::cerr
...
This allows us to remap STDIO internally in the group process.
2020-05-18 16:15:07 +02:00
2f39650322
Remove last traces of Boost.Filesystem from host
...
Missed this in e728dbe5a2
2020-05-18 16:15:07 +02:00
994f3c9e38
Add a plugin group host application
2020-05-18 16:15:07 +02:00
95e716d229
Rename vst-host.cpp -> individual-host.cpp
2020-05-17 14:43:21 +02:00
a849927a08
Move initialization message to a function
...
It was starting to get a bit unwieldy.
2020-05-17 14:43:21 +02:00
d2cd608abb
Print the configuration on startup
2020-05-17 14:43:21 +02:00
312200f100
Make the 'this_line_location' hack more reliable
...
It shouldn't be done if it's not needed.
2020-05-17 14:43:21 +02:00
e76d4b474c
Rearrange fields in PluginBridge
2020-05-16 14:46:48 +02:00
a615a66cc5
Add the group configuration parser
...
As described in #15 .
2020-05-15 16:35:18 +02:00
f96c08775a
Use Boost.Filesystem for the configuration
...
I'd much rather just use std::filesystem, but since all of
Boost.Process, Boost.DLL Boost.Asio uses its own filesystem library we
need to use it anyways.
2020-05-15 16:35:18 +02:00
d9ff98de84
Move everything configuration related to plugin
...
If it's tied to the .so file rather than the .dll file it wouldn't make
any sense to use it directly from the Wine host.
2020-05-15 16:35:18 +02:00
9a82e82c87
Factor out directory finding from prefix detection
...
This will also be used to locate the `yabridge.tmol` configuration file.
2020-05-15 16:35:18 +02:00
37a74c8f98
Get rid of the dedicated AEffect socket
2020-05-13 13:15:52 +02:00
0900dc9e18
Work around race condition in certain plugins
...
Some plugins would either crash or freeze on the next Win32 message loop
when `effEditGetRect` gets called before `effEditOpen` and we run the
message loop between these two event calls.
Fixes the issue with Superior Drummer 3 in Bitwig mentioned in #12 and a
similar issue with the Roland Cloud synths.
2020-05-12 13:17:24 +02:00
4351b03e18
Mention that WantsVstRect can return nothing
2020-05-12 13:14:10 +02:00
Robbert van der Helm