Robbert van der Helm
4bf7e8a5a2
Remove unnecessary iostream import
...
I was going to add a warning to the last commit, but I ended up not
doing it because we should be printing those to the logger instead.
2021-09-26 19:54:56 +02:00
Robbert van der Helm
5aa25109b8
Work around Boost.Process invalid locale bug/crash
...
This should not be causing any issues, but it seems like some people
skip the locale setup step in the Arch installation guide and then end
up with a distro without any locales, with invalid locales, or with a
non-generated locale. glibc and libstd++ fall back to the C locale when
this happens, but Boost.Process triggers one of the edge cases where
this doesn't happen. https://github.com/boostorg/process/pull/179 fixes
this in Boost.Process, but it will be a while until this is in every
distro's copy of Boost.
https://svn.boost.org/trac10/changeset/72855
2021-09-26 19:25:35 +02:00
Robbert van der Helm
3dd5859799
Always print version information in plugin hosts
...
When the plugin host applications are invoked without arguments. Seems a
bit weird when they only print this when invoked with arguments.
2021-09-26 18:20:20 +02:00
Robbert van der Helm
ed6a429c6e
Update the tested Bitwig version
2021-09-24 20:03:43 +02:00
Robbert van der Helm
0c9c4686f1
Use the small buffer optimization for VST3 SysEx
...
We apparently didn't do that yet. SysEx should be super rare (outside of
octave switching on Arturia keyboards), but there's still no reason not
to do it.
2021-09-23 14:29:12 +02:00
Robbert van der Helm
3950f055ad
Fix wording in new warning messages
2021-09-21 15:54:19 +02:00
Robbert van der Helm
7760c4bb6c
Show desktop notification for low RLIMIT_RTTIME
...
For the same reason as the last commit, since people otherwise just miss
this.
2021-09-21 15:40:32 +02:00
Robbert van der Helm
e347944e38
Show desktop notification for the memlock warning
...
Since most people don't try running things in a terminal.
2021-09-21 15:32:47 +02:00
Robbert van der Helm
f26a2a2689
Set VST2 SR and block sizes from main thread
...
This apparently fixes New Sonic Arts' Vice plugin freezing while
loading. Hopefully this doesn't cause issues with other plugins. Spotted
in https://www.kvraudio.com/forum/viewtopic.php?p=8217647#p8217647 .
2021-09-21 14:11:15 +02:00
Robbert van der Helm
31dc23963c
Update the Wine downgrade snippet for apt distros
...
This is now even more of a mess, because for some reason the codename
suffix changed again with Wine 6.17. To keep this compact, we now just
add the `-1` suffix for Wine 6.1 to Wine 6.17, and the `-2` suffix for
Wine 6.17 and above.
While we're add it, might as well add another variant to make it easier
to install an older version of `winehq-stable` or `winehq-devel`, if you
for some reason would want to do that.
2021-09-18 16:28:33 +02:00
Robbert van der Helm
060e6e65ab
Fix typo in issue templates
2021-09-18 00:17:10 +02:00
Robbert van der Helm
6eac5ce336
Bump the tested Bitwig, REAPER, Ardour and Wine versions
2021-09-12 18:47:18 +02:00
Robbert van der Helm
f8703bb49c
Mention that Wine Staging 6.17 works again
...
The change that broke yabridge got reverted:
https://github.com/wine-mirror/wine/commit/e9cfc97d46aaf39bc9c2a41b319d3b3b358c0f04
2021-09-10 23:39:47 +02:00
Robbert van der Helm
84ee693464
Also mention allfonts
...
I forgot about this bullet point. More recent plugins may use different
fonts than what's included in corefonts.
2021-08-30 15:48:18 +02:00
Andrew Morgan
c5f2b25b34
Fix typo in arch package name
...
priviliges -> realtime-privileges
2021-08-29 17:08:03 +02:00
Robbert van der Helm
e550750c5c
Reword the issue templates
2021-08-28 17:54:56 +02:00
Robbert van der Helm
918aadef62
Add issue template fields for the Wine version
2021-08-28 17:53:50 +02:00
Robbert van der Helm
43f715f315
Disable blank issues
...
So far there have been only two blank issues that didn't fall in one of
the three categories we have templates for, and people quite often skip
t he entire template if it's optional, so this will probably make the
issues much more useful.
2021-08-28 17:45:23 +02:00
Robbert van der Helm
7774938969
Replace the feature request template with a form
2021-08-28 17:45:03 +02:00
Robbert van der Helm
3188508fd2
Replace the setup help template with a form
2021-08-28 17:43:23 +02:00
Robbert van der Helm
249ea46189
Tweak the new bug report template slightly
2021-08-28 17:39:41 +02:00
Robbert van der Helm
5ec36be7d5
Don't fill long lines in issue template
...
GitHub seems to treat these newlines as hard line feeds (e.g. just like
two spaces at the end of a line in regular Markdown).
2021-08-28 17:33:28 +02:00
Robbert van der Helm
d908c64532
Redo the bug report issue template using forms
2021-08-28 17:28:56 +02:00
Robbert van der Helm
07cc089455
Also mention that Wine 6.16 is broken
...
I already posted this on the Discord yesterday, but I forgot to update
the readme.
2021-08-28 16:51:17 +02:00
Robbert van der Helm
5b08823f83
Rename issues section to Known issues and fixes
...
Probably makes it a bit clearer that this section nowadays includes a
bunch of fixes and workarounds for these issues.
2021-08-25 13:03:42 +02:00
Robbert van der Helm
a1cbf23f66
Add a changelog entry for the XDND warmup phase
2021-08-22 16:46:06 +02:00
Robbert van der Helm
ec41ec1c81
Add a warmup phase to the XDND implementation
...
This fixes short drops being ignored. Bitwig does this, and I've also
seen some Qt applications do this.
2021-08-22 16:43:02 +02:00
Robbert van der Helm
64f0cbcd41
Fix property reply errors being coerced to 0
...
During a refactor this changed from a boolean to an option, guess I
missed this.
2021-08-22 16:41:40 +02:00
Robbert van der Helm
c12c1459bb
Fix drag-and-drop skipping the first tick
...
This check is of course not supposed to be here.
2021-08-22 15:56:23 +02:00
Robbert van der Helm
e9be5fd369
Plaster the Wine 6.15 note all over the readme
2021-08-18 14:47:15 +02:00
Robbert van der Helm
d7da938bc5
Fix typo in readme
2021-08-18 13:36:30 +02:00
Robbert van der Helm
5bf3b97118
Hide symbols in VST3 static libraries
...
I noticed a couple of UID/string conversion related symbols showing up
in the text section.
2021-08-17 15:50:08 +02:00
Robbert van der Helm
c1b4410e6b
Don't include angular brackets for concrete types
...
In the VST2 log output. I just use this syntax as a more descriptive
handwavy substitute for the actual data.
2021-08-17 15:15:33 +02:00
Robbert van der Helm
f55a04a1fc
Fix VST2 logging message for effEditGetRect()
2021-08-17 15:12:08 +02:00
Robbert van der Helm
5b94a5aff2
Fix CI link in the development build section
2021-08-17 01:45:08 +02:00
Robbert van der Helm
5613248cda
Gate the new resizing behavior behind new option
...
This interferes with resizing plugins using resize handles, and since it
only helps with two buggy plugins this seems like the best solution
here.
2021-08-16 22:39:13 +02:00
Robbert van der Helm
b84aa18ecf
Only reset coordinates when resizing
...
This was the original idea. I though that to be extra safe, maybe we can
do this all the time. And while that does work fine, most of the time,
it does cause a lot of other fun issues especially when plugins fully
redraw themselves that way.
2021-08-16 21:31:57 +02:00
Robbert van der Helm
aee6e9a4a7
Add a todo regarding removing editor_double_embed
2021-08-16 21:24:17 +02:00
Robbert van der Helm
cc9226a3fc
Remove editor_double_embed
...
It's no longer needed after the `fix_local_coordinates()` change from a
fa12c64866a8b79e862bc5db4c4b092a4b762689.
2021-08-16 21:21:57 +02:00
Robbert van der Helm
9ac597a6fd
Make the resize function not-noexcept
...
Since technically the string allocations within the logging for
`fix_local_coordinates()` can throw.
2021-08-16 21:21:57 +02:00
Robbert van der Helm
d46f7882bd
Reposition to (0, 0) while fixing coordinates
...
The goal is to have the window be at (0, 0), while Wine's X11 event
layer thinks it is at the actual screen coordinates. This is needed to
prevent drawing issues with buggy plugins that rely on absolute screen
coordinates to draw their GUI.
2021-08-16 21:21:57 +02:00
Robbert van der Helm
6fab25cabf
Remove unnecessary early return
2021-08-16 21:21:57 +02:00
Patrick Laimbock
462a850dcf
Update README.md
2021-08-16 17:43:39 +02:00
Robbert van der Helm
2b429b1507
Also consider weird setups when downgrading Wine
...
Somehow some people manually add the repository to some list in
`/etc/apt/sources.list.d/` instead of following the instructions from
WineHQ's website, but they then also don't know their distro's codename.
2021-08-14 03:25:47 +02:00
Robbert van der Helm
d8bc7637b4
Mention that Wine 6.15 will break things
2021-08-13 22:26:53 +02:00
Robbert van der Helm
60067abf9a
Fix path to yabridgectl in readme
2021-08-13 11:41:43 +02:00
Robbert van der Helm
13004ef7d2
Fix table of contents in readme
...
This isn't automatically updated anymore since we make some manual
changes.
2021-08-11 22:04:17 +02:00
Robbert van der Helm
8d96eee3c8
Remove VST3 SDK patch for shlobj.h casing
...
They fixed this in version 3.7.3.
2021-08-10 17:15:08 +02:00
Robbert van der Helm
e6f0fe16d8
Target VST3 SDK version 3.7.3
2021-08-10 17:14:48 +02:00
Robbert van der Helm
6bcfc243ac
Note that bitbridging is disabled in some packages
...
Notably NixOS doesn't currently include this (and they're also still on
version 3.3.1).
2021-08-10 13:46:09 +02:00