Commit Graph

2321 Commits

Author SHA1 Message Date
Robbert van der Helm 43f715f315 Disable blank issues
So far there have been only two blank issues that didn't fall in one of
the three categories we have templates for, and people quite often skip
t he entire template if it's optional, so this will probably make the
issues much more useful.
2021-08-28 17:45:23 +02:00
Robbert van der Helm 7774938969 Replace the feature request template with a form 2021-08-28 17:45:03 +02:00
Robbert van der Helm 3188508fd2 Replace the setup help template with a form 2021-08-28 17:43:23 +02:00
Robbert van der Helm 249ea46189 Tweak the new bug report template slightly 2021-08-28 17:39:41 +02:00
Robbert van der Helm 5ec36be7d5 Don't fill long lines in issue template
GitHub seems to treat these newlines as hard line feeds (e.g. just like
two spaces at the end of a line in regular Markdown).
2021-08-28 17:33:28 +02:00
Robbert van der Helm d908c64532 Redo the bug report issue template using forms 2021-08-28 17:28:56 +02:00
Robbert van der Helm 07cc089455 Also mention that Wine 6.16 is broken
I already posted this on the Discord yesterday, but I forgot to update
the readme.
2021-08-28 16:51:17 +02:00
Robbert van der Helm 5b08823f83 Rename issues section to Known issues and fixes
Probably makes it a bit clearer that this section nowadays includes a
bunch of fixes and workarounds for these issues.
2021-08-25 13:03:42 +02:00
Robbert van der Helm a1cbf23f66 Add a changelog entry for the XDND warmup phase 2021-08-22 16:46:06 +02:00
Robbert van der Helm ec41ec1c81 Add a warmup phase to the XDND implementation
This fixes short drops being ignored. Bitwig does this, and I've also
seen some Qt applications do this.
2021-08-22 16:43:02 +02:00
Robbert van der Helm 64f0cbcd41 Fix property reply errors being coerced to 0
During a refactor this changed from a boolean to an option, guess I
missed this.
2021-08-22 16:41:40 +02:00
Robbert van der Helm c12c1459bb Fix drag-and-drop skipping the first tick
This check is of course not supposed to be here.
2021-08-22 15:56:23 +02:00
Robbert van der Helm e9be5fd369 Plaster the Wine 6.15 note all over the readme 2021-08-18 14:47:15 +02:00
Robbert van der Helm d7da938bc5 Fix typo in readme 2021-08-18 13:36:30 +02:00
Robbert van der Helm 5bf3b97118 Hide symbols in VST3 static libraries
I noticed a couple of UID/string conversion related symbols showing up
in the text section.
2021-08-17 15:50:08 +02:00
Robbert van der Helm c1b4410e6b Don't include angular brackets for concrete types
In the VST2 log output. I just use this syntax as a more descriptive
handwavy substitute for the actual data.
2021-08-17 15:15:33 +02:00
Robbert van der Helm f55a04a1fc Fix VST2 logging message for effEditGetRect() 2021-08-17 15:12:08 +02:00
Robbert van der Helm 5b94a5aff2 Fix CI link in the development build section 2021-08-17 01:45:08 +02:00
Robbert van der Helm 5613248cda Gate the new resizing behavior behind new option
This interferes with resizing plugins using resize handles, and since it
only helps with two buggy plugins this seems like the best solution
here.
2021-08-16 22:39:13 +02:00
Robbert van der Helm b84aa18ecf Only reset coordinates when resizing
This was the original idea. I though that to be extra safe, maybe we can
do this all the time. And while that does work fine, most of the time,
it does cause a lot of other fun issues especially when plugins fully
redraw themselves that way.
2021-08-16 21:31:57 +02:00
Robbert van der Helm aee6e9a4a7 Add a todo regarding removing editor_double_embed 2021-08-16 21:24:17 +02:00
Robbert van der Helm cc9226a3fc Remove editor_double_embed
It's no longer needed after the `fix_local_coordinates()` change from a
fa12c64866a8b79e862bc5db4c4b092a4b762689.
2021-08-16 21:21:57 +02:00
Robbert van der Helm 9ac597a6fd Make the resize function not-noexcept
Since technically the string allocations within the logging for
`fix_local_coordinates()` can throw.
2021-08-16 21:21:57 +02:00
Robbert van der Helm d46f7882bd Reposition to (0, 0) while fixing coordinates
The goal is to have the window be at (0, 0), while Wine's X11 event
layer thinks it is at the actual screen coordinates. This is needed to
prevent drawing issues with buggy plugins that rely on absolute screen
coordinates to draw their GUI.
2021-08-16 21:21:57 +02:00
Robbert van der Helm 6fab25cabf Remove unnecessary early return 2021-08-16 21:21:57 +02:00
Patrick Laimbock 462a850dcf Update README.md 2021-08-16 17:43:39 +02:00
Robbert van der Helm 2b429b1507 Also consider weird setups when downgrading Wine
Somehow some people manually add the repository to some list in
`/etc/apt/sources.list.d/` instead of following the instructions from
WineHQ's website, but they then also don't know their distro's codename.
2021-08-14 03:25:47 +02:00
Robbert van der Helm d8bc7637b4 Mention that Wine 6.15 will break things 2021-08-13 22:26:53 +02:00
Robbert van der Helm 60067abf9a Fix path to yabridgectl in readme 2021-08-13 11:41:43 +02:00
Robbert van der Helm 13004ef7d2 Fix table of contents in readme
This isn't automatically updated anymore since we make some manual
changes.
2021-08-11 22:04:17 +02:00
Robbert van der Helm 8d96eee3c8 Remove VST3 SDK patch for shlobj.h casing
They fixed this in version 3.7.3.
2021-08-10 17:15:08 +02:00
Robbert van der Helm e6f0fe16d8 Target VST3 SDK version 3.7.3 2021-08-10 17:14:48 +02:00
Robbert van der Helm 6bcfc243ac Note that bitbridging is disabled in some packages
Notably NixOS doesn't currently include this (and they're also still on
version 3.3.1).
2021-08-10 13:46:09 +02:00
Robbert van der Helm e65c0991a9 Add it
Yes, it is now a thing. We did it Reddit!
2021-08-10 00:20:22 +02:00
Robbert van der Helm bcdc11be0a Update the tested Carla version 2021-08-09 15:58:45 +02:00
Robbert van der Helm 47eb80798b [yabridgectl] Suggest not reading the readme
Yes, a readme that should not be read! I guess it's mostly there for
documentation's sake, because you probably shouldn't need any of
yabridgectl's functionality that's not outlined in the main readme.
2021-08-09 15:56:44 +02:00
Robbert van der Helm 3bbad89c0b Drop the Manual setup section
This probably only caused confusion. If someone wants to do this, then
they'll likely figure it out themselves.
2021-08-09 15:54:43 +02:00
Robbert van der Helm 8ab9159a1f 💥 Rewrite the usage section
I was being lazy so I was waiting for some other distros to package
yabridge before rewriting this, but I might as well do it now.
Technically speaking there's more text here than before, but I've made
sure to put the most important bits in the first sentence of list item.
As it turns out, some people just don't read past somewhere halfway
through the second sentence of a paragraph, regardless of long that
paragraph is. So a bulleted list is probably the best way to go here.
2021-08-09 15:50:55 +02:00
Robbert van der Helm 69d2f15e5c Update the tested Bitwig version 2021-08-09 15:10:53 +02:00
Robbert van der Helm 63975115d2 Bump to version 3.5.2 3.5.2 2021-08-08 15:49:17 +02:00
Robbert van der Helm 54a0e6be87 Fix dates in changelog 2021-08-08 15:43:29 +02:00
Robbert van der Helm a020d97863 Reword changelog 2021-08-08 14:23:04 +02:00
Robbert van der Helm 1883888ec6 Unify exception handling style 2021-08-07 13:17:03 +02:00
Robbert van der Helm 9160de6483 Implement VST2 SysEx events
Apparently these _are_ actually used. Sometimes.
2021-08-04 21:40:09 +02:00
Robbert van der Helm dceafd3016 Use constexpr for VeSTige
It won't actually change anything, but since we're changing the header
anyways might as well change this too.
2021-08-04 21:17:05 +02:00
Robbert van der Helm 387e23d7ec Include types for VST2 SysEx messages
Apparently there is a copy of the VeSTige headers that includes this.
Taken from:

https://github.com/x42/lv2vst/blob/30a669a021812da05258519cef9d4202f5ce26c3/include/vestige.h
2021-08-04 21:16:03 +02:00
Robbert van der Helm 9c334dd488 Include the +editor debug flag in issue template 2021-08-03 20:01:07 +02:00
Robbert van der Helm 2e6732c0e2 Fix regression for VST3 editor initial sizing
We accidentally reverted a little bit too much code in
762e622416. This didn't appear any sooner
because plugins are supposed to call `IPlugFrame::resizeView()` during
`IPlugView::attached()`, so this only affects plugins that don't confirm
to the spec.
2021-08-02 14:47:21 +02:00
ElizabethHarmon 1287beb1fe fix word omission 2021-08-01 18:56:53 +02:00
Robbert van der Helm ff1ffb29f8 Add instructions for realtime priviliges
This closes #124.
2021-08-01 18:49:29 +02:00