mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-10 04:30:12 +02:00
Remove XEmbed testing todo
Still seems to work 'fine' (as in, not really).
This commit is contained in:
@@ -777,14 +777,15 @@ void Vst3Bridge::run() {
|
|||||||
},
|
},
|
||||||
[&](const YaPlugView::Removed& request)
|
[&](const YaPlugView::Removed& request)
|
||||||
-> YaPlugView::Removed::Response {
|
-> YaPlugView::Removed::Response {
|
||||||
|
Vst3PluginInstance& instance =
|
||||||
|
object_instances.at(request.owner_instance_id);
|
||||||
|
|
||||||
return main_context
|
return main_context
|
||||||
.run_in_context([&]() -> tresult {
|
.run_in_context([&]() -> tresult {
|
||||||
// Cleanup is handled through RAII
|
// Cleanup is handled through RAII
|
||||||
const tresult result =
|
const tresult result =
|
||||||
object_instances.at(request.owner_instance_id)
|
instance.plug_view_instance->plug_view->removed();
|
||||||
.plug_view_instance->plug_view->removed();
|
instance.editor.reset();
|
||||||
object_instances.at(request.owner_instance_id)
|
|
||||||
.editor.reset();
|
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -884,8 +884,6 @@ void Editor::do_xembed() const {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: Test if XEmbed still works, or if it maybe works better now
|
|
||||||
|
|
||||||
// If we're embedding using XEmbed, then we'll have to go through the whole
|
// If we're embedding using XEmbed, then we'll have to go through the whole
|
||||||
// XEmbed dance here. See the spec for more information on how this works:
|
// XEmbed dance here. See the spec for more information on how this works:
|
||||||
// https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html#lifecycle
|
// https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html#lifecycle
|
||||||
|
|||||||
Reference in New Issue
Block a user