Remove XEmbed testing todo

Still seems to work 'fine' (as in, not really).
This commit is contained in:
Robbert van der Helm
2021-07-21 16:36:05 +02:00
parent e95f381fa0
commit e223c98b0d
2 changed files with 5 additions and 6 deletions
+5 -4
View File
@@ -777,14 +777,15 @@ void Vst3Bridge::run() {
},
[&](const YaPlugView::Removed& request)
-> YaPlugView::Removed::Response {
Vst3PluginInstance& instance =
object_instances.at(request.owner_instance_id);
return main_context
.run_in_context([&]() -> tresult {
// Cleanup is handled through RAII
const tresult result =
object_instances.at(request.owner_instance_id)
.plug_view_instance->plug_view->removed();
object_instances.at(request.owner_instance_id)
.editor.reset();
instance.plug_view_instance->plug_view->removed();
instance.editor.reset();
return result;
})
-2
View File
@@ -884,8 +884,6 @@ void Editor::do_xembed() const {
return;
}
// TODO: Test if XEmbed still works, or if it maybe works better now
// If we're embedding using XEmbed, then we'll have to go through the whole
// XEmbed dance here. See the spec for more information on how this works:
// https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html#lifecycle