vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-06-18 17:33:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix the semantics of YaPhysicalUIMapList

Browse Source 
We're supposed to take the list provided by the host, and modify the
target note expression values.
This commit is contained in:
Robbert van der Helm
2021-01-15 19:23:25 +01:00
parent cc35e89252
commit d9d389bebf
2 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3/physical-ui-map-list.h
+14 -4
View File
@@ -22,7 +22,10 @@
/**
* Serialization wrapper around `PhysicalUIMapList` that allows loading such a
* list and recreating one from a `YaPhysicalUIMapList` object.
* list and writing the changes made by the plugin back to the original list.
* The host provides a list with the `physicalUITypeID` field set for each
* mapping, and the plugin then sets the `noteExpressionTypeID` to one of its
* note expression of it can handle it.
*/
class YaPhysicalUIMapList {
public:
@@ -35,12 +38,19 @@ class YaPhysicalUIMapList {
/**
* Reconstruct the original `PhysicalUIMapList` object passed to the
* constructor and return it. This is used as part of
* `YaProcessData::get()`. The returned object is valid as long as this
* object is alive.
* constructor and return it. This is used to handle
* `INoteExpressionPhysicalUIMapping::getPhysicalUIMapping()` on the Wine
* plugin host side. The returned object is valid as long as this object is
* alive.
*/
Steinberg::Vst::PhysicalUIMapList get();
/**
* Write the `noteExpressionTypeID` values stored in `maps` back to the
* original physical UI mapping list we copied `maps` from.
*/
void write_back(Steinberg::Vst::PhysicalUIMapList& list) const;
template <typename S>
void serialize(S& s) {
s.container(maps, 1 << 31);