vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Skip main thread requirement in array lookups

Browse Source 
This should be fine, right? We'll do it everywhere else, but especially
for parameters this is going to be very costly and may thus increase
plugin startup time by a noticeable amount if we spool every individual
call to the main thread.
This commit is contained in:
Robbert van der Helm
2022-09-13 18:28:30 +02:00
parent 168837c8ac
commit cead56c9aa
1 changed files with 32 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/clap.cpp
+32 -44
View File
@@ -313,65 +313,53 @@ void ClapBridge::run() {
-> clap::ext::audio_ports::plugin::Count::Response {
const auto& [instance, _] = get_instance(request.instance_id);
return main_context_
.run_in_context(
[&, plugin = instance.plugin.get(),
audio_ports = instance.extensions.audio_ports]() {
return audio_ports->count(plugin, request.is_input);
})
.get();
// We'll ignore the main thread requirement for simple array
// lookups to avoid the synchronisation costs in code code paths
return instance.extensions.audio_ports->count(
instance.plugin.get(), request.is_input);
},
[&](const clap::ext::audio_ports::plugin::Get& request)
-> clap::ext::audio_ports::plugin::Get::Response {
const auto& [instance, _] = get_instance(request.instance_id);
return main_context_
.run_in_context([&, plugin = instance.plugin.get(),
audio_ports =
instance.extensions.audio_ports]() {
clap_audio_port_info_t info{};
if (audio_ports->get(plugin, request.index,
request.is_input, &info)) {
return clap::ext::audio_ports::plugin::GetResponse{
.result = info};
} else {
return clap::ext::audio_ports::plugin::GetResponse{
.result = std::nullopt};
}
})
.get();
// We'll ignore the main thread requirement for simple array
// lookups to avoid the synchronisation costs in code code paths
clap_audio_port_info_t info{};
if (instance.extensions.audio_ports->get(
instance.plugin.get(), request.index, request.is_input,
&info)) {
return clap::ext::audio_ports::plugin::GetResponse{
.result = info};
} else {
return clap::ext::audio_ports::plugin::GetResponse{
.result = std::nullopt};
}
},
[&](const clap::ext::note_ports::plugin::Count& request)
-> clap::ext::note_ports::plugin::Count::Response {
const auto& [instance, _] = get_instance(request.instance_id);
return main_context_
.run_in_context(
[&, plugin = instance.plugin.get(),
note_ports = instance.extensions.note_ports]() {
return note_ports->count(plugin, request.is_input);
})
.get();
// We'll ignore the main thread requirement for simple array
// lookups to avoid the synchronisation costs in code code paths
return instance.extensions.note_ports->count(
instance.plugin.get(), request.is_input);
},
[&](const clap::ext::note_ports::plugin::Get& request)
-> clap::ext::note_ports::plugin::Get::Response {
const auto& [instance, _] = get_instance(request.instance_id);
return main_context_
.run_in_context([&, plugin = instance.plugin.get(),
note_ports =
instance.extensions.note_ports]() {
clap_note_port_info_t info{};
if (note_ports->get(plugin, request.index,
request.is_input, &info)) {
return clap::ext::note_ports::plugin::GetResponse{
.result = info};
} else {
return clap::ext::note_ports::plugin::GetResponse{
.result = std::nullopt};
}
})
.get();
// We'll ignore the main thread requirement for simple array
// lookups to avoid the synchronisation costs in code code paths
clap_note_port_info_t info{};
if (instance.extensions.note_ports->get(
instance.plugin.get(), request.index, request.is_input,
&info)) {
return clap::ext::note_ports::plugin::GetResponse{.result =
info};
} else {
return clap::ext::note_ports::plugin::GetResponse{
.result = std::nullopt};
}
},
});
}