vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-06-16 00:13:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant information from logging

Browse Source
This commit is contained in:
Robbert van der Helm
2020-03-07 23:40:09 +01:00
parent 3bfb6cf38b
commit b67a3546b7
3 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/logging.cpp
+4 -7
View File
@@ -93,10 +93,10 @@ void Logger::log_get_parameter(int32_t index) {
} }
} }
void Logger::log_get_parameter_response(int32_t index, float value) { void Logger::log_get_parameter_response(float value) {
if (verbosity >= Verbosity::events) { if (verbosity >= Verbosity::events) {
std::ostringstream message; std::ostringstream message;
message << " getParameter() :: " << index << " == " << value; message << " getParameter() :: " << value;
log(message.str()); log(message.str());
} }
@@ -111,12 +111,9 @@ void Logger::log_set_parameter(int32_t index, float value) {
} }
} }
void Logger::log_set_parameter_response(int32_t index) { void Logger::log_set_parameter_response() {
if (verbosity >= Verbosity::events) { if (verbosity >= Verbosity::events) {
std::ostringstream message; log(" setParameter() :: OK");
message << " setParameter() :: " << index << " OK";
log(message.str());
} }
} }
src/common/logging.h
+2 -2
View File
@@ -89,9 +89,9 @@ class Logger {
// The following functions are for logging specific events, they are only // The following functions are for logging specific events, they are only
// enabled for verbosity levels higher than 1 (i.e. `Verbosity::events`) // enabled for verbosity levels higher than 1 (i.e. `Verbosity::events`)
void log_get_parameter(int32_t index); void log_get_parameter(int32_t index);
void log_get_parameter_response(int32_t index, float vlaue); void log_get_parameter_response(float vlaue);
void log_set_parameter(int32_t index, float value); void log_set_parameter(int32_t index, float value);
void log_set_parameter_response(int32_t index); void log_set_parameter_response();
// If is_dispatch is true, then use opcode names from the plugin's dispatch // If is_dispatch is true, then use opcode names from the plugin's dispatch
// function. Otherwise use names for the host callback function opcodes. // function. Otherwise use names for the host callback function opcodes.
void log_event(bool is_dispatch, void log_event(bool is_dispatch,
src/plugin/host-bridge.cpp
+2 -2
View File
@@ -207,7 +207,7 @@ float HostBridge::get_parameter(AEffect* /*plugin*/, int32_t index) {
write_object(host_vst_parameters, request); write_object(host_vst_parameters, request);
const auto response = read_object<ParameterResult>(host_vst_parameters); const auto response = read_object<ParameterResult>(host_vst_parameters);
logger.log_get_parameter_response(index, response.value.value()); logger.log_get_parameter_response(response.value.value());
return response.value.value(); return response.value.value();
} }
@@ -222,7 +222,7 @@ void HostBridge::set_parameter(AEffect* /*plugin*/,
// This should not contain any values and just serve as an acknowledgement // This should not contain any values and just serve as an acknowledgement
const auto response = read_object<ParameterResult>(host_vst_parameters); const auto response = read_object<ParameterResult>(host_vst_parameters);
logger.log_set_parameter_response(index); logger.log_set_parameter_response();
assert(!response.value.has_value()); assert(!response.value.has_value());
} }