From b67a3546b74c9a703774cfbfb9df01657918522b Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Sat, 7 Mar 2020 23:40:09 +0100
Subject: [PATCH] Remove redundant information from logging

---
 src/common/logging.cpp     | 11 ++++-------
 src/common/logging.h       |  4 ++--
 src/plugin/host-bridge.cpp |  4 ++--
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/common/logging.cpp b/src/common/logging.cpp
index 962abedf..166d24c9 100644
--- a/src/common/logging.cpp
+++ b/src/common/logging.cpp
@@ -93,10 +93,10 @@ void Logger::log_get_parameter(int32_t index) {
     }
 }
 
-void Logger::log_get_parameter_response(int32_t index, float value) {
+void Logger::log_get_parameter_response(float value) {
     if (verbosity >= Verbosity::events) {
         std::ostringstream message;
-        message << "   getParameter() :: " << index << " == " << value;
+        message << "   getParameter() :: " << value;
 
         log(message.str());
     }
@@ -111,12 +111,9 @@ void Logger::log_set_parameter(int32_t index, float value) {
     }
 }
 
-void Logger::log_set_parameter_response(int32_t index) {
+void Logger::log_set_parameter_response() {
     if (verbosity >= Verbosity::events) {
-        std::ostringstream message;
-        message << "  setParameter() :: " << index << " OK";
-
-        log(message.str());
+        log("   setParameter() :: OK");
     }
 }
 
diff --git a/src/common/logging.h b/src/common/logging.h
index 938a7ae0..a22164a0 100644
--- a/src/common/logging.h
+++ b/src/common/logging.h
@@ -89,9 +89,9 @@ class Logger {
     // The following functions are for logging specific events, they are only
     // enabled for verbosity levels higher than 1 (i.e. `Verbosity::events`)
     void log_get_parameter(int32_t index);
-    void log_get_parameter_response(int32_t index, float vlaue);
+    void log_get_parameter_response(float vlaue);
     void log_set_parameter(int32_t index, float value);
-    void log_set_parameter_response(int32_t index);
+    void log_set_parameter_response();
     // If is_dispatch is true, then use opcode names from the plugin's dispatch
     // function. Otherwise use names for the host callback function opcodes.
     void log_event(bool is_dispatch,
diff --git a/src/plugin/host-bridge.cpp b/src/plugin/host-bridge.cpp
index 185fa41e..84f53248 100644
--- a/src/plugin/host-bridge.cpp
+++ b/src/plugin/host-bridge.cpp
@@ -207,7 +207,7 @@ float HostBridge::get_parameter(AEffect* /*plugin*/, int32_t index) {
     write_object(host_vst_parameters, request);
 
     const auto response = read_object<ParameterResult>(host_vst_parameters);
-    logger.log_get_parameter_response(index, response.value.value());
+    logger.log_get_parameter_response(response.value.value());
 
     return response.value.value();
 }
@@ -222,7 +222,7 @@ void HostBridge::set_parameter(AEffect* /*plugin*/,
 
     // This should not contain any values and just serve as an acknowledgement
     const auto response = read_object<ParameterResult>(host_vst_parameters);
-    logger.log_set_parameter_response(index);
+    logger.log_set_parameter_response();
 
     assert(!response.value.has_value());
 }