vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix typo in the in place std::variant<> extension

Browse Source 
We of course want to do this for non-trivial types as mentioned in the
comment above, not for trivial types...
This commit is contained in:
Robbert van der Helm
2021-05-28 14:17:35 +02:00
parent f533dd40ce
commit b4c9f53bcf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/bitsery/ext/in-place-variant.h
+1 -1
View File
@@ -51,7 +51,7 @@ class InPlaceVariant : public StdVariant<Overloads...> {
// Reinitializing nontrivial types may be expensive especially when // Reinitializing nontrivial types may be expensive especially when
// they reference heap data, so if `data` is already holding the // they reference heap data, so if `data` is already holding the
// requested variant then we'll deserialize into the existing object // requested variant then we'll deserialize into the existing object
if constexpr (std::is_trivial_v<TElem>) { if constexpr (!std::is_trivial_v<TElem>) {
if (auto item = std::get_if<TElem>(&data)) { if (auto item = std::get_if<TElem>(&data)) {
this->serializeType(des, *item); this->serializeType(des, *item);
return; return;