From b4c9f53bcf94d7cfaf11951aa7cf0c20dda28cb4 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 28 May 2021 14:17:35 +0200 Subject: [PATCH] Fix typo in the in place std::variant<> extension We of course want to do this for non-trivial types as mentioned in the comment above, not for trivial types... --- src/common/bitsery/ext/in-place-variant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/bitsery/ext/in-place-variant.h b/src/common/bitsery/ext/in-place-variant.h index f903873c..5d04a8fa 100644 --- a/src/common/bitsery/ext/in-place-variant.h +++ b/src/common/bitsery/ext/in-place-variant.h @@ -51,7 +51,7 @@ class InPlaceVariant : public StdVariant { // Reinitializing nontrivial types may be expensive especially when // they reference heap data, so if `data` is already holding the // requested variant then we'll deserialize into the existing object - if constexpr (std::is_trivial_v) { + if constexpr (!std::is_trivial_v) { if (auto item = std::get_if(&data)) { this->serializeType(des, *item); return;