vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 12:10:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Run all other lifecycle events on main thread

Browse Source 
This is probably where plugins instantiate timers for their GUI updates.
This commit is contained in:
Robbert van der Helm
2020-12-20 12:29:59 +01:00
parent f2153148b2
commit b38f272013
1 changed files with 46 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst3.cpp
+46 -20
View File
@@ -86,20 +86,35 @@ void Vst3Bridge::run() {
// Even though we're requesting a specific interface (to mimic
// what the host is doing), we're immediately upcasting it to an
// `FUnknown` so we can create a perfect proxy object.
Steinberg::IPtr<Steinberg::FUnknown> object;
switch (request.requested_interface) {
case Vst3PluginProxy::Construct::Interface::IComponent:
object =
module->getFactory()
.createInstance<Steinberg::Vst::IComponent>(
cid);
break;
case Vst3PluginProxy::Construct::Interface::IEditController:
object = module->getFactory()
.createInstance<
Steinberg::Vst::IEditController>(cid);
break;
}
// We create the object from the GUI thread in case it
// immediatly starts timers or something (even though it
// shouldn't)
Steinberg::IPtr<Steinberg::FUnknown> object =
main_context
.run_in_context<Steinberg::IPtr<Steinberg::FUnknown>>(
[&]() -> Steinberg::IPtr<Steinberg::FUnknown> {
switch (request.requested_interface) {
case Vst3PluginProxy::Construct::Interface::
IComponent:
return module->getFactory()
.createInstance<
Steinberg::Vst::IComponent>(
cid);
break;
case Vst3PluginProxy::Construct::Interface::
IEditController:
return module->getFactory()
.createInstance<
Steinberg::Vst::
IEditController>(cid);
break;
default:
// Unreachable
return nullptr;
break;
}
})
.get();
if (object) {
std::lock_guard lock(object_instances_mutex);
@@ -490,15 +505,26 @@ void Vst3Bridge::run() {
nullptr;
}
return object_instances[request.instance_id]
.plugin_base->initialize(
object_instances[request.instance_id]
.host_context_proxy);
// XXX: Should `IPlugView::{initialize,terminate}` be run from
// the main UI thread? I can see how plugins would want to
// start timers from here.
return main_context
.run_in_context<tresult>([&]() {
return object_instances[request.instance_id]
.plugin_base->initialize(
object_instances[request.instance_id]
.host_context_proxy);
})
.get();
},
[&](const YaPluginBase::Terminate& request)
-> YaPluginBase::Terminate::Response {
return object_instances[request.instance_id]
.plugin_base->terminate();
return main_context
.run_in_context<tresult>([&]() {
return object_instances[request.instance_id]
.plugin_base->terminate();
})
.get();
},
[&](const YaPluginFactory::Construct&)
-> YaPluginFactory::Construct::Response {