mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-06-18 17:33:56 +02:00
Add a todo for removing cached functions
This commit is contained in:
@@ -37,6 +37,9 @@ YaHostApplication::YaHostApplication(const ConstructArgs&& args)
|
|||||||
: arguments(std::move(args)) {}
|
: arguments(std::move(args)) {}
|
||||||
|
|
||||||
tresult PLUGIN_API YaHostApplication::getName(Steinberg::Vst::String128 name) {
|
tresult PLUGIN_API YaHostApplication::getName(Steinberg::Vst::String128 name) {
|
||||||
|
// TODO: This is now not being logged at all. It's probably better if we
|
||||||
|
// just drop these two functions that output cached data directly.
|
||||||
|
// They'll only be used once or twice anyways.
|
||||||
if (arguments.name) {
|
if (arguments.name) {
|
||||||
// Terminate with a null byte. There are no nice functions for copying
|
// Terminate with a null byte. There are no nice functions for copying
|
||||||
// UTF-16 strings (because who would use those?).
|
// UTF-16 strings (because who would use those?).
|
||||||
|
|||||||
@@ -37,6 +37,9 @@ YaComponent::YaComponent(const ConstructArgs&& args)
|
|||||||
: arguments(std::move(args)) {}
|
: arguments(std::move(args)) {}
|
||||||
|
|
||||||
tresult PLUGIN_API YaComponent::getControllerClassId(Steinberg::TUID classId) {
|
tresult PLUGIN_API YaComponent::getControllerClassId(Steinberg::TUID classId) {
|
||||||
|
// TODO: This is now not being logged at all. It's probably better if we
|
||||||
|
// just drop these two functions that output cached data directly.
|
||||||
|
// They'll only be used once or twice anyways.
|
||||||
if (arguments.edit_controller_cid) {
|
if (arguments.edit_controller_cid) {
|
||||||
std::copy(arguments.edit_controller_cid->begin(),
|
std::copy(arguments.edit_controller_cid->begin(),
|
||||||
arguments.edit_controller_cid->end(), classId);
|
arguments.edit_controller_cid->end(), classId);
|
||||||
|
|||||||
Reference in New Issue
Block a user