Add a todo for removing cached functions

This commit is contained in:
Robbert van der Helm
2020-12-19 17:19:01 +01:00
parent 0522f84f4a
commit 85faca736f
2 changed files with 6 additions and 0 deletions
@@ -37,6 +37,9 @@ YaHostApplication::YaHostApplication(const ConstructArgs&& args)
: arguments(std::move(args)) {}
tresult PLUGIN_API YaHostApplication::getName(Steinberg::Vst::String128 name) {
// TODO: This is now not being logged at all. It's probably better if we
// just drop these two functions that output cached data directly.
// They'll only be used once or twice anyways.
if (arguments.name) {
// Terminate with a null byte. There are no nice functions for copying
// UTF-16 strings (because who would use those?).
@@ -37,6 +37,9 @@ YaComponent::YaComponent(const ConstructArgs&& args)
: arguments(std::move(args)) {}
tresult PLUGIN_API YaComponent::getControllerClassId(Steinberg::TUID classId) {
// TODO: This is now not being logged at all. It's probably better if we
// just drop these two functions that output cached data directly.
// They'll only be used once or twice anyways.
if (arguments.edit_controller_cid) {
std::copy(arguments.edit_controller_cid->begin(),
arguments.edit_controller_cid->end(), classId);