Use raw pointers for the plugin factory

Since the object cleans up after itself after the smart pointers are
dropped on the host side this would result in a use after free by the
smart pointers.
This commit is contained in:
Robbert van der Helm
2020-12-07 18:23:04 +01:00
parent d79bc3b936
commit 7b3a6af7d1
3 changed files with 10 additions and 13 deletions
+4 -4
View File
@@ -80,11 +80,11 @@ class Vst3PluginBridge : PluginBridge<Vst3Sockets<std::jthread>> {
* Our plugin factory. All information about the plugin and its supported
* classes are copied directly from the Windows VST3 plugin's factory on the
* Wine side, and we'll provide an implementation that can send control
* messages to the Wine plugin host. The VST3 interface only passes raw
* pointers around and the receiving side should then use `IPtr<T>::adopt()`
* or `owned()` to get back the orignal smart pointer.
* messages to the Wine plugin host. As explained in `get_plugin_factory()`,
* this cannot be a smart pointer because the factory is supposed to free
* itself when the host removes its last adopted `IPtr<IpluginFactory>`.
*
* @related get_plugin_factory
*/
Steinberg::IPtr<YaPluginFactory> plugin_factory;
YaPluginFactory* plugin_factory;
};