Remove resolved todo

This commit is contained in:
Robbert van der Helm
2020-04-19 15:55:12 +02:00
parent 6025efb0fc
commit 717ffb719d
2 changed files with 0 additions and 10 deletions
-2
View File
@@ -215,8 +215,6 @@ void passthrough_event(boost::asio::local::stream_protocol::socket& socket,
// function that intercepts `effEditOpen` events and creates a
// Win32 window and then finally embeds the X11 window Wine
// created into this wnidow handle.
// TODO: Check if the host passes the window handle like this,
// or if the window handle is behind the pointer
return reinterpret_cast<void*>(window_handle);
},
[&](const AEffect&) -> void* { return nullptr; },
-8
View File
@@ -193,8 +193,6 @@ class DispatchDataConverter : DefaultDataConverter {
// pointer. In the Wine VST host we'll create a Win32 window,
// ask the plugin to embed itself in that and then embed that
// window into this X11 window handle.
// TODO: Check if the host passes the window handle like this,
// or if the window handle is behind the pointer
return reinterpret_cast<size_t>(data);
break;
case effGetChunk:
@@ -228,12 +226,6 @@ class DispatchDataConverter : DefaultDataConverter {
const auto new_rect = std::get<VstRect>(response.payload);
rect = new_rect;
// TODO: Maybe the host expects this field to be always up to
// date, so if the editor resizes itself then the
// `VstRect` behind this pointer should change as well
// without any additional dispatch calls. If that's the
// case, then we can probably reuse
// `audioMasterSizeWindow`.
*static_cast<VstRect**>(data) = &rect;
} break;
case effGetChunk: {