From 717ffb719db2161481ab63acf34e9f51c7ee94f4 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Sun, 19 Apr 2020 15:55:12 +0200 Subject: [PATCH] Remove resolved todo --- src/common/events.h | 2 -- src/plugin/host-bridge.cpp | 8 -------- 2 files changed, 10 deletions(-) diff --git a/src/common/events.h b/src/common/events.h index dfc50fec..ae414c9d 100644 --- a/src/common/events.h +++ b/src/common/events.h @@ -215,8 +215,6 @@ void passthrough_event(boost::asio::local::stream_protocol::socket& socket, // function that intercepts `effEditOpen` events and creates a // Win32 window and then finally embeds the X11 window Wine // created into this wnidow handle. - // TODO: Check if the host passes the window handle like this, - // or if the window handle is behind the pointer return reinterpret_cast(window_handle); }, [&](const AEffect&) -> void* { return nullptr; }, diff --git a/src/plugin/host-bridge.cpp b/src/plugin/host-bridge.cpp index 587936ce..16075018 100644 --- a/src/plugin/host-bridge.cpp +++ b/src/plugin/host-bridge.cpp @@ -193,8 +193,6 @@ class DispatchDataConverter : DefaultDataConverter { // pointer. In the Wine VST host we'll create a Win32 window, // ask the plugin to embed itself in that and then embed that // window into this X11 window handle. - // TODO: Check if the host passes the window handle like this, - // or if the window handle is behind the pointer return reinterpret_cast(data); break; case effGetChunk: @@ -228,12 +226,6 @@ class DispatchDataConverter : DefaultDataConverter { const auto new_rect = std::get(response.payload); rect = new_rect; - // TODO: Maybe the host expects this field to be always up to - // date, so if the editor resizes itself then the - // `VstRect` behind this pointer should change as well - // without any additional dispatch calls. If that's the - // case, then we can probably reuse - // `audioMasterSizeWindow`. *static_cast(data) = ▭ } break; case effGetChunk: {