mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-09 20:29:10 +02:00
Remove resolved todo
This commit is contained in:
@@ -215,8 +215,6 @@ void passthrough_event(boost::asio::local::stream_protocol::socket& socket,
|
|||||||
// function that intercepts `effEditOpen` events and creates a
|
// function that intercepts `effEditOpen` events and creates a
|
||||||
// Win32 window and then finally embeds the X11 window Wine
|
// Win32 window and then finally embeds the X11 window Wine
|
||||||
// created into this wnidow handle.
|
// created into this wnidow handle.
|
||||||
// TODO: Check if the host passes the window handle like this,
|
|
||||||
// or if the window handle is behind the pointer
|
|
||||||
return reinterpret_cast<void*>(window_handle);
|
return reinterpret_cast<void*>(window_handle);
|
||||||
},
|
},
|
||||||
[&](const AEffect&) -> void* { return nullptr; },
|
[&](const AEffect&) -> void* { return nullptr; },
|
||||||
|
|||||||
@@ -193,8 +193,6 @@ class DispatchDataConverter : DefaultDataConverter {
|
|||||||
// pointer. In the Wine VST host we'll create a Win32 window,
|
// pointer. In the Wine VST host we'll create a Win32 window,
|
||||||
// ask the plugin to embed itself in that and then embed that
|
// ask the plugin to embed itself in that and then embed that
|
||||||
// window into this X11 window handle.
|
// window into this X11 window handle.
|
||||||
// TODO: Check if the host passes the window handle like this,
|
|
||||||
// or if the window handle is behind the pointer
|
|
||||||
return reinterpret_cast<size_t>(data);
|
return reinterpret_cast<size_t>(data);
|
||||||
break;
|
break;
|
||||||
case effGetChunk:
|
case effGetChunk:
|
||||||
@@ -228,12 +226,6 @@ class DispatchDataConverter : DefaultDataConverter {
|
|||||||
const auto new_rect = std::get<VstRect>(response.payload);
|
const auto new_rect = std::get<VstRect>(response.payload);
|
||||||
rect = new_rect;
|
rect = new_rect;
|
||||||
|
|
||||||
// TODO: Maybe the host expects this field to be always up to
|
|
||||||
// date, so if the editor resizes itself then the
|
|
||||||
// `VstRect` behind this pointer should change as well
|
|
||||||
// without any additional dispatch calls. If that's the
|
|
||||||
// case, then we can probably reuse
|
|
||||||
// `audioMasterSizeWindow`.
|
|
||||||
*static_cast<VstRect**>(data) = ▭
|
*static_cast<VstRect**>(data) = ▭
|
||||||
} break;
|
} break;
|
||||||
case effGetChunk: {
|
case effGetChunk: {
|
||||||
|
|||||||
Reference in New Issue
Block a user