Inhibit event loop after IPluginBase::terminate()

This 'fixes' recent Arturia VST3 plugins crashing at the end of a plugin
scan in REAPER.
This commit is contained in:
Robbert van der Helm
2022-06-11 22:53:13 +02:00
parent ae73df2b17
commit 61b141a0fe
2 changed files with 17 additions and 0 deletions
+7
View File
@@ -12,6 +12,13 @@ Versioning](https://semver.org/spec/v2.0.0.html).
- Added a `system-asio` build option to aid distro packaging.
### Fixed
- Fixed recent _Arturia_ VST3 plugins running into memory errors during plugin
scans in **REAPER** and **Ardour**. These plugins would try to read data in
the Windows event loop without checking whether that data was initialized,
after the data had just been deinitialized.
### yabridgectl
- Fixed a regression from yabridge 4.0.0 where VST3 plugins in the 'new' bundle
+10
View File
@@ -1080,6 +1080,16 @@ void Vst3Bridge::run() {
const auto& [instance, _] =
get_instance(request.instance_id);
// HACK: New (anno May/June 2022) Arturia VST3 plugins
// don't check whether the data they try to access
// from their Win32 timers is actually
// initialized, and this function deinitializes
// that data. So if this is followed by
// `handle_events()`, then the plugin would run
// into a memory error. Inhibiting that event loop
// 'fixes' this.
instance.is_initialized = false;
return instance.interfaces.plugin_base->terminate();
})
.get();