Fully implement IEditControllerHostEditing

src/common/serialization/vst3.h

@@ -89,6 +89,8 @@ using ControlRequest =
                  YaEditController2::SetKnobMode,
                  YaEditController2::OpenHelp,
                  YaEditController2::OpenAboutBox,
+                 YaEditControllerHostEditing::BeginEditFromHost,
+                 YaEditControllerHostEditing::EndEditFromHost,
                  YaMidiMapping::GetMidiControllerAssignment,
                  YaNoteExpressionController::GetNoteExpressionCount,
                  YaNoteExpressionController::GetNoteExpressionInfo,

src/plugin/bridges/vst3-impls/plugin-proxy.cpp

@@ -453,16 +453,14 @@ tresult PLUGIN_API Vst3PluginProxyImpl::openAboutBox(TBool onlyCheck) {
 
 tresult PLUGIN_API
 Vst3PluginProxyImpl::beginEditFromHost(Steinberg::Vst::ParamID paramID) {
-    // TODO: Implement
+    return bridge.send_message(YaEditControllerHostEditing::BeginEditFromHost{
-    bridge.logger.log("TODO: IEditControllerHostEditing::beginEditFromhost()");
+        .instance_id = instance_id(), .param_id = paramID});
-    return Steinberg::kNotImplemented;
 }
 
 tresult PLUGIN_API
 Vst3PluginProxyImpl::endEditFromHost(Steinberg::Vst::ParamID paramID) {
-    // TODO: Implement
+    return bridge.send_message(YaEditControllerHostEditing::EndEditFromHost{
-    bridge.logger.log("TODO: IEditControllerHostEditing::endEditFromhost()");
+        .instance_id = instance_id(), .param_id = paramID});
-    return Steinberg::kNotImplemented;
 }
 
 tresult PLUGIN_API Vst3PluginProxyImpl::getMidiControllerAssignment(

src/wine-host/bridges/vst3.cpp

@@ -399,6 +399,18 @@ void Vst3Bridge::run() {
                 return object_instances[request.instance_id]
                     .edit_controller_2->openAboutBox(request.only_check);
             },
+            [&](const YaEditControllerHostEditing::BeginEditFromHost& request)
+                -> YaEditControllerHostEditing::BeginEditFromHost::Response {
+                return object_instances[request.instance_id]
+                    .edit_controller_host_editing->beginEditFromHost(
+                        request.param_id);
+            },
+            [&](const YaEditControllerHostEditing::EndEditFromHost& request)
+                -> YaEditControllerHostEditing::EndEditFromHost::Response {
+                return object_instances[request.instance_id]
+                    .edit_controller_host_editing->endEditFromHost(
+                        request.param_id);
+            },
             [&](const YaMidiMapping::GetMidiControllerAssignment& request)
                 -> YaMidiMapping::GetMidiControllerAssignment::Response {
                 Steinberg::Vst::ParamID id;