vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fully implement IEditControllerHostEditing

Browse Source
This commit is contained in:
Robbert van der Helm
2021-01-08 16:33:27 +01:00
parent 70b667f3b0
commit 5d5ec63fee
3 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3.h
+2
View File
@@ -89,6 +89,8 @@ using ControlRequest =
YaEditController2::SetKnobMode,
YaEditController2::OpenHelp,
YaEditController2::OpenAboutBox,
YaEditControllerHostEditing::BeginEditFromHost,
YaEditControllerHostEditing::EndEditFromHost,
YaMidiMapping::GetMidiControllerAssignment,
YaNoteExpressionController::GetNoteExpressionCount,
YaNoteExpressionController::GetNoteExpressionInfo,
src/plugin/bridges/vst3-impls/plugin-proxy.cpp
+4 -6
View File
@@ -453,16 +453,14 @@ tresult PLUGIN_API Vst3PluginProxyImpl::openAboutBox(TBool onlyCheck) {
tresult PLUGIN_API
Vst3PluginProxyImpl::beginEditFromHost(Steinberg::Vst::ParamID paramID) {
// TODO: Implement
bridge.logger.log("TODO: IEditControllerHostEditing::beginEditFromhost()");
return Steinberg::kNotImplemented;
return bridge.send_message(YaEditControllerHostEditing::BeginEditFromHost{
.instance_id = instance_id(), .param_id = paramID});
}
tresult PLUGIN_API
Vst3PluginProxyImpl::endEditFromHost(Steinberg::Vst::ParamID paramID) {
// TODO: Implement
bridge.logger.log("TODO: IEditControllerHostEditing::endEditFromhost()");
return Steinberg::kNotImplemented;
return bridge.send_message(YaEditControllerHostEditing::EndEditFromHost{
.instance_id = instance_id(), .param_id = paramID});
}
tresult PLUGIN_API Vst3PluginProxyImpl::getMidiControllerAssignment(
src/wine-host/bridges/vst3.cpp
+12
View File
@@ -399,6 +399,18 @@ void Vst3Bridge::run() {
return object_instances[request.instance_id]
.edit_controller_2->openAboutBox(request.only_check);
},
[&](const YaEditControllerHostEditing::BeginEditFromHost& request)
-> YaEditControllerHostEditing::BeginEditFromHost::Response {
return object_instances[request.instance_id]
.edit_controller_host_editing->beginEditFromHost(
request.param_id);
},
[&](const YaEditControllerHostEditing::EndEditFromHost& request)
-> YaEditControllerHostEditing::EndEditFromHost::Response {
return object_instances[request.instance_id]
.edit_controller_host_editing->endEditFromHost(
request.param_id);
},
[&](const YaMidiMapping::GetMidiControllerAssignment& request)
-> YaMidiMapping::GetMidiControllerAssignment::Response {
Steinberg::Vst::ParamID id;