Use same style for optional and avoid double check

I did not know that `std::optional::value()` did checked access. And I
still prefer a more explicit .has_value() over boolean conversion, but
this seems to be the accepted way to do this.

src/common/events.h

@@ -153,8 +153,8 @@ intptr_t send_event(boost::asio::local::stream_protocol::socket& socket,
     const std::optional<EventPayload> value_payload =
         data_converter.read_value(opcode, value);
 
-    if (logging.has_value()) {
-        auto [logger, is_dispatch] = logging.value();
+    if (logging) {
+        auto [logger, is_dispatch] = *logging;
         logger.log_event(is_dispatch, opcode, index, value, payload, option,
                          value_payload);
     }
@@ -172,8 +172,8 @@ intptr_t send_event(boost::asio::local::stream_protocol::socket& socket,
         response = read_object<EventResult>(socket);
     }
 
-    if (logging.has_value()) {
-        auto [logger, is_dispatch] = logging.value();
+    if (logging) {
+        auto [logger, is_dispatch] = *logging;
         logger.log_event_response(is_dispatch, opcode, response.return_value,
                                   response.payload, response.value_payload);
     }
@@ -209,15 +209,15 @@ void receive_event(boost::asio::local::stream_protocol::socket& socket,
                    std::optional<std::pair<Logger&, bool>> logging,
                    F callback) {
     auto event = read_object<Event>(socket);
-    if (logging.has_value()) {
-        auto [logger, is_dispatch] = logging.value();
+    if (logging) {
+        auto [logger, is_dispatch] = *logging;
         logger.log_event(is_dispatch, event.opcode, event.index, event.value,
                          event.payload, event.option, event.value_payload);
     }
 
     EventResult response = callback(event);
-    if (logging.has_value()) {
-        auto [logger, is_dispatch] = logging.value();
+    if (logging) {
+        auto [logger, is_dispatch] = *logging;
         logger.log_event_response(is_dispatch, event.opcode,
                                   response.return_value, response.payload,
                                   response.value_payload);
@@ -308,9 +308,9 @@ auto passthrough_event(AEffect* plugin, F callback) {
         // data through the value argument.
         void* data = std::visit(read_payload_fn, event.payload);
         intptr_t value = event.value;
-        if (event.value_payload.has_value()) {
+        if (event.value_payload) {
             value = reinterpret_cast<intptr_t>(
-                std::visit(read_payload_fn, event.value_payload.value()));
+                std::visit(read_payload_fn, *event.value_payload));
         }
 
         const intptr_t return_value = callback(
@@ -388,9 +388,9 @@ auto passthrough_event(AEffect* plugin, F callback) {
         const EventResultPayload response_data =
             std::visit(write_payload_fn, event.payload);
         std::optional<EventResultPayload> value_response_data = std::nullopt;
-        if (event.value_payload.has_value()) {
+        if (event.value_payload) {
             value_response_data =
-                std::visit(write_payload_fn, event.value_payload.value());
+                std::visit(write_payload_fn, *event.value_payload);
         }
 
         EventResult response{return_value, response_data, value_response_data};

src/common/logging.cpp

@@ -158,8 +158,8 @@ void Logger::log_event(bool is_dispatch,
         }
 
         const auto opcode_name = opcode_to_string(is_dispatch, opcode);
-        if (opcode_name.has_value()) {
-            message << opcode_name.value();
+        if (opcode_name) {
+            message << *opcode_name;
         } else {
             message << "<opcode = " << opcode << ">";
         }
@@ -169,7 +169,7 @@ void Logger::log_event(bool is_dispatch,
 
         // Only used during `effSetSpeakerArrangement` and
         // `effGetSpeakerArrangement`
-        if (value_payload.has_value()) {
+        if (value_payload) {
             std::visit(
                 overload{
                     [&](auto) {},
@@ -177,7 +177,7 @@ void Logger::log_event(bool is_dispatch,
                         message << "<" << speaker_arrangement.speakers.size()
                                 << " input_speakers>, ";
                     }},
-                value_payload.value());
+                *value_payload);
         }
 
         std::visit(
@@ -248,7 +248,7 @@ void Logger::log_event_response(
 
         // Only used during `effSetSpeakerArrangement` and
         // `effGetSpeakerArrangement`
-        if (value_payload.has_value()) {
+        if (value_payload) {
             std::visit(
                 overload{
                     [&](auto) {},
@@ -256,7 +256,7 @@ void Logger::log_event_response(
                         message << ", <" << speaker_arrangement.speakers.size()
                                 << " input_speakers>";
                     }},
-                value_payload.value());
+                *value_payload);
         }
 
         std::visit(