vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-10 04:30:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update old comments

Browse Source
This commit is contained in:
Robbert van der Helm
2021-02-09 23:01:41 +01:00
parent c1b23b90a2
commit 2d62347393
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst3.cpp
+3 -4
View File
@@ -115,7 +115,6 @@ void Vst3Bridge::run() {
overload{ overload{
[&](const Vst3PlugViewProxy::Destruct& request) [&](const Vst3PlugViewProxy::Destruct& request)
-> Vst3PlugViewProxy::Destruct::Response { -> Vst3PlugViewProxy::Destruct::Response {
// XXX: Not sure if his has to be run form the UI thread
main_context main_context
.run_in_context<void>([&]() { .run_in_context<void>([&]() {
// When the pointer gets dropped by the host, we want to // When the pointer gets dropped by the host, we want to
@@ -847,9 +846,9 @@ void Vst3Bridge::run() {
Steinberg::owned(new Vst3HostContextProxyImpl( Steinberg::owned(new Vst3HostContextProxyImpl(
*this, std::move(request.host_context_args))); *this, std::move(request.host_context_args)));
// XXX: Should `IPlugView::{initialize,terminate}` be run from // Since plugins might want to start timers in
// the main UI thread? I can see how plugins would want to // `IPlugView::{initialize,terminate}`, we'll run these
// start timers from here. // functions from the main GUI thread
return main_context return main_context
.run_in_context<tresult>([&]() { .run_in_context<tresult>([&]() {
// This static cast is required to upcast to `FUnknown*` // This static cast is required to upcast to `FUnknown*`