From 2d62347393e557dff06f7431864d83185729d874 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Tue, 9 Feb 2021 23:01:41 +0100 Subject: [PATCH] Update old comments --- src/wine-host/bridges/vst3.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/wine-host/bridges/vst3.cpp b/src/wine-host/bridges/vst3.cpp index ba5ede37..39919373 100644 --- a/src/wine-host/bridges/vst3.cpp +++ b/src/wine-host/bridges/vst3.cpp @@ -115,7 +115,6 @@ void Vst3Bridge::run() { overload{ [&](const Vst3PlugViewProxy::Destruct& request) -> Vst3PlugViewProxy::Destruct::Response { - // XXX: Not sure if his has to be run form the UI thread main_context .run_in_context([&]() { // When the pointer gets dropped by the host, we want to @@ -847,9 +846,9 @@ void Vst3Bridge::run() { Steinberg::owned(new Vst3HostContextProxyImpl( *this, std::move(request.host_context_args))); - // XXX: Should `IPlugView::{initialize,terminate}` be run from - // the main UI thread? I can see how plugins would want to - // start timers from here. + // Since plugins might want to start timers in + // `IPlugView::{initialize,terminate}`, we'll run these + // functions from the main GUI thread return main_context .run_in_context([&]() { // This static cast is required to upcast to `FUnknown*`