mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-06-17 00:43:56 +02:00
Get rid of old fixmes related to the CID migration
This commit is contained in:
@@ -82,9 +82,6 @@ struct Ack {
|
|||||||
* Both `TUID` (`int8_t[16]`) and `FIDString` (`char*`) are hard to work with
|
* Both `TUID` (`int8_t[16]`) and `FIDString` (`char*`) are hard to work with
|
||||||
* because you can't just copy them. So when serializing/deserializing them
|
* because you can't just copy them. So when serializing/deserializing them
|
||||||
* we'll use `std::array`.
|
* we'll use `std::array`.
|
||||||
*
|
|
||||||
* FIXME: Replace usages of ArrayUID everywhere with either `WineUID` or
|
|
||||||
* `NativeUID`
|
|
||||||
*/
|
*/
|
||||||
using ArrayUID = std::array<
|
using ArrayUID = std::array<
|
||||||
std::remove_reference_t<decltype(std::declval<Steinberg::TUID>()[0])>,
|
std::remove_reference_t<decltype(std::declval<Steinberg::TUID>()[0])>,
|
||||||
|
|||||||
@@ -145,13 +145,8 @@ tresult PLUGIN_API YaPluginFactory::getClassInfo(Steinberg::int32 index,
|
|||||||
return Steinberg::kInvalidArgument;
|
return Steinberg::kInvalidArgument;
|
||||||
}
|
}
|
||||||
|
|
||||||
// FIXME: The class IDs are incorrect! See the `INLINE_UID` macro. We need
|
// We will have already converted these class IDs to the native
|
||||||
// to shuffle the byte orders around for plugins to be compatible
|
// representation in `YaPluginFactory::ConstructArgs`
|
||||||
// with projects saved under Windows and with native Linux versions
|
|
||||||
// of the same plugin. We need to do this transformation for all of
|
|
||||||
// these functions
|
|
||||||
// FIXME: We need to do similar translations everywhere where we encounter
|
|
||||||
// `ArrayUID`, such as `IComponent::getControllerClassId()`
|
|
||||||
if (arguments.class_infos_1[index]) {
|
if (arguments.class_infos_1[index]) {
|
||||||
*info = *arguments.class_infos_1[index];
|
*info = *arguments.class_infos_1[index];
|
||||||
return Steinberg::kResultOk;
|
return Steinberg::kResultOk;
|
||||||
@@ -166,6 +161,8 @@ YaPluginFactory::getClassInfo2(int32 index, Steinberg::PClassInfo2* info) {
|
|||||||
return Steinberg::kInvalidArgument;
|
return Steinberg::kInvalidArgument;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// We will have already converted these class IDs to the native
|
||||||
|
// representation in `YaPluginFactory::ConstructArgs`
|
||||||
if (arguments.class_infos_2[index]) {
|
if (arguments.class_infos_2[index]) {
|
||||||
*info = *arguments.class_infos_2[index];
|
*info = *arguments.class_infos_2[index];
|
||||||
return Steinberg::kResultOk;
|
return Steinberg::kResultOk;
|
||||||
@@ -181,6 +178,8 @@ YaPluginFactory::getClassInfoUnicode(int32 index,
|
|||||||
return Steinberg::kInvalidArgument;
|
return Steinberg::kInvalidArgument;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// We will have already converted these class IDs to the native
|
||||||
|
// representation in `YaPluginFactory::ConstructArgs`
|
||||||
if (arguments.class_infos_unicode[index]) {
|
if (arguments.class_infos_unicode[index]) {
|
||||||
*info = *arguments.class_infos_unicode[index];
|
*info = *arguments.class_infos_unicode[index];
|
||||||
return Steinberg::kResultOk;
|
return Steinberg::kResultOk;
|
||||||
|
|||||||
Reference in New Issue
Block a user