vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-07 03:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Get rid of old fixmes related to the CID migration

Browse Source
This commit is contained in:
Robbert van der Helm
2021-01-24 16:55:11 +01:00
parent 21ff906bf8
commit 19fd99b58e
2 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/serialization/vst3/base.h
-3
View File
@@ -82,9 +82,6 @@ struct Ack {
* Both `TUID` (`int8_t[16]`) and `FIDString` (`char*`) are hard to work with
* because you can't just copy them. So when serializing/deserializing them
* we'll use `std::array`.
*
* FIXME: Replace usages of ArrayUID everywhere with either `WineUID` or
* `NativeUID`
*/
using ArrayUID = std::array<
std::remove_reference_t<decltype(std::declval<Steinberg::TUID>()[0])>,
src/common/serialization/vst3/plugin-factory.cpp
+6 -7
View File
@@ -145,13 +145,8 @@ tresult PLUGIN_API YaPluginFactory::getClassInfo(Steinberg::int32 index,
return Steinberg::kInvalidArgument;
}
// FIXME: The class IDs are incorrect! See the `INLINE_UID` macro. We need
// to shuffle the byte orders around for plugins to be compatible
// with projects saved under Windows and with native Linux versions
// of the same plugin. We need to do this transformation for all of
// these functions
// FIXME: We need to do similar translations everywhere where we encounter
// `ArrayUID`, such as `IComponent::getControllerClassId()`
// We will have already converted these class IDs to the native
// representation in `YaPluginFactory::ConstructArgs`
if (arguments.class_infos_1[index]) {
*info = *arguments.class_infos_1[index];
return Steinberg::kResultOk;
@@ -166,6 +161,8 @@ YaPluginFactory::getClassInfo2(int32 index, Steinberg::PClassInfo2* info) {
return Steinberg::kInvalidArgument;
}
// We will have already converted these class IDs to the native
// representation in `YaPluginFactory::ConstructArgs`
if (arguments.class_infos_2[index]) {
*info = *arguments.class_infos_2[index];
return Steinberg::kResultOk;
@@ -181,6 +178,8 @@ YaPluginFactory::getClassInfoUnicode(int32 index,
return Steinberg::kInvalidArgument;
}
// We will have already converted these class IDs to the native
// representation in `YaPluginFactory::ConstructArgs`
if (arguments.class_infos_unicode[index]) {
*info = *arguments.class_infos_unicode[index];
return Steinberg::kResultOk;