mirror of
https://github.com/robbert-vdh/yabridge.git
synced 2026-05-06 19:40:10 +02:00
Add a todo on the VST 3.7.5 moduleinfo format
Supporting this in yabridge would require parsing JSON. So unless this feature is actually used, we should probably not bother.
This commit is contained in:
@@ -4,7 +4,9 @@ See
|
||||
[docs/architecture.md](https://github.com/robbert-vdh/yabridge/blob/master/docs/architecture.md)
|
||||
for more information on how the serialization works.
|
||||
|
||||
We currently support all official VST 3.7.3 interfaces.
|
||||
We currently support all official VST 3.7.5 interfaces minus
|
||||
`IPluginCompatibility`, as that functionality is currently not used on Linux and
|
||||
implementing it would require parsing JSON within yabridge.
|
||||
|
||||
VST3 plugin interfaces are implemented as follows:
|
||||
|
||||
|
||||
@@ -79,7 +79,7 @@ class YaPluginFactory3 : public Steinberg::IPluginFactory3 {
|
||||
* `std::nullopt` if the plugin doesn't return a class info.
|
||||
*
|
||||
* NOTE: We'll have already converted all returned class IDs to native
|
||||
* class IDs using `WienUID::to_native_uid()` for cross-platform
|
||||
* class IDs using `WineUID::to_native_uid()` for cross-platform
|
||||
* compatibility. This applies to all `class_info_*` fields here.
|
||||
*/
|
||||
std::vector<std::optional<Steinberg::PClassInfo>> class_infos_1;
|
||||
|
||||
@@ -453,6 +453,11 @@ pub fn do_sync(config: &mut Config, options: &SyncOptions) -> Result<()> {
|
||||
// screenshots and documentation
|
||||
// TODO: Also symlink presets, but this is a bit more involved. See
|
||||
// https://developer.steinberg.help/display/VST/Preset+Locations
|
||||
// TODO: Also handle `moduleinfo.json` files. That would require translating the
|
||||
// UIDs from the COM-format to the non-COM format. Yabridge currently does
|
||||
// not suport this because supporting the accompanying
|
||||
// `IPluginCompatibility` would require having to add a JSON parser to
|
||||
// yabridge just for that.
|
||||
if let Some(original_resources_dir) = module.original_resources_dir() {
|
||||
let target_resources_dir = module.target_resources_dir();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user