Files
gluetun/internal/provider/nordvpn/updater/api.go
T
Quentin McGaw 4a78989d9d chore: do not use sentinel errors when unneeded
- main reason being it's a burden to always define sentinel errors at global scope, wrap them with `%w` instead of using a string directly
- only use sentinel errors when it has to be checked using `errors.Is`
- replace all usage of these sentinel errors in `fmt.Errorf` with direct strings that were in the sentinel error
- exclude the sentinel error definition requirement from .golangci.yml
- update unit tests to use ContainersError instead of ErrorIs so it stays as a "not a change detector test" without requiring a sentinel error
2026-05-02 03:29:46 +00:00

42 lines
917 B
Go

package updater
import (
"context"
"encoding/json"
"fmt"
"net/http"
)
func fetchAPI(ctx context.Context, client *http.Client,
limit uint,
) (data serversData, err error) {
url := "https://api.nordvpn.com/v2/servers"
url += fmt.Sprintf("?limit=%d", limit) // 0 means no limit
request, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
if err != nil {
return serversData{}, err
}
response, err := client.Do(request)
if err != nil {
return serversData{}, err
}
defer response.Body.Close()
if response.StatusCode != http.StatusOK {
return serversData{}, fmt.Errorf("HTTP status code not OK: %s", response.Status)
}
decoder := json.NewDecoder(response.Body)
if err := decoder.Decode(&data); err != nil {
return serversData{}, fmt.Errorf("decoding response body: %w", err)
}
if err := response.Body.Close(); err != nil {
return serversData{}, err
}
return data, nil
}