hotfix(portforwarding): disallow setting ports when running port forwarding code

This commit is contained in:
Quentin McGaw
2026-05-23 13:20:20 +00:00
parent 46edfe49e3
commit a1ef736b0f
+5 -2
View File
@@ -2,6 +2,7 @@ package service
import ( import (
"context" "context"
"errors"
"fmt" "fmt"
"net/http" "net/http"
"slices" "slices"
@@ -59,6 +60,10 @@ func (s *Service) SetPortsForwarded(ctx context.Context, ports []uint16) (err er
s.portMutex.Lock() s.portMutex.Lock()
defer s.portMutex.Unlock() defer s.portMutex.Unlock()
if s.settings.PortForwarder != nil {
return errors.New("setting port forwarded at runtime is not supported with internally running port forwarding code")
}
slices.Sort(ports) slices.Sort(ports)
if slices.Equal(s.ports, ports) { if slices.Equal(s.ports, ports) {
return nil return nil
@@ -78,7 +83,5 @@ func (s *Service) SetPortsForwarded(ctx context.Context, ports []uint16) (err er
return fmt.Errorf("handling new ports: %w", err) return fmt.Errorf("handling new ports: %w", err)
} }
s.logger.Info("updated: " + portsToString(s.ports))
return nil return nil
} }