From a1ef736b0fe9119d33d2339430d13b0f40d4693b Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Sat, 23 May 2026 13:20:20 +0000 Subject: [PATCH] hotfix(portforwarding): disallow setting ports when running port forwarding code --- internal/portforward/service/service.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/portforward/service/service.go b/internal/portforward/service/service.go index 06d22770..2bb2777b 100644 --- a/internal/portforward/service/service.go +++ b/internal/portforward/service/service.go @@ -2,6 +2,7 @@ package service import ( "context" + "errors" "fmt" "net/http" "slices" @@ -59,6 +60,10 @@ func (s *Service) SetPortsForwarded(ctx context.Context, ports []uint16) (err er s.portMutex.Lock() defer s.portMutex.Unlock() + if s.settings.PortForwarder != nil { + return errors.New("setting port forwarded at runtime is not supported with internally running port forwarding code") + } + slices.Sort(ports) if slices.Equal(s.ports, ports) { return nil @@ -78,7 +83,5 @@ func (s *Service) SetPortsForwarded(ctx context.Context, ports []uint16) (err er return fmt.Errorf("handling new ports: %w", err) } - s.logger.Info("updated: " + portsToString(s.ports)) - return nil }