PR review feedback

Dockerfile

@@ -276,7 +276,7 @@ ENV VPN_SERVICE_PROVIDER=pia \
     PUID=1000 \
     PGID=1000
 ENTRYPOINT ["/gluetun-entrypoint"]
-EXPOSE 8000/tcp 8888/tcp 8388/tcp 8388/udp
+EXPOSE 8000/tcp 8888/tcp 8388/tcp 8388/udp 1080/tcp
 HEALTHCHECK --interval=5s --timeout=5s --start-period=10s --retries=3 CMD /gluetun-entrypoint healthcheck
 ARG TARGETPLATFORM
 RUN apk add --no-cache --update -l wget && \

cmd/gluetun/main.go

@@ -413,6 +413,7 @@ func _main(ctx context.Context, buildInfo models.BuildInformation,
 	}
 
 	socks5Loop := socks5.NewLoop(socks5.Settings{
+		Enabled:  *allSettings.Socks5.Enabled,
 		Username: *allSettings.Socks5.Username,
 		Password: *allSettings.Socks5.Password,
 		Address:  allSettings.Socks5.ListeningAddress,

internal/socks5/response.go

@@ -33,7 +33,7 @@ func (c *socksConn) encodeSuccessResponse(writer io.Writer, socksVersion byte,
 ) (err error) {
 	bindData, err := encodeBindData(bindAddrType, bindAddress, bindPort)
 	if err != nil {
-		return err
+		return fmt.Errorf("encoding bind data: %w", err)
 	}
 
 	const initialPacketLength = 3
@@ -46,7 +46,7 @@ func (c *socksConn) encodeSuccessResponse(writer io.Writer, socksVersion byte,
 
 	_, err = writer.Write(packet)
 	if err != nil {
-		c.logger.Warnf("failed writing success response: %s", err)
+		return fmt.Errorf("writing packet: %w", err)
 	}
 	return nil
 }

internal/socks5/socks5.go

@@ -218,9 +218,12 @@ func decodeRequest(reader io.Reader, expectedVersion byte) (req request, err err
 	}
 
 	version := header[0]
-	if header[0] != expectedVersion {
+	switch {
+	case version != expectedVersion:
 		return request{}, fmt.Errorf("version is not supported: expected %d and got %d",
 			expectedVersion, version)
+	case header[2] != 0:
+		return request{}, fmt.Errorf("reserved header byte must be 0 but got %d", header[2])
 	}
 
 	req.command = cmdType(header[1])