vanja/feishin
1
0
Fork 0
mirror of https://github.com/jeffvli/feishin.git synced 2026-05-07 04:20:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix memory leak on table autoscroll

Browse Source
This commit is contained in:
jeffvli
2026-01-21 00:32:48 -08:00
parent c3c18e22ea
commit b7cbb3055a
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/components/item-list/item-table-list/hooks/use-table-pane-sync.ts
+20 -3
View File
@@ -104,8 +104,9 @@ export const useTablePaneSync = ({
target: root,
});
let autoScrollCleanup: (() => void) | null = null;
if (enableDrag) {
autoScrollForElements({
autoScrollCleanup = autoScrollForElements({
canScroll: () => true,
element: viewport,
getAllowedAxis: () => 'vertical',
@@ -114,6 +115,10 @@ export const useTablePaneSync = ({
}
return () => {
if (autoScrollCleanup) {
autoScrollCleanup();
}
try {
const instance = osInstance();
const { current: root } = scrollContainerRef;
@@ -147,14 +152,21 @@ export const useTablePaneSync = ({
const viewport = root.firstElementChild as HTMLElement;
let autoScrollCleanup: (() => void) | null = null;
if (enableDrag) {
autoScrollForElements({
autoScrollCleanup = autoScrollForElements({
canScroll: () => true,
element: viewport,
getAllowedAxis: () => 'vertical',
getConfiguration: () => ({ maxScrollSpeed: 'fast' }),
});
}
return () => {
if (autoScrollCleanup) {
autoScrollCleanup();
}
};
}, [enableDrag, pinnedLeftColumnCount, pinnedLeftColumnRef]);
// Initialize overlayscrollbars for right pinned columns
@@ -176,8 +188,9 @@ export const useTablePaneSync = ({
target: root,
});
let autoScrollCleanup: (() => void) | null = null;
if (enableDrag) {
autoScrollForElements({
autoScrollCleanup = autoScrollForElements({
canScroll: () => true,
element: viewport,
getAllowedAxis: () => 'vertical',
@@ -186,6 +199,10 @@ export const useTablePaneSync = ({
}
return () => {
if (autoScrollCleanup) {
autoScrollCleanup();
}
try {
const instance = osInstanceRightPinned();
const { current: root } = pinnedRightColumnRef;