vanja/feishin
1
0
Fork 0
mirror of https://github.com/jeffvli/feishin.git synced 2026-05-10 04:30:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

remove wait for color calc on detail pages causing extra render

Browse Source
This commit is contained in:
jeffvli
2026-01-20 15:40:48 -08:00
parent c5d2c60d70
commit 9a8986834e
2 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/features/albums/routes/album-detail-route.tsx
+2 -9
View File
@@ -15,7 +15,7 @@ import {
import { LibraryContainer } from '/@/renderer/features/shared/components/library-container'; import { LibraryContainer } from '/@/renderer/features/shared/components/library-container';
import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar'; import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar';
import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary'; import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary';
import { useFastAverageColor, useWaitForColorCalculation } from '/@/renderer/hooks'; import { useFastAverageColor } from '/@/renderer/hooks';
import { useAlbumBackground, useCurrentServer } from '/@/renderer/store'; import { useAlbumBackground, useCurrentServer } from '/@/renderer/store';
import { LibraryItem } from '/@/shared/types/domain-types'; import { LibraryItem } from '/@/shared/types/domain-types';
@@ -51,14 +51,7 @@ const AlbumDetailRoute = () => {
const showBlurredImage = albumBackground; const showBlurredImage = albumBackground;
const { isReady } = useWaitForColorCalculation({ if (isColorLoading) {
hasImage: !!imageUrl,
isLoading: isColorLoading,
routeId: albumId,
showBlurredImage,
});
if (!isReady) {
return null; return null;
} }
src/renderer/features/artists/routes/album-artist-detail-route.tsx
+2 -9
View File
@@ -16,7 +16,7 @@ import {
import { LibraryContainer } from '/@/renderer/features/shared/components/library-container'; import { LibraryContainer } from '/@/renderer/features/shared/components/library-container';
import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar'; import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar';
import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary'; import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary';
import { useFastAverageColor, useWaitForColorCalculation } from '/@/renderer/hooks'; import { useFastAverageColor } from '/@/renderer/hooks';
import { useArtistBackground, useCurrentServer, useCurrentServerId } from '/@/renderer/store'; import { useArtistBackground, useCurrentServer, useCurrentServerId } from '/@/renderer/store';
import { Spinner } from '/@/shared/components/spinner/spinner'; import { Spinner } from '/@/shared/components/spinner/spinner';
import { AlbumListSort, LibraryItem, SortOrder } from '/@/shared/types/domain-types'; import { AlbumListSort, LibraryItem, SortOrder } from '/@/shared/types/domain-types';
@@ -76,14 +76,7 @@ const AlbumArtistDetailRouteContent = () => {
const showBlurredImage = artistBackground; const showBlurredImage = artistBackground;
const { isReady } = useWaitForColorCalculation({ if (isColorLoading) {
hasImage: !!selectedImageUrl,
isLoading: isColorLoading,
routeId,
showBlurredImage,
});
if (!isReady) {
return <Spinner container />; return <Spinner container />;
} }