From 9a8986834e074e23e6dab3886b7a12ee4b6f5f81 Mon Sep 17 00:00:00 2001 From: jeffvli Date: Tue, 20 Jan 2026 15:40:48 -0800 Subject: [PATCH] remove wait for color calc on detail pages causing extra render --- .../features/albums/routes/album-detail-route.tsx | 11 ++--------- .../artists/routes/album-artist-detail-route.tsx | 11 ++--------- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/renderer/features/albums/routes/album-detail-route.tsx b/src/renderer/features/albums/routes/album-detail-route.tsx index 44c2c6628..f5585511a 100644 --- a/src/renderer/features/albums/routes/album-detail-route.tsx +++ b/src/renderer/features/albums/routes/album-detail-route.tsx @@ -15,7 +15,7 @@ import { import { LibraryContainer } from '/@/renderer/features/shared/components/library-container'; import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar'; import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary'; -import { useFastAverageColor, useWaitForColorCalculation } from '/@/renderer/hooks'; +import { useFastAverageColor } from '/@/renderer/hooks'; import { useAlbumBackground, useCurrentServer } from '/@/renderer/store'; import { LibraryItem } from '/@/shared/types/domain-types'; @@ -51,14 +51,7 @@ const AlbumDetailRoute = () => { const showBlurredImage = albumBackground; - const { isReady } = useWaitForColorCalculation({ - hasImage: !!imageUrl, - isLoading: isColorLoading, - routeId: albumId, - showBlurredImage, - }); - - if (!isReady) { + if (isColorLoading) { return null; } diff --git a/src/renderer/features/artists/routes/album-artist-detail-route.tsx b/src/renderer/features/artists/routes/album-artist-detail-route.tsx index 786217aff..4f9f9911e 100644 --- a/src/renderer/features/artists/routes/album-artist-detail-route.tsx +++ b/src/renderer/features/artists/routes/album-artist-detail-route.tsx @@ -16,7 +16,7 @@ import { import { LibraryContainer } from '/@/renderer/features/shared/components/library-container'; import { LibraryHeaderBar } from '/@/renderer/features/shared/components/library-header-bar'; import { PageErrorBoundary } from '/@/renderer/features/shared/components/page-error-boundary'; -import { useFastAverageColor, useWaitForColorCalculation } from '/@/renderer/hooks'; +import { useFastAverageColor } from '/@/renderer/hooks'; import { useArtistBackground, useCurrentServer, useCurrentServerId } from '/@/renderer/store'; import { Spinner } from '/@/shared/components/spinner/spinner'; import { AlbumListSort, LibraryItem, SortOrder } from '/@/shared/types/domain-types'; @@ -76,14 +76,7 @@ const AlbumArtistDetailRouteContent = () => { const showBlurredImage = artistBackground; - const { isReady } = useWaitForColorCalculation({ - hasImage: !!selectedImageUrl, - isLoading: isColorLoading, - routeId, - showBlurredImage, - }); - - if (!isReady) { + if (isColorLoading) { return ; }