vanja/feishin
1
0
Fork 0
mirror of https://github.com/jeffvli/feishin.git synced 2026-07-21 18:06:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix row column/border styles when album group enabled

Browse Source
This commit is contained in:
jeffvli
2026-07-14 16:16:09 -07:00
parent a4306c98be
commit 8acfd3bf6d
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/components/item-list/item-table-list/columns/album-group-column.tsx
+5 -4
View File
@@ -51,9 +51,10 @@ export const AlbumGroupColumn = (props: ItemTableListInnerColumn) => {
}
if (!isFirstInGroup) {
// For non-first rows, add border-bottom on the last row of the group
const needsBorder =
props.enableHorizontalBorders &&
// No vertical border. Bottom border only on the last row of the group so
// mid-group lines don't cut through overflowing artwork.
const needsBottomBorder =
!!props.enableHorizontalBorders &&
isLastInAlbumGroup(
props.rowIndex,
props.getRowItem,
@@ -65,7 +66,7 @@ export const AlbumGroupColumn = (props: ItemTableListInnerColumn) => {
<div
style={{
...props.style,
...(needsBorder
...(needsBottomBorder
? { borderBottom: '1px solid var(--theme-colors-border)' }
: {}),
// When the cover is enlarged it overflows down from the
src/renderer/components/item-list/item-table-list/item-table-list-column.tsx
+7 -3
View File
@@ -629,7 +629,9 @@ function showHorizontalBorderFor(props: ItemTableListInnerColumn, isLastRow: boo
if (!props.enableHorizontalBorders || !props.enableHeader || props.rowIndex <= 0) {
return false;
}
if (isAlbumGroupingActive(props.columns)) {
// Album group uses group top/bottom edges only (no mid-group lines that would
// cut through artwork). Other columns keep per-row borders.
if (props.type === TableColumn.ALBUM_GROUP) {
return isLastInAlbumGroup(
props.rowIndex,
props.getRowItem,
@@ -747,7 +749,8 @@ export const TableColumnTextContainer = (
};
const showHorizontalBorder = showHorizontalBorderFor(props, isLastRow);
const showVerticalBorder = !!props.enableVerticalBorders && !isLastColumn;
const showVerticalBorder =
!!props.enableVerticalBorders && !isLastColumn && props.type !== TableColumn.ALBUM_GROUP;
const cell = (
<div
@@ -913,7 +916,8 @@ export const TableColumnContainer = (
};
const showHorizontalBorder = showHorizontalBorderFor(props, isLastRow);
const showVerticalBorder = !!props.enableVerticalBorders && !isLastColumn;
const showVerticalBorder =
!!props.enableVerticalBorders && !isLastColumn && props.type !== TableColumn.ALBUM_GROUP;
const cell = (
<div