vanja/feishin
1
0
Fork 0
mirror of https://github.com/jeffvli/feishin.git synced 2026-07-18 00:16:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Unify scrobbling behavior across subsonic servers. (#2229)

Browse Source 
Small change that modifies the `scrobble` controller method to always limit sending a
`scrobble` payload to the subsonic backend to cases where a scrobble is being submitted
or a new song is being started.

This is the current behavior for subsonic backends which support the `reportPlayback` backend
(e.g., Navidrome). This change only modifies the behavior for other backends, which would receive
`scrobble` notifications whenever a song changed for both the stopped song and the newly-started song.

After this change, all subsonic backends now only receive a `scrobble` when a new song is started or
when feishin is attempting to submit a scrobble.
This commit is contained in:
Tristen Allen
2026-07-14 14:46:08 -04:00
committed by GitHub
parent 84fb772b01
commit 8517a9f934
1 changed files with 15 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/api/subsonic/subsonic-controller.ts
+15 -26
View File
@@ -2213,24 +2213,24 @@ export const SubsonicController: InternalControllerEndpoint = {
scrobble: async (args) => {
const { apiClientProps, query } = args;
if (hasFeature(apiClientProps.server, ServerFeature.REPORT_PLAYBACK)) {
if (query.submission || query.event === 'start') {
const res = await ssApiClient(apiClientProps).scrobble({
query: {
id: query.id,
submission: query.submission,
},
});
if (query.submission || query.event === 'start') {
const res = await ssApiClient(apiClientProps).scrobble({
query: {
id: query.id,
submission: query.submission,
},
});
if (res.status !== 200) {
throw new Error('Failed to scrobble');
}
if (query.submission) {
return null;
}
if (res.status !== 200) {
throw new Error('Failed to scrobble');
}
if (query.submission) {
return null;
}
}
if (hasFeature(apiClientProps.server, ServerFeature.REPORT_PLAYBACK)) {
const defaultParams = {
ignoreScrobble: true,
mediaId: query.id,
@@ -2279,17 +2279,6 @@ export const SubsonicController: InternalControllerEndpoint = {
return null;
}
const res = await ssApiClient(apiClientProps).scrobble({
query: {
id: query.id,
submission: query.submission,
},
});
if (res.status !== 200) {
throw new Error('Failed to scrobble');
}
return null;
},
search: async (args) => {