// yabridge: a Wine plugin bridge // Copyright (C) 2020-2024 Robbert van der Helm // // This program is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // // This program is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with this program. If not, see . #include "editor.h" #include #include #include using namespace std::literals::chrono_literals; using namespace std::literals::string_literals; // A catchable alternative to `assert()`. Normally all of our `assert(!error)` // should never fail, except for when Ardour hides the editor window without // closing the editor. In those case some of our X11 function calls may r turn // errors. When this happens we want to be able to catch them in // `handle_x11_events()`. // // Since we use `std::unique_ptr` for all xcb replies, throwing won't result // in any memory leaks. #define THROW_X11_ERROR(error) \ do { \ if (error) { \ free(error); \ throw std::runtime_error("X11 error in " + \ std::string(__PRETTY_FUNCTION__)); \ } \ } while (0) /** * The Win32 timer ID we'll use to periodically call the VST2 `effeditidle` * function with. We have to do this on a timer because the function has to be * called from the GUI thread, and it should also be called while the Win32 * event loop is being blocked (for instance when a plugin opens a dropdown * menu). */ constexpr size_t idle_timer_id = 1337; /** * The X11 event mask for the host window, which in most DAWs except for Ardour * and REAPER will be the same as `parent_window_`. */ constexpr uint32_t host_event_mask = XCB_EVENT_MASK_STRUCTURE_NOTIFY | XCB_EVENT_MASK_VISIBILITY_CHANGE; /** * The X11 event mask for the parent window. We'll use this for input focus * grabbing (we'll receive the `EnterNotify` and `LeaveNotify` events for * `wrapper_window_`). We also need this structure notify here as well to detect * reparents. */ constexpr uint32_t parent_event_mask = host_event_mask | XCB_EVENT_MASK_FOCUS_CHANGE | XCB_EVENT_MASK_ENTER_WINDOW | XCB_EVENT_MASK_LEAVE_WINDOW; /** * The X11 event mask for our wrapper window. We will forward synthetic keyboard * events sent by the host to the Wine window. * * NOTE: The only reason we need this structure notify mask is because Tracktion * Waveform offsets our window a bit vertically, so we need to catch that * `ConfigureNotify` event or else the mouse clicks would be offset * slightly when the mouse is already inside of the editor window when * opening it. */ constexpr uint32_t wrapper_event_mask = XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT | XCB_EVENT_MASK_STRUCTURE_NOTIFY | XCB_EVENT_MASK_KEY_PRESS | XCB_EVENT_MASK_KEY_RELEASE; /** * The name of the X11 property on the root window used to denote the active * window in EWMH compliant window managers. */ constexpr char active_window_property_name[] = "_NET_ACTIVE_WINDOW"; /** * We'll use this property to filter windows for `host_window_`. Like `xprop` * and `xwininfo`, we'll only consider windows with this property set, although * we won't filter on whether or not the window is actually visible because it * may be minimalized when the plugin's GUI is being opened. */ constexpr char icccm_wm_state_property_name[] = "WM_STATE"; /** * This `WM_STATE` property value indicates that a window is a visible top level * window. Needs to be set on Wine's window as part of emulating the behavior of * a minimal window manager. * * Taken from the ICCCM specification: * * */ constexpr uint32_t icccm_wm_state_normal = 1; // `xdnd_aware_property_name` was moved to `editor.h` so the unity build // succeeds /** * Client message name for XEmbed messages. See * https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html. */ constexpr char xembed_message_name[] = "_XEMBED"; // Constants from the XEmbed spec constexpr uint32_t xembed_protocol_version = 0; constexpr uint32_t xembed_embedded_notify_msg = 0; constexpr uint32_t xembed_window_activate_msg = 1; constexpr uint32_t xembed_focus_in_msg = 4; constexpr uint32_t xembed_focus_first = 1; /** * The default arrow cursor used in Windows. */ static const HCURSOR arrow_cursor = LoadCursor(nullptr, IDC_ARROW); /** * Find the the ancestors for the given window. This returns a list of window * IDs that starts with `starting_at`, and then iteratively contains the parent * of the previous window in the list until we reach the root window. The * topmost window (i.e. the window closest to the root in the window stack) will * be the last window in this list. * * @param x11_connection The X11 connection to use. * @param starting_at The window we want to know the ancestor windows of. * * @return A non-empty list containing `starting_at` and all of its ancestor * windows `starting_at`. */ llvm::SmallVector find_ancestor_windows( xcb_connection_t& x11_connection, xcb_window_t starting_at); /** * Figure out which window is used by the host to embed `parent_window_` in. In * most cases this will be the same as `parent_window_`, but for instance Ardour * and REAPER will have `parent_window_` embedded inside of another window. It's * sadly not as easy as just taking the topmost window from * `find_ancestor_windows()`, as the topmost window may not be a 'normal' window * that shows up the window manager. For validity we'll simply look for * `WM_STATE` being set on the window, similar to how `xprop` and `xwininfo` * filter windows, although we won't check for mapped states. In most cases this * wouldn't matter, but REAPER (i.e. the whole reason why we need this separate * host window) doesn't pass through keyboard input for the window once the * mouse leaves the window. * * @param x11_connection The X11 connection to use. * @param starting_at The window we want to know the ancestor windows of. * @param xcb_wm_state_property The X11 atom corresponding to `WM_STATE` * * @return The host's editor window, or a nullopt if we cannot find a valid * window. */ std::optional find_host_window(xcb_connection_t& x11_connection, xcb_window_t starting_at, xcb_atom_t xcb_wm_state_property); /** * Check whether `child` is a descendant of `parent` or the same window. Used * during focus checks to only grab focus when needed. * * @param x11_connection The X11 connection to use. * @param child The potential child window. * @param parent The potential parent window. * * @return Whether `child` is a descendant of or the same window as `parent.` */ bool is_child_window_or_same(xcb_connection_t& x11_connection, xcb_window_t child, xcb_window_t parent); /** * Compute the size a window would have to be to be allowed to fullscreened on * any of the connected screens. */ Size get_maximum_screen_dimensions(xcb_connection_t& x11_connection) noexcept; /** * Get the root window for the specified window. The returned root window will * depend on the screen the window is on. */ xcb_window_t get_root_window(xcb_connection_t& x11_connection, xcb_window_t window); /** * Return the X11 window handle for the window if it's currently open. */ xcb_window_t get_x11_handle(HWND win32_handle) noexcept; /** * Return a handle to the window class used for all Win32 windows created by * yabridge. */ ATOM get_window_class() noexcept; DeferredWin32Window::DeferredWin32Window( MainContext& main_context, std::shared_ptr x11_connection, HWND window) noexcept : handle_(window), main_context_(main_context), x11_connection_(x11_connection) {} DeferredWin32Window::~DeferredWin32Window() noexcept { // NOTE: For some rason, Wine will sometimes try to delete a window twice if // the parent window no longer exists. I've only seen this cause // issues with plugins that hang when their window is hidden, like the // iZotope Rx plugins. In Renoise this would otherwise trigger an X11 // error every time you close such a plugin's editor, and in other // DAWs I've also seen it happen from time to time. try { const xcb_window_t wine_window = get_x11_handle(handle_); const xcb_window_t root_window = get_root_window(*x11_connection_, wine_window); xcb_reparent_window(x11_connection_.get(), wine_window, root_window, 0, 0); } catch (const std::runtime_error& error) { // If we can't reparent the window (or, well, fetch the root window), // then that's not a big deal here } // XXX: We are already deferring this closing by posting `WM_CLOSE` to the // message loop instead of calling `DestroyWindow()` ourselves, but we // can take it one step further. If we post this message directly then // we might still get a delay, for instance if our event loop timer // would tick exactly between `IPlugView::removed()` and // `IPlugView::~IPlugView`. Delaying this seems to be a best of both // worlds solution that works as expected in every host I've tested. try { std::shared_ptr destroy_timer = std::make_shared(main_context_.context_); destroy_timer->expires_after(1s); // Note that we capture a copy of `destroy_timer` here. This way we // don't have to manage the timer instance ourselves as it will just // clean itself up after this lambda gets called. destroy_timer->async_wait( [destroy_timer, handle = handle_, x11_connection = x11_connection_](const std::error_code& error) { if (error) { return; } // This is the flush for the reparent done above. We'll also do // this as late as possible to prevent the window from being // drawn in the meantime, as that would cause flickering. xcb_flush(x11_connection.get()); // The actual destroying will happen as part of the Win32 // message loop PostMessage(handle, WM_CLOSE, 0, 0); }); } catch (const std::bad_alloc&) { // If we can't allocate the timer, then we probably have bigger worries // than not cleaning up a window } } Editor::Editor(MainContext& main_context, const Configuration& config, Logger& logger, const size_t parent_window_handle, std::optional> timer_proc) : use_coordinate_hack_(config.editor_coordinate_hack), use_force_dnd_(config.editor_force_dnd), use_xembed_(config.editor_xembed), logger_(logger), x11_connection_(xcb_connect(nullptr, nullptr), xcb_disconnect), dnd_proxy_handle_(WineXdndProxy::get_handle()), wrapper_window_size_({128, 128}), host_window_config_({}), parent_window_config_({}), // Create a window without any decoratiosn for easy embedding. The // combination of `WS_EX_TOOLWINDOW` and `WS_POPUP` causes the window to // be drawn without any decorations (making resizes behave as you'd // expect) and also causes mouse coordinates to be relative to the window // itself. win32_window_(main_context, x11_connection_, CreateWindowEx(WS_EX_TOOLWINDOW, reinterpret_cast(get_window_class()), "yabridge plugin", WS_POPUP, 0, 0, wrapper_window_size_.width, wrapper_window_size_.height, nullptr, nullptr, GetModuleHandle(nullptr), this)), idle_timer_( Win32Timer(win32_window_.handle_, idle_timer_id, std::chrono::duration_cast( config.event_loop_interval()) .count())), idle_timer_proc_([this, timer_proc = std::move(timer_proc)]() mutable { handle_x11_events(); if (timer_proc) { (*timer_proc)(); } }), xcb_wm_state_property_( get_atom_by_name(*x11_connection_, icccm_wm_state_property_name)), parent_window_(parent_window_handle), wrapper_window_( x11_connection_, [parent_window = parent_window_, wrapper_window_size = wrapper_window_size_]( std::shared_ptr x11_connection, xcb_window_t window) { xcb_generic_error_t* error = nullptr; const xcb_query_tree_cookie_t query_cookie = xcb_query_tree(x11_connection.get(), parent_window); const std::unique_ptr query_reply( xcb_query_tree_reply(x11_connection.get(), query_cookie, &error)); THROW_X11_ERROR(error); xcb_create_window( x11_connection.get(), XCB_COPY_FROM_PARENT, window, query_reply->root, 0, 0, wrapper_window_size.width, wrapper_window_size.height, 0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr); }), wine_window_(get_x11_handle(win32_window_.handle_)), host_window_(find_host_window(*x11_connection_, parent_window_, xcb_wm_state_property_) .value_or(parent_window_)) { logger.log_editor_trace([&]() { return "DEBUG: host_window: " + std::to_string(host_window_); }); logger.log_editor_trace([&]() { return "DEBUG: parent_window: " + std::to_string(parent_window_); }); logger.log_editor_trace([&]() { return "DEBUG: wrapper_window: " + std::to_string(wrapper_window_.window_); }); logger.log_editor_trace([&]() { return "DEBUG: wine_window: " + std::to_string(wine_window_); }); // Used for input focus grabbing to only grab focus when the window is // active. In case the atom does not exist or the WM does not support this // hint, we'll print a warning and fall back to grabbing focus when the user // clicks on the window (which should trigger a `WM_PARENTNOTIFY`). active_window_property_ = get_atom_by_name(*x11_connection_, active_window_property_name); if (!supports_ewmh_active_window()) { std::cerr << "WARNING: The current window manager does not support the" << std::endl; std::cerr << " '" << active_window_property_name << "' property. Falling back to a" << std::endl; std::cerr << " less reliable keyboard input grabbing method." << std::endl; } // When using XEmbed we'll need the atoms for the corresponding properties xcb_xembed_message_ = get_atom_by_name(*x11_connection_, xembed_message_name); // When not using XEmbed, Wine will interpret any local coordinates as // global coordinates. To work around this we'll tell the Wine window it's // located at its actual coordinates on screen rather than somewhere within. // For robustness's sake this should be done both when the actual window the // Wine window is embedded in (which may not be the parent window) is moved // or resized, and when the user moves his mouse over the window because // this is sometimes needed for plugin groups. We also listen for // EnterNotify and LeaveNotify events on the Wine window so we can grab and // release input focus as necessary. And lastly we'll look out for // reparents, so we can make sure that the window does not get stolen by the // window manager and that we correctly handle the host reparenting // `parent_window_` themselves. // If we do enable XEmbed support, we'll also listen for visibility changes // and trigger the embedding when the window becomes visible xcb_change_window_attributes(x11_connection_.get(), host_window_, XCB_CW_EVENT_MASK, &host_event_mask); xcb_change_window_attributes(x11_connection_.get(), parent_window_, XCB_CW_EVENT_MASK, &parent_event_mask); xcb_change_window_attributes(x11_connection_.get(), wrapper_window_.window_, XCB_CW_EVENT_MASK, &wrapper_event_mask); xcb_flush(x11_connection_.get()); // First reparent our dumb wrapper window to the host's window, and then // embed the Wine window into our wrapper window do_reparent(wrapper_window_.window_, parent_window_); xcb_map_window(x11_connection_.get(), wrapper_window_.window_); xcb_flush(x11_connection_.get()); if (use_xembed_) { // This call alone doesn't do anything. We need to call this function a // second time on visibility change because Wine's XEmbed implementation // does not work properly (which is why we remvoed XEmbed support in the // first place). do_xembed(); } else { // Embed the Win32 window into the window provided by the host. Instead // of using the XEmbed protocol, we'll register a few events and manage // the child window ourselves. This is a hack to work around the issue's // described in `Editor`'s docstring'. do_reparent(wine_window_, wrapper_window_.window_); } } void Editor::resize(uint16_t width, uint16_t height) { logger_.log_editor_trace([&]() { return "DEBUG: Resizing wrapper window to " + std::to_string(width) + "x" + std::to_string(height); }); const uint16_t value_mask = XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT; const std::array values{width, height}; xcb_configure_window(x11_connection_.get(), wrapper_window_.window_, value_mask, values.data()); xcb_configure_window(x11_connection_.get(), wine_window_, value_mask, values.data()); xcb_flush(x11_connection_.get()); // NOTE: This lets us skip resize requests in CLAP plugins when the plugin // tries to resize to its current size. This fixes resize loops when // using the CLAP JUCE Extensions. wrapper_window_size_.width = width; wrapper_window_size_.height = height; // When the `editor_coordinate_hack` option is enabled, we will make sure // that the window is actually placed at (0, 0) coordinates. Otherwise some // plugins that rely on screen coordinates, like the Soundtoys plugins and // older PSPaudioware plugins, will draw their GUI at the wrong location // because they look at the (top level) window's screen coordinates instead // of their own relative coordinates. We don't do by default as this also // interferes with resize handles. if (use_coordinate_hack_) { logger_.log_editor_trace([]() { return "DEBUG: Resetting Wine window position back to (0, 0)"; }); SetWindowPos(win32_window_.handle_, nullptr, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOREDRAW | SWP_NOACTIVATE | SWP_NOOWNERZORDER | SWP_DEFERERASE | SWP_NOCOPYBITS); } } void Editor::show() noexcept { ShowWindow(win32_window_.handle_, SW_SHOWNORMAL); } void Editor::handle_x11_events() noexcept { // NOTE: Ardour will unmap the window instead of closing the editor. When // the window is unmapped `wine_window_` doesn't exist and any X11 // function calls involving it will fail. All functions called from // here should be able to handle that cleanly. try { std::unique_ptr generic_event; while (generic_event.reset(xcb_poll_for_event(x11_connection_.get())), generic_event != nullptr) { const uint8_t event_type = generic_event->response_type & xcb_event_type_mask; const bool is_synthetic_event = generic_event->response_type & ~xcb_event_type_mask; switch (event_type) { // NOTE: When reopening a closed editor window in REAPER, REAPER // will initialize the editor first, and only then will it // reparent `parent_window_` to a new FX window. This // means that `host_window_` will be the same as // `parent_window_` in REAPER if you reopen a plugin GUI, // which breaks our input focus handling. To work around // this, we will just check if the host's window has // changed whenever the parent window gets reparented. // REAPER does the same thing when inserting a plugin on a // new track with the `Track -> Insert virtual instrument // on new track...` option. case XCB_REPARENT_NOTIFY: { const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: ReparentNotify for window " + std::to_string(event->window) + " to new parent " + std::to_string(event->parent) + ", generated from " + std::to_string(event->event); }); redetect_host_window(); // If the `editor_force_dnd` option is set, we'll strip // `XdndAware` from all of `wine_window_`'s ancestors // (including `parent_window_`) to forcefully enable // drag-and-drop support in REAPER. See the docstring on // `Configuration::editor_force_dnd` and the option // description in the readme for more information. // NOTE: This also needs to be done here for the same reason // as the one mentioned above if (use_force_dnd_) { logger_.log_editor_trace([&]() { return "DEBUG: Removing XdndAware properties from " "window " + std::to_string(parent_window_) + " and all of its ancestors"; }); const xcb_atom_t xcb_xdnd_aware_property = get_atom_by_name(*x11_connection_, xdnd_aware_property_name); for (const xcb_window_t& window : find_ancestor_windows( *x11_connection_, parent_window_)) { xcb_delete_property(x11_connection_.get(), window, xcb_xdnd_aware_property); } } } break; // We're listening for `ConfigureNotify` events on the host's // window (i.e. the window that's actually going to get dragged // around the by the user). In most cases this is the same as // `parent_window_`. When either this window gets moved, or when // the user moves his mouse over our window, the local // coordinates should be updated. The additional `EnterWindow` // check is sometimes necessary for using multiple editor // windows within a single plugin group. case XCB_CONFIGURE_NOTIFY: { const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: ConfigureNotify for window " + std::to_string(event->window); }); // If the host window is different from the parent window // then the Wine window is at a non-zero offset from the // top-left corner. The host window will always receive // absolute position information in its events, sent from // the window manager, while the parent window might receive // position changes relative to the host window when it is a // child window. if (event->window == host_window_ && is_synthetic_event) { host_window_config_ = *event; } if (event->window == parent_window_ && host_window_ != parent_window_ && !is_synthetic_event) { parent_window_config_ = *event; } // Window managers are expected to send ConfigureNotify to // their managed windows whenever the window is being moved // or resized by the user, so that application don't have to // do all the relative positioning computation themselves. // Wine also expects this and ignores position changes on // its window parents, and its window position would get out // of sync without this event. if (event->window == host_window_ || event->window == parent_window_) { xcb_configure_notify_event_t translated_event{}; translated_event.response_type = XCB_CONFIGURE_NOTIFY; translated_event.event = wine_window_; translated_event.window = wine_window_; translated_event.width = event->width; translated_event.height = event->height; translated_event.x = host_window_config_.x + parent_window_config_.x; translated_event.y = host_window_config_.y + parent_window_config_.y; xcb_send_event( x11_connection_.get(), false, wine_window_, XCB_EVENT_MASK_STRUCTURE_NOTIFY | XCB_EVENT_MASK_SUBSTRUCTURE_NOTIFY, reinterpret_cast(&translated_event)); xcb_flush(x11_connection_.get()); } } break; // We're listening for `ConfigureRequest` events on the wrapper // window. This is received whenever Wine wants to configure its // window, and we need to adjust the configuration so that it // stays within our wrapper. Here, wwe could translate window // position changes by moving the wrapper window itself but this // isn't really necessary. Instead, we prevent Wine from // actually moving its window. case XCB_CONFIGURE_REQUEST: { const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: ConfigureRequest for window " + std::to_string(event->window); }); const uint16_t value_mask = XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y | XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT; const std::array values{0, 0, event->width, event->height}; xcb_configure_window(x11_connection_.get(), wine_window_, value_mask, values.data()); xcb_flush(x11_connection_.get()); } break; // We're listening for `MapRequest` events on the wrapper // window. This is received whenever Wine wants to map its // window, and we need to forward the request to the X server. // Wine also expects the window manager to change the WM_STATE // property whenever it has finished mapping the window. We // effectively implement a sub window manager here, so update // the property as we should. case XCB_MAP_REQUEST: { const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: MapRequest for window " + std::to_string(event->window); }); xcb_map_window(x11_connection_.get(), wine_window_); const std::array values{icccm_wm_state_normal, 0}; xcb_change_property( x11_connection_.get(), XCB_PROP_MODE_REPLACE, wine_window_, xcb_wm_state_property_, xcb_wm_state_property_, 32, 2, values.data()); xcb_flush(x11_connection_.get()); } break; // Start the XEmbed procedure when the window becomes visible, // since most hosts will only show the window after the plugin // has embedded itself into it. case XCB_VISIBILITY_NOTIFY: { const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: VisibilityNotify for window " + std::to_string(event->window); }); if (event->window == host_window_ || event->window == parent_window_) { if (use_xembed_) { do_xembed(); } } } break; // We want to grab keyboard input focus when the user hovers // over our embedded Wine window AND that window is a child of // the currently active window. This ensures that the behavior // is similar to what you'd expect of a native application, // without grabbing input focus when accidentally hovering over // a yabridge window in the background. The `FocusIn` is needed // for when returning to the main plugin window after closing a // dialog, since that often won't trigger an `EnterNotify'. case XCB_ENTER_NOTIFY: case XCB_FOCUS_IN: { const xcb_window_t window = event_type == XCB_ENTER_NOTIFY ? reinterpret_cast( generic_event.get()) ->child : reinterpret_cast( generic_event.get()) ->event; logger_.log_editor_trace([&]() { return "DEBUG: "s + (event_type == XCB_ENTER_NOTIFY ? "EnterNotify" : "FocusIn") + " for window " + std::to_string(window) + " (wine window " + (is_wine_window_active() ? "active" : "inactive") + ")"; }); if (window == parent_window_ || window == wrapper_window_.window_) { // In case the WM somehow does not support // `_NET_ACTIVE_WINDOW`, a more naive focus grabbing // method implemented in the `WM_PARENTNOTIFY` handler // will be used. if (supports_ewmh_active_window() && is_wine_window_active()) { set_input_focus(true); } } } break; // When the user moves their mouse away from the Wine window // _while the window provided by the host it is contained in is // still active_, we will give back keyboard focus to that // window. This for instance allows you to still use the search // bar in REAPER's FX window. This distinction is important, // because we do not want to mess with keyboard focus when // hovering over the window while for instance a dialog is open. case XCB_LEAVE_NOTIFY: { const auto event = reinterpret_cast( generic_event.get()); // HACK: We need to do a `WindowFromPoint()` query inside of // `is_cursor_in_wine_window()`, and // `GetCursorPos()`'s value only updates once every // 100 milliseconds: // https://github.com/wine-mirror/wine/blob/25271032dfb3f126a8b0dff2adb9b96a7d09241d/dlls/user32/input.c#L345 // // To avoid this, we will use the X11 cursor position. // For this to work we will need to translate X11 root // window coordinates into Wine virtual screen // coordinates, like so: // https://github.com/wine-mirror/wine/tree/25271032dfb3f126a8b0dff2adb9b96a7d09241d/dlls/winex11.drv/display.c // // This function is sadly not exposed, so instead we // will get the root window cursor position, and then // add to that the difference between `wine_window_`'s // root-relative X11 position and its Win32 position. // The alternative is sleeping for 100 milliseconds, // but this is faster. const std::optional windows_pointer_pos = get_current_pointer_position(); logger_.log_editor_trace([&]() { std::ostringstream message; message << "DEBUG: LeaveNotify for window " << event->child; message << " (wine window " << (is_wine_window_active() ? "active" : "inactive"); message << ", detail: " << static_cast(event->detail); message << ", pointer pos: "; if (windows_pointer_pos) { message << windows_pointer_pos->x << ", " << windows_pointer_pos->y; } else { message << ""; } message << ", pointer " << (is_cursor_in_wine_window(windows_pointer_pos) ? "is" : "is not") << " in Wine window)"; return message.str(); }); // This extra check for the `NonlinearVirtual` detail is // important (see // https://www.x.org/releases/X11R7.5/doc/x11proto/proto.html // for more information on what this actually means). I've // only seen this issue with the Tokyo Dawn Records plugins, // but a plugin may create a popup window that acts as a // dropdown without actually activating that window (unlike // with an actual Win32 dropdown menu). Without this check // these fake dropdowns would immediately close when // hovering over them. if (event->child == wrapper_window_.window_ && supports_ewmh_active_window() && is_wine_window_active() && !is_cursor_in_wine_window(windows_pointer_pos)) { set_input_focus(false); } } break; // We need to forward synthetic keyboard events sent by the host // from the wrapper window to the Wine window // NOTE: We're _only_ forwarding synthetic events sent by the // host. Wine can listen for regular keyboard events on // its own, so we won't forward those. Bitwig Studio uses // this approach to still allow you to press Space to // control the transport. case XCB_KEY_PRESS: case XCB_KEY_RELEASE: { static_assert(std::is_same_v); const auto event = reinterpret_cast( generic_event.get()); logger_.log_editor_trace([&]() { return "DEBUG: "s + (is_synthetic_event ? "synthetic " : "") + (event_type == XCB_KEY_PRESS ? "KeyPress" : "KeyRelease") + " for window " + std::to_string(event->event) + " with key code " + std::to_string(event->detail); }); if (is_synthetic_event && event->event == wrapper_window_.window_) { const uint32_t event_mask = event_type == XCB_KEY_PRESS ? XCB_EVENT_MASK_KEY_PRESS : XCB_EVENT_MASK_KEY_RELEASE; // We will reset the `response_type`, because the X11 // server will have already set the first bit for us to // indicate that it's a synthetic event. Most likely not // needed, but it feels like the right thing to do. All // other fields can stay the same. event->response_type = event_type; event->event = wine_window_; xcb_send_event(x11_connection_.get(), true, wine_window_, event_mask, reinterpret_cast(event)); xcb_flush(x11_connection_.get()); } } break; default: { logger_.log_editor_trace([&]() { return "DEBUG: Unhandled X11 event " + std::to_string(event_type); }); } } } } catch (const std::runtime_error& error) { std::cerr << "Error occurred while handling X11 events, continuing: " << error.what() << std::endl; } } HWND Editor::win32_handle() const noexcept { return win32_window_.handle_; } void Editor::set_input_focus(bool grab) const { // NOTE: When grabbing focus, you can hold down the shift key to focus the // Wine window directly. This allows you to use the space key in // plugin GUIs in Bitwig when necessary (e.g. for naming presets) but // still allow space to pause/resume the transport when it's not // needed. It's also needed for dialogs in Voxengo plugins to function // properly, as they don't grab input focus themselves. const xcb_window_t focus_target = grab ? (get_active_modifiers().value_or(0) & XCB_MOD_MASK_SHIFT ? wine_window_ : parent_window_) : host_window_; xcb_generic_error_t* error = nullptr; const xcb_get_input_focus_cookie_t focus_cookie = xcb_get_input_focus(x11_connection_.get()); const std::unique_ptr focus_reply( xcb_get_input_focus_reply(x11_connection_.get(), focus_cookie, &error)); THROW_X11_ERROR(error); // Calling `set_input_focus(true)` can trigger another `FocusIn` event, // which will then once again call `set_input_focus(true)`. To work around // this we prevent unnecessary repeat keyboard focus grabs. One thing that // slightly complicates this is the use of unmapped input proxy windows. // When `host_window_` gets foccused, some hosts will reassign input focus // to such a proxy window. To avoid fighting over focus, when grabbing focus // we don't just check whether `current_focus` and `focus_target` are the // same window but we'll also allow `current_focus` to be a child of // `focus_target`. // NOTE: To make matters even more complicated, the focused window can also // be `None` or `PoointerRoot`. In a normal Xorg setup this will never // happen, but apparently Crostini does some strange things and it can // happen there. Since those flags aren't valid windows, we must avoid // calling `is_child_window_or_same()` in those cases. // https://github.com/robbert-vdh/yabridge/issues/167 const xcb_window_t current_focus = focus_reply->focus; if (current_focus == focus_target || (grab && current_focus != XCB_INPUT_FOCUS_NONE && current_focus != XCB_INPUT_FOCUS_POINTER_ROOT && is_child_window_or_same(*x11_connection_, current_focus, focus_target))) { logger_.log_editor_trace([&]() { std::string reason = "unknown reason"; if (current_focus == focus_target) { reason = "already focused"; } else if (grab && is_child_window_or_same(*x11_connection_, current_focus, focus_target)) { reason = "current focus " + std::to_string(current_focus) + " is a child of " + std::to_string(focus_target); } return "DEBUG: Not grabbing input focus for window " + std::to_string(focus_target) + "(" + reason + ")"; }); return; } // Explicitly request input focus when the user interacts with the window. // Without this, `host_window_` will capture all keyboard events in most // hosts. Ideally we would just do this whenever the child window calls // `SetFocus()` (or no handling should be necessary), but as far as I'm // aware there is no way to do this. Right now we will grab input focus when // the user hovers over the Wine window while the window it is contained in // (the one provided by the host) is active. Keyboard focus will be given // back to that window when the user moves their mouse outside of the Wine // window while the host's window is still active (that's an important // detail, since plugins may have dialogs). // XXX: In theory we wouldn't have to do this for VST3 because // `IPlugView::onKey{Down,Up}` should handle all keyboard events. But // in practice a lot of hosts don't use that, so we still need to grab // focus ourselves. logger_.log_editor_trace([&]() { return "DEBUG: Setting input focus to window " + std::to_string(focus_target); }); xcb_set_input_focus(x11_connection_.get(), XCB_INPUT_FOCUS_PARENT, focus_target, XCB_CURRENT_TIME); xcb_flush(x11_connection_.get()); } void Editor::run_timer_proc() { idle_timer_proc_(); } std::optional Editor::get_active_modifiers() const noexcept { xcb_generic_error_t* error = nullptr; const xcb_query_pointer_cookie_t query_pointer_cookie = xcb_query_pointer(x11_connection_.get(), wine_window_); const std::unique_ptr query_pointer_reply( xcb_query_pointer_reply(x11_connection_.get(), query_pointer_cookie, &error)); if (error) { free(error); return std::nullopt; } logger_.log_editor_trace([&]() { return "DEBUG: Active keyboard modifiers: " + std::to_string(query_pointer_reply->mask); }); return query_pointer_reply->mask; } std::optional Editor::get_current_pointer_position() const noexcept { xcb_generic_error_t* error = nullptr; const xcb_query_pointer_cookie_t query_pointer_cookie = xcb_query_pointer(x11_connection_.get(), wine_window_); const std::unique_ptr query_pointer_reply( xcb_query_pointer_reply(x11_connection_.get(), query_pointer_cookie, &error)); if (error) { free(error); return std::nullopt; } // We know the mouse coordinates relative to the root window, and we know // the mouse coordinates relative to `wine_window_`, so we can skip a // request by calculating Wine window's coordinates ourself. const uint16_t x11_x_pos = query_pointer_reply->root_x - query_pointer_reply->win_x; const uint16_t x11_y_pos = query_pointer_reply->root_y - query_pointer_reply->win_y; // We need to offset the root-relative pointer position with the difference // between `wine_window_`'s X11 and Win32 coordinates. Wine sadly does not // expose a function that just lets us translate X11 coordinates into // Windows coordinates. RECT win32_pos{}; if (!GetWindowRect(win32_window_.handle_, &win32_pos)) { return std::nullopt; } return POINT{ .x = query_pointer_reply->root_x + (win32_pos.left - x11_x_pos), .y = query_pointer_reply->root_y + (win32_pos.top - x11_y_pos)}; } bool Editor::is_wine_window_active() const { if (!supports_ewmh_active_window()) { return false; } // We will only grab focus when the Wine window is active. To do this we'll // read the `_NET_ACTIVE_WINDOW` property from the root window (which can // change when the window gets moved to another screen, so we won't cache // this). const xcb_window_t root_window = get_root_window(*x11_connection_, wine_window_); xcb_generic_error_t* error = nullptr; const xcb_get_property_cookie_t property_cookie = xcb_get_property(x11_connection_.get(), false, root_window, active_window_property_, XCB_ATOM_WINDOW, 0, 1); const std::unique_ptr property_reply( xcb_get_property_reply(x11_connection_.get(), property_cookie, &error)); THROW_X11_ERROR(error); const xcb_window_t active_window = *static_cast( xcb_get_property_value(property_reply.get())); return is_child_window_or_same(*x11_connection_, wine_window_, active_window); } void Editor::redetect_host_window() noexcept { const xcb_window_t new_host_window = find_host_window(*x11_connection_, parent_window_, xcb_wm_state_property_) .value_or(parent_window_); if (new_host_window == host_window_) { return; } logger_.log_editor_trace([&]() { return "DEBUG: new host_window: " + std::to_string(new_host_window); }); // We need to readjust the event masks for the new host window, keeping the // (very probable) possibility in mind that the old host window is the same // as the parent window or that the parent window now is the host window. if (host_window_ != parent_window_) { constexpr uint32_t no_event_mask = XCB_EVENT_MASK_NO_EVENT; xcb_change_window_attributes(x11_connection_.get(), host_window_, XCB_CW_EVENT_MASK, &no_event_mask); } if (new_host_window == parent_window_) { xcb_change_window_attributes(x11_connection_.get(), new_host_window, XCB_CW_EVENT_MASK, &parent_event_mask); } else { xcb_change_window_attributes(x11_connection_.get(), new_host_window, XCB_CW_EVENT_MASK, &host_event_mask); } host_window_ = new_host_window; xcb_flush(x11_connection_.get()); } bool Editor::supports_ewmh_active_window() const { if (supports_ewmh_active_window_cache_) { return *supports_ewmh_active_window_cache_; } // It could be that the `_NET_ACTIVE_WINDOW` atom exists (because it was // created by another application) but that the root window does not have // the property if (active_window_property_ == XCB_ATOM_NONE) { supports_ewmh_active_window_cache_ = false; return false; } const xcb_window_t root_window = get_root_window(*x11_connection_, wine_window_); // If the `_NET_ACTIVE_WINDOW` property does not exist on the root window, // the returned property type will be `XCB_ATOM_NONE` as specified in the // X11 manual xcb_generic_error_t* error = nullptr; const xcb_get_property_cookie_t property_cookie = xcb_get_property(x11_connection_.get(), false, root_window, active_window_property_, XCB_ATOM_WINDOW, 0, 1); const std::unique_ptr property_reply( xcb_get_property_reply(x11_connection_.get(), property_cookie, &error)); THROW_X11_ERROR(error); const bool active_window_property_exists = property_reply->type != XCB_ATOM_NONE; supports_ewmh_active_window_cache_ = active_window_property_exists; return active_window_property_exists; } // NOLINTNEXTLINE(bugprone-easily-swappable-parameters) void Editor::send_xembed_message(xcb_window_t window, uint32_t message, uint32_t detail, uint32_t data1, uint32_t data2) const noexcept { xcb_client_message_event_t event{}; event.response_type = XCB_CLIENT_MESSAGE; event.type = xcb_xembed_message_; event.window = window; event.format = 32; event.data.data32[0] = XCB_CURRENT_TIME; event.data.data32[1] = message; event.data.data32[2] = detail; event.data.data32[3] = data1; event.data.data32[4] = data2; xcb_send_event(x11_connection_.get(), false, window, XCB_EVENT_MASK_NO_EVENT, reinterpret_cast(&event)); } void Editor::do_reparent(xcb_window_t child, xcb_window_t new_parent) const { const xcb_void_cookie_t reparent_cookie = xcb_reparent_window_checked( x11_connection_.get(), child, new_parent, 0, 0); if (std::unique_ptr reparent_error( xcb_request_check(x11_connection_.get(), reparent_cookie)); reparent_error) { // When the reparent fails, we always want to log this, regardless of // whether or not `YABRIDGE_DEBUG_LEVEL` contains `+editor` std::cerr << "DEBUG: Reparenting " << child << " to " << new_parent << " failed:" << std::endl; std::cerr << "Error code: " << static_cast(reparent_error->error_code) << std::endl; std::cerr << "Major code: " << static_cast(reparent_error->major_code) << std::endl; std::cerr << "Minor code: " << static_cast(reparent_error->minor_code) << std::endl; // Let's just check all of the reasons why the reparent could // fail according to the spec in advance xcb_generic_error_t* error = nullptr; const xcb_query_pointer_cookie_t query_pointer_cookie = xcb_query_pointer(x11_connection_.get(), child); const std::unique_ptr query_pointer_reply( xcb_query_pointer_reply(x11_connection_.get(), query_pointer_cookie, &error)); if (error) { free(error); std::cerr << "DEBUG: Could not query pointer location" << std::endl; } else { if (query_pointer_reply->same_screen) { std::cerr << "DEBUG: Pointer is on the same screen as the " "Wine window, good" << std::endl; } else { std::cerr << "DEBUG: Pointer is not on the same screen as " "the Wine window, oh no" << std::endl; } } } else { logger_.log_editor_trace([&]() { return "DEBUG: Reparenting " + std::to_string(child) + " to " + std::to_string(new_parent) + " succeeded"; }); } xcb_flush(x11_connection_.get()); } void Editor::do_xembed() const { if (!use_xembed_) { return; } // If we're embedding using XEmbed, then we'll have to go through the whole // XEmbed dance here. See the spec for more information on how this works: // https://specifications.freedesktop.org/xembed-spec/xembed-spec-latest.html#lifecycle do_reparent(wine_window_, wrapper_window_.window_); // Let the Wine window know it's being embedded into the parent window send_xembed_message(wine_window_, xembed_embedded_notify_msg, 0, wrapper_window_.window_, xembed_protocol_version); send_xembed_message(wine_window_, xembed_focus_in_msg, xembed_focus_first, 0, 0); send_xembed_message(wine_window_, xembed_window_activate_msg, 0, 0, 0); xcb_flush(x11_connection_.get()); xcb_map_window(x11_connection_.get(), wine_window_); xcb_flush(x11_connection_.get()); } LRESULT CALLBACK window_proc(HWND handle, UINT message, WPARAM wParam, LPARAM lParam) { switch (message) { case WM_CREATE: { const auto window_parameters = reinterpret_cast(lParam); const auto editor = static_cast(window_parameters->lpCreateParams); if (!editor) { break; } // Sent when the window is first being created. `lParam` here // contains the last argument of `CreateWindowEx`, which was a // pointer to the `Editor` object. We need to attach this to the // window handle so we can access our VST plugin instance later. SetWindowLongPtr( handle, GWLP_USERDATA, static_cast(reinterpret_cast(editor))); } break; case WM_TIMER: { auto editor = reinterpret_cast( GetWindowLongPtr(handle, GWLP_USERDATA)); if (!editor || wParam != idle_timer_id) { break; } // We'll send idle messages on a timer for VST2 plugins. This way // the plugin will get keep periodically updating its editor either // when the host sends `effEditIdle` themself, or periodically when // the GUI is being blocked by a dropdown or a message box. editor->run_timer_proc(); return 0; } break; // In case the WM does not support the EWMH active window property, // we'll fall back to grabbing focus when the user clicks on the window // by listening to the generated `WM_PARENTNOTIFY` messages. Otherwise // we have some more sophisticated behaviour using `EnterNotify` and // `LeaveNotify` X11 events. This will only be necessary for very // barebones window managers. case WM_PARENTNOTIFY: { auto editor = reinterpret_cast( GetWindowLongPtr(handle, GWLP_USERDATA)); if (!editor || editor->supports_ewmh_active_window()) { break; } editor->set_input_focus(true); } break; // HACK: JUCE (spuriously?) causes the cursor to be set to an empty // cursor from time to time while interacting with the plugins. // And Anaglyph seems to always hide the cursor when interacting // with the GUI while the transport is running. As a simple // workaround, we can just reset the cursor back to the default // arrow when this happens. Plugins that hide the cursor while // dragging a knob seem to still work fine despite this (based on // TDR, Voxengo, and KiloHearts plugins). If at some point a // plugin _does_ legitimately need to hide the cursor, we can // always add a `yabridge.toml` compatibilty option just for those // plugin and keep this as a default. case WM_SETCURSOR: { if (GetCursor() == nullptr) { SetCursor(arrow_cursor); } } break; // NOTE: Needed for our `is_cursor_in_wine_window()` implementation. Our // `win32_window_` extends way past the visible plugin GUI. And // even though it will appear nicely clipped on screen, // `WindowFromPoint()` would still return our window when hovering // to the right or bottom of a plugin GUI, even if there's another // window right behind it. To make sure we can detect other Wine // windows in that region, we need to make sure that // `WindowFromPoint()` doesn't consider the parent window (it's // not going to be relevant anyways). In practice this will still // mean that the function returns our parent window if it's the // only window on that coordinate. case WM_NCHITTEST: { return HTNOWHERE; } break; } return DefWindowProc(handle, message, wParam, lParam); } llvm::SmallVector find_ancestor_windows( xcb_connection_t& x11_connection, xcb_window_t starting_at) { xcb_window_t current_window = starting_at; xcb_generic_error_t* error = nullptr; xcb_query_tree_cookie_t query_cookie = xcb_query_tree(&x11_connection, starting_at); std::unique_ptr query_reply( xcb_query_tree_reply(&x11_connection, query_cookie, &error)); THROW_X11_ERROR(error); const xcb_window_t root = query_reply->root; llvm::SmallVector ancestor_windows{current_window}; while (query_reply->parent != root) { current_window = query_reply->parent; ancestor_windows.push_back(current_window); query_cookie = xcb_query_tree(&x11_connection, current_window); query_reply.reset( xcb_query_tree_reply(&x11_connection, query_cookie, &error)); THROW_X11_ERROR(error); } return ancestor_windows; } std::optional find_host_window( xcb_connection_t& x11_connection, // NOLINTNEXTLINE(bugprone-easily-swappable-parameters) xcb_window_t starting_at, xcb_atom_t xcb_wm_state_property) { // See the docstring for why this works the way it does const auto ancestors = find_ancestor_windows(x11_connection, starting_at); for (auto window = ancestors.rbegin(); window != ancestors.rend(); window++) { xcb_generic_error_t* error = nullptr; const xcb_get_property_cookie_t property_cookie = xcb_get_property(&x11_connection, false, *window, xcb_wm_state_property, XCB_ATOM_WINDOW, 0, 1); const std::unique_ptr property_reply( xcb_get_property_reply(&x11_connection, property_cookie, &error)); if (error) { free(error); continue; } if (property_reply->type != XCB_NONE) { return *window; } } return std::nullopt; } bool is_child_window_or_same( xcb_connection_t& x11_connection, // NOLINTNEXTLINE(bugprone-easily-swappable-parameters) xcb_window_t child, xcb_window_t parent) { xcb_generic_error_t* error = nullptr; xcb_query_tree_cookie_t query_cookie = xcb_query_tree(&x11_connection, child); std::unique_ptr query_reply( xcb_query_tree_reply(&x11_connection, query_cookie, &error)); THROW_X11_ERROR(error); xcb_window_t current_window = child; while (query_reply->parent != XCB_NONE) { if (current_window == parent) { return true; } current_window = query_reply->parent; query_cookie = xcb_query_tree(&x11_connection, current_window); query_reply.reset( xcb_query_tree_reply(&x11_connection, query_cookie, &error)); THROW_X11_ERROR(error); } return false; } xcb_atom_t get_atom_by_name(xcb_connection_t& x11_connection, const char* atom_name) { xcb_generic_error_t* error = nullptr; xcb_intern_atom_cookie_t atom_cookie = xcb_intern_atom(&x11_connection, true, strlen(atom_name), atom_name); std::unique_ptr atom_reply( xcb_intern_atom_reply(&x11_connection, atom_cookie, &error)); THROW_X11_ERROR(error); return atom_reply->atom; } Size get_maximum_screen_dimensions(xcb_connection_t& x11_connection) noexcept { xcb_screen_iterator_t iter = xcb_setup_roots_iterator(xcb_get_setup(&x11_connection)); // Find the maximum dimensions the window would have to be to be able to be // fullscreened on any screen, disregarding the possibility that someone // would try to stretch the window accross all displays (because who would // do such a thing?) Size maximum_screen_size{}; while (iter.rem > 0) { maximum_screen_size.width = std::max(maximum_screen_size.width, iter.data->width_in_pixels); maximum_screen_size.height = std::max(maximum_screen_size.height, iter.data->height_in_pixels); xcb_screen_next(&iter); } return maximum_screen_size; } xcb_window_t get_root_window(xcb_connection_t& x11_connection, xcb_window_t window) { xcb_generic_error_t* error = nullptr; const xcb_query_tree_cookie_t query_cookie = xcb_query_tree(&x11_connection, window); const std::unique_ptr query_reply( xcb_query_tree_reply(&x11_connection, query_cookie, &error)); THROW_X11_ERROR(error); return query_reply->root; } xcb_window_t get_x11_handle(HWND win32_handle) noexcept { return reinterpret_cast( GetProp(win32_handle, "__wine_x11_whole_window")); } ATOM get_window_class() noexcept { // Lazily iniitialize our window class static ATOM window_class_handle = 0; if (!window_class_handle) { WNDCLASSEX window_class{}; // XXX: We could also add a background here. This would get rid of any // artifacts on hosts that don't resize the window properly (e.g. // REAPER with VST2 plugins), but it can also cause that background // to briefly become visible on a call to `fix_local_coordinates()` // which can look very jarring. window_class.cbSize = sizeof(WNDCLASSEX); window_class.style = CS_DBLCLKS; window_class.lpfnWndProc = window_proc; window_class.hInstance = GetModuleHandle(nullptr); window_class.hCursor = arrow_cursor; window_class.lpszClassName = yabridge_window_class_name; window_class_handle = RegisterClassEx(&window_class); } return window_class_handle; } bool is_cursor_in_wine_window( std::optional windows_pointer_pos) noexcept { static const HWND windows_desktop_window = GetDesktopWindow(); if (!windows_pointer_pos) { windows_pointer_pos.emplace(); GetCursorPos(&*windows_pointer_pos); } if (HWND windows_window = WindowFromPoint(*windows_pointer_pos); windows_window && windows_window != windows_desktop_window) { // NOTE: Because resizing reparented Wine windows without XEmbed is a // bit janky, yabridge creates windows with client areas large // enough to fit the entire screen, and the plugin then embeds its // own GUI in a portion of that. The result is that // `WindowFromPoint()` will still return that same huge window // when we hover over an area to the right or to the bottom of a // plugin GUI. We can easily detect by just checking the window // class name. Also check out the `WM_NCHITTEST` implementation in // the message loop above. std::array window_class_name{0}; GetClassName(windows_window, window_class_name.data(), window_class_name.size()); if (strcmp(window_class_name.data(), yabridge_window_class_name) != 0) { return true; } } return false; } #undef THROW_X11_ERROR