e5187db9ef
Mark 32-bit yabridge libraries
...
So we're able to immediately spot that someone is using them from the
logs.
2021-06-24 13:48:23 +02:00
94b3c92432
Get rid of pointer size checks
...
To allow cross-compiling 32-bit libraries.
2021-06-24 13:17:15 +02:00
3b06634e33
Escape HTML in desktop notification messages
2021-06-23 17:23:45 +02:00
553b4474a7
Respect $XDG_DATA_HOME when looking for binaries
...
Since we're using the XDG base dir package in yabridgectl we were
already doing this there, so it makes sense to also do this in yabridge
itself even though it's very unlikely the user will have this set.
2021-06-23 01:53:18 +02:00
15e271f70a
Fix unity builds after reintroduction of vfork
...
Boost.Process was being included before this flag was set. Seems safer
to set it in the build anyways.
2021-06-22 19:00:21 +02:00
a3d34f8197
Use vfork() for quick running commands
...
We can't use it for the Wine plugin host process, but it's perfectly
suitable for these things.
2021-06-22 18:38:49 +02:00
418cd7b381
Switch to normal urgency desktop notifications
...
These critical notifications don't expire under KDE Plasma, which would
mean that you'd get absolutely flooded with notifications you have to
manually close when something is wrong.
2021-06-22 18:10:44 +02:00
75cfc8eaac
Fix new watchdog timer environment check
...
This would of course cause a segfault if the environment variable isn't
defined. The regression was introduced in
8873c11e1d
2021-06-22 18:06:04 +02:00
4ab61a77b7
Compare to string view constant instead of string
...
These are constexpr, so hopefully the compiler can be a bit smarter
about it.
2021-06-22 17:42:37 +02:00
5ffe4773e9
Show startup errors in a desktop notification
...
This should make it much easier to spot what goes wrong if you're new to
yabridge and don't know where to look yet.
2021-06-22 17:41:08 +02:00
8873c11e1d
Move watchdog timer disable check to common/utils
...
We may also want to check this from the plugin.
2021-06-22 17:15:47 +02:00
333707255e
Add missing noexcept specifier
2021-06-22 17:15:47 +02:00
c2b8626ec5
Rearrange declarations to match implementations
2021-06-22 17:15:47 +02:00
780d562909
Fix plugin host watchdog treating zombies as alive
2021-06-22 17:15:47 +02:00
0156b61e64
Show notification when plugin host fails to start
...
This one's a bit generic since the relevant output from the Wine process
will have already been printed to the logger before this point.
2021-06-22 17:13:30 +02:00
437a4dc5ec
Add a function for sending desktop notifications
2021-06-22 17:12:31 +02:00
98c4cc170e
Actually use the correct environment
2021-06-21 13:06:26 +02:00
466fe3abcf
Run $WINELOADER --version under the correct env
...
This makes the initialization message reflect the correct Wine version
when using a `WINELOADER` script to change between Wine versions
depending on the Wine prefix.
2021-06-21 13:00:05 +02:00
4c009cb670
Add an environment variable for disabling watchdog
...
This should only be used when running the Wine process under a separate
namespace.
2021-06-16 01:28:59 +02:00
4d58adb83f
Prevent against environment modifications
...
Should not be necessary here, but better safe than sorry.
2021-06-16 01:11:36 +02:00
efeb8d7348
Rearrange editor functions
2021-06-15 11:00:22 +02:00
42e1e49ab9
Remove debug prints
2021-06-13 00:27:24 +02:00
736b223af8
Set the audioMasterGetTime flags
...
Apparently this is a thing, and Ardour is the only DAW that respects
them.
2021-06-12 20:36:22 +02:00
8a754b08cf
Only initialize VST2 audio buffers on activation
...
Ardour apparently always calls `effMainsChanged()` with a value argument
of 0 when unloading the plugin, regardless of whether it has actually
initialized audio processing before that point.
2021-06-12 20:15:20 +02:00
67e754feb5
Make the maximum block size in VST2 optional
2021-06-12 20:05:39 +02:00
71cb421032
Reformat the REAPER host functions warning
...
So it's a bit nicer to look at.
2021-06-12 17:31:15 +02:00
9c439b62e3
Ignore REAPER host function API requests
...
Apparently there is a plugin that uses these.
2021-06-12 17:22:47 +02:00
14ee304256
Silence spurious maybe unused errors
...
These only show up during unity builds, and they originate from
Boost.Container's small vector. The compiler's diagnostic also doesn't
make any sense here so it's probably just a weird GCC thing.
2021-06-12 00:35:59 +02:00
75dee9991c
Don't ignore read/write results
...
For some reason this only issues warnings on the CI.
2021-06-12 00:02:22 +02:00
b4e0941473
Don't cache reconstructed VST3 events at all
...
There's no need to since reconstructing the event is very cheap, and
this should be faster (less memory used) and also less error prone
anyways.
2021-06-11 18:18:13 +02:00
fe29def33f
Clear reconstructed VST3 events on deserialization
...
This fixes a regression from 964c150158
2021-06-11 18:13:22 +02:00
9c30d64975
Fix speaker arrangement bitsets
...
The sizes were wrong, and Blue Cat Audio's VST3 plugins seem to use the
upper bits to store the channel configuration, which thus got read out
incorrectly.
2021-06-11 17:22:46 +02:00
78f6921cd8
Also use hashsets for the VST2 opcode dispatch
...
Should barely make a difference, but it should be as fast or faster.
2021-06-11 14:57:01 +02:00
aaf3e7438c
Use unordered maps for VST3 plugin instances
...
The better algorithmic time complexity should help when using many (say,
hundreds) of instances of a single VST3 plugin.
2021-06-11 14:48:28 +02:00
dec19dc12a
💥 Reimplement VST3 audio processing
...
In the same way as 50c25c1cf0
2021-06-11 13:59:37 +02:00
a7d8063db4
Add getters for channel counts in audio buffers
2021-06-11 13:38:29 +02:00
340d376564
Add constant overloads for audio buffer pointers
2021-06-11 12:58:46 +02:00
964c150158
Use the in new place optional extension
2021-06-10 23:44:47 +02:00
f5214b7686
Add an in place std::optional bitsery extension
...
To avoid unnecessarily recreating the object during deserialization.
This has also been upstreamed to
https://github.com/fraillt/bitsery/pull/78 .
2021-06-10 23:43:45 +02:00
14e3ed2cd3
Add shared audio buffers config to IAudioProcessor::setupProcessing()
2021-06-10 21:37:42 +02:00
50c25c1cf0
💥 Reimplement VST2 audio processing
...
We now use shared memory to store the input and output audio buffers.
This means that we have to copy less data every processing cycle, since
a single copy to and a single copy from the shared memory object
suffices now. This should reduce the DSP load for VST2
plugins (especially when used in a plugin group) marginally to
significantly depending on the plugins used and the system
configuration.
2021-06-10 17:31:32 +02:00
80fa010af5
Prevent unnecessary copies in VST2 event handling
2021-06-10 17:31:32 +02:00
1bc804965c
Clean up lambdas in VST2 variant visitors
2021-06-10 16:53:55 +02:00
f99781c1b2
Make getting channel pointers noexcept
...
There should be no bounds checks in release mode anyways, and we'll
trust ourselves that this will be a simple lookup.
2021-06-10 16:09:55 +02:00
0370c64f99
Allow resizing shared memory buffers
2021-06-10 16:09:55 +02:00
23d99411c8
Define the Ack message in serialization/common.h
...
We're going to need this for VST2 audio processing.
2021-06-10 16:09:55 +02:00
503d8248c2
Refactor VST2 serialization primitives
...
Bundle all serialization function with the structs whenever possible to
simplify the serialization function, and add `Foo::Response` types so we
can make the `passthrough_event()` function slightly more type safe.
2021-06-10 13:13:01 +02:00
cacfc0b379
Fix serializing VST2 speaker arrangements
2021-06-10 13:05:47 +02:00
53d59f74d1
Reduce the VST2 events small vector capacities
...
Every DAW will just send all events in one go (and I think that's the
only way you should do it, but the VST2 spec is a bit leaky so who
knows). It wouldn't make much sense to preallocate more capacity,
because when DAWs do send all of those events individually they might
end up sending more than four of these anyways.
2021-06-10 12:43:54 +02:00
5a38a2e482
Lock mapped shared memory for audio buffers
2021-06-10 01:35:43 +02:00
Robbert van der Helm