vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-16 21:50:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Properly initialize the thread local objects

Browse Source 
Instead of doing assignment. Assignment will probably reinitialize every
cycle, and it also didn't work on one person's computer.
This commit is contained in:
Robbert van der Helm
2021-05-16 00:30:46 +02:00
parent 70a546d160
commit fc04e2edcb
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/communication/vst3.h
+2 -5
View File
@@ -212,11 +212,8 @@ class Vst3MessageHandler : public AdHocSocketHandler<Thread> {
// process data, since that's the only object where allocations can // process data, since that's the only object where allocations can
// happen. The other objects we're storing here are very small, so the // happen. The other objects we're storing here are very small, so the
// extra wasted memory shouldn't matter much. // extra wasted memory shouldn't matter much.
// FIXME: This of course doesn't work. The variant will have been thread_local std::optional<Request> persistent_object(
// reconstructed when the next process cycle hits, so we don't persistent_buffers ? std::make_optional<Request>() : std::nullopt);
// gain anything from this.
thread_local std::optional<Request> persistent_object =
persistent_buffers ? std::make_optional<Request>() : std::nullopt;
// Reading, processing, and writing back the response for the requests // Reading, processing, and writing back the response for the requests
// we receive works in the same way regardless of which socket we're // we receive works in the same way regardless of which socket we're