vanja/yabridge
1
0
Fork 0
mirror of https://github.com/robbert-vdh/yabridge.git synced 2026-05-09 20:29:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Run effVendorSpecific on the main thread

Browse Source 
This should fix a freeze in Renoise.
This commit is contained in:
Robbert van der Helm
2023-11-25 13:49:12 +01:00
parent 2d40054498
commit fa2b348fc2
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wine-host/bridges/vst2.cpp
+8 -4
View File
@@ -98,12 +98,16 @@ static const std::unordered_set<int> safe_mutually_recursive_requests{
* New Sonic Arts' Vice plugin spawns a new thread and calls drawing code * New Sonic Arts' Vice plugin spawns a new thread and calls drawing code
* while changing sample rate and block size. We'll need to see if doing * while changing sample rate and block size. We'll need to see if doing
* this on the main thread introduces any regressions. * this on the main thread introduces any regressions.
* NOTE: `effVendorSpecific` is used by Renoise to set the content scale, so it
* needs to run on the main thread:
*
* (<https://github.com/juce-framework/JUCE/blob/d054f0d14dcac387aebda44ce5d792b5e7a625b3/modules/juce_audio_plugin_client/juce_audio_plugin_client_VST2.cpp#L1812-L1814>)
*/ */
static const std::unordered_set<int> unsafe_requests{ static const std::unordered_set<int> unsafe_requests{
effOpen, effClose, effEditGetRect, effEditOpen, effOpen, effClose, effEditGetRect, effEditOpen,
effEditClose, effEditIdle, effEditTop, effMainsChanged, effEditClose, effEditIdle, effEditTop, effMainsChanged,
effGetChunk, effSetChunk, effBeginLoadBank, effBeginLoadProgram, effGetChunk, effSetChunk, effBeginLoadBank, effBeginLoadProgram,
effSetSampleRate, effSetBlockSize}; effSetSampleRate, effSetBlockSize, effVendorSpecific};
/** /**
* These opcodes from `unsafe_requests` should be run under realtime scheduling * These opcodes from `unsafe_requests` should be run under realtime scheduling